Basis\Cache

Complexity

Total Complexity

18

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

95.45%

Importance

Changes	4
Bugs	3	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	6	2
A	set()	0	12	1
B	wrap()	0	20	9
A	exists()	0	13	4
A	__construct()	0	10	2

<?php

namespace Basis;

use Carbon\Carbon;

class Cache
{
    private $converter;

    public function __construct(Filesystem $fs, Converter $converter)
    {
        $this->converter = $converter;
        $this->path = $fs->getPath('.cache');

The property path does not exist. Did you maybe forget to declare it?

        if (!is_dir($this->path)) {
            mkdir($this->path);
            @chown($this->path, 'www-data');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            @chgrp($this->path, 'www-data');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
    }

    private $cache = [];

    public function exists($key)
    {
        if (array_key_exists($key, $this->cache)) {
            return $this->cache[$key]['expire'] > Carbon::now()->getTimestamp();
        }
        $filename = $this->path . '/' . $key;
        if (file_exists($filename)) {
            if (!array_key_exists($key, $this->cache)) {
                $this->cache[$key] = include $filename;
            }
            return $this->cache[$key]['expire'] > Carbon::now()->getTimestamp();
        }
    }

    public function get($key)
    {
        if ($this->exists($key)) {
            return $this->converter->toObject($this->cache[$key]);
        }
    }

    public function set($key, $value)
    {
        $filename = $this->path . '/' . $key;
        $data = $this->converter->toArray($value);
        $string = '<?php return '.var_export($data, true).';';

        file_put_contents($filename, $string);
        @chown($filename, 'www-data');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        @chgrp($filename, 'www-data');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $this->cache[$key] = $data;
    }

    public function wrap($key, $callback)
    {
        if (!is_string($key)) {
            $key = md5(json_encode($key));
        }
        if ($this->exists($key)) {
            return $this->get($key);
        }
        $result = call_user_func($callback);
        $expire = null;
        if (is_array($result) && array_key_exists('expire', $result)) {
            $expire = $result['expire'];
        } elseif (is_object($result) && property_exists($result, 'expire')) {
            $expire = $result->expire;
        }
        if ($expire && $expire > Carbon::now()->getTimestamp()) {
            $this->set($key, $result);
        }
        return $result;
    }
}