Event::hasChanges() - Code Metrics - Inspection of "event changes using queue" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 96f8f0...f08c31 )

by Dmitry

created 2019-10-03 11:20 UTC

Event::hasChanges() A

↳ Parent: Event

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	6
cp	0
rs	9.9
c	0
b	0
f	0
cc	3
nc	3
nop	0
crap	12

<?php

namespace Basis;

use Basis\Dispatcher;
use ReflectionClass;
use Tarantool\Mapper\Plugin\Spy;
use Tarantool\Mapper\Pool;

class Event
{
    use Toolkit;

    public function getSubscription()
    {
        $subscription = [];
        foreach ($this->get(Filesystem::class)->listClasses('Listener') as $class) {
            $reflection = new ReflectionClass($class);
            if ($reflection->isAbstract()) {
                continue;
            }
            foreach ($reflection->getStaticPropertyValue('events') as $event) {
                if (!array_key_exists($event, $subscription)) {
                    $subscription[$event] = [];
                }
                $subscription[$event][] = substr($class, strlen('Listener\\'));
            }
        }

        return $subscription;
    }

    public function fire(string $event, $context)
    {
        $this->app->dispatch('event.fire', [
            'event'   => $this->get(Service::class)->getName().'.'.$event,
            'context' => $context,
        ]);
    }

    public function fireChangesPart(string $producer, int $fraction = 10)
    {
        if (++$this->counter % $fraction === 0) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return $this->fireChanges($producer);
        }
        return false;
    }

    public function hasChanges()
    {
        $hasChanges = false;

        foreach ($this->get(Pool::class)->getMappers() as $mapper) {
            if ($mapper->getPlugin(Spy::class)->hasChanges()) {
                $hasChanges = true;
            }
        }
        return $hasChanges;
    }

    public function fireChanges(string $producer)
    {
        $this->get(Pool::class)->get($this->get(Service::class)->getName());

        $dispatcher = $this->app->get(Dispatcher::class);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $changed = false;

        foreach ($this->get(Pool::class)->getMappers() as $mapper) {
            $spy = $mapper->getPlugin(Spy::class);
            if ($spy->hasChanges()) {
                // reduce changes list
                $changes = $spy->getChanges();
                foreach ($changes as $action => $collection) {
                    foreach ($collection as $space => $entities) {
                        $event = $this->get(Service::class)->getName().'.'.$space.'.'.$action;

                        if (!$this->get(Service::class)->eventExists($event)) {
                            unset($collection[$space]);
                        }
                    }
                    if (!count($collection)) {
                        unset($changes->$action);
                    }
                }

                if (count(get_object_vars($changes))) {
                    $changed = true;
                    $data = $this->get(Converter::class)->toArray([
                        'changes'  => $changes,
                        'producer' => $producer,
                        'service'  => $mapper->serviceName,
                        'context' => $this->get(Context::class),
                    ]);
                    $this->getQueue('event.changes')->put($data);
                }

                $spy->reset();
            }
        }
        return $changed;
    }
}


1		<?php
2
3		namespace Basis;
4
5		use Basis\Dispatcher;
6		use ReflectionClass;
7		use Tarantool\Mapper\Plugin\Spy;
8		use Tarantool\Mapper\Pool;
9
10		class Event
11		{
12		use Toolkit;
13
14	7	public function getSubscription()
15		{
16	7	$subscription = [];
17	7	foreach ($this->get(Filesystem::class)->listClasses('Listener') as $class) {
18	7	$reflection = new ReflectionClass($class);
19	7	if ($reflection->isAbstract()) {
20		continue;
21		}
22	7	foreach ($reflection->getStaticPropertyValue('events') as $event) {
23	7	if (!array_key_exists($event, $subscription)) {
24	7	$subscription[$event] = [];
25		}
26	7	$subscription[$event][] = substr($class, strlen('Listener\\'));
27		}
28		}
29
30	7	return $subscription;
31		}
32
33	1	public function fire(string $event, $context)
34		{
35	1	$this->app->dispatch('event.fire', [
36	1	'event' => $this->get(Service::class)->getName().'.'.$event,
37	1	'context' => $context,
38		]);
39	1	}
40
41		public function fireChangesPart(string $producer, int $fraction = 10)
42		{
43		if (++$this->counter % $fraction === 0) {
		0 ignored issues – show Bug introduced 2019-02-12 13:30 UTC by Report Bug Copy Issue Report The property `counter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44		return $this->fireChanges($producer);
45		}
46		return false;
47		}
48
49		public function hasChanges()
50		{
51		$hasChanges = false;
52
53		foreach ($this->get(Pool::class)->getMappers() as $mapper) {
54		if ($mapper->getPlugin(Spy::class)->hasChanges()) {
55		$hasChanges = true;
56		}
57		}
58		return $hasChanges;
59		}
60
61	1	public function fireChanges(string $producer)
62		{
63	1	$this->get(Pool::class)->get($this->get(Service::class)->getName());
64
65	1	$dispatcher = $this->app->get(Dispatcher::class);
		0 ignored issues – show Unused Code introduced 2019-10-03 11:23 UTC by Report Bug Copy Issue Report `$dispatcher` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66	1	$changed = false;
67
68	1	foreach ($this->get(Pool::class)->getMappers() as $mapper) {
69	1	$spy = $mapper->getPlugin(Spy::class);
70	1	if ($spy->hasChanges()) {
71		// reduce changes list
72		$changes = $spy->getChanges();
73		foreach ($changes as $action => $collection) {
74		foreach ($collection as $space => $entities) {
75		$event = $this->get(Service::class)->getName().'.'.$space.'.'.$action;
76
77		if (!$this->get(Service::class)->eventExists($event)) {
78		unset($collection[$space]);
79		}
80		}
81		if (!count($collection)) {
82		unset($changes->$action);
83		}
84		}
85
86		if (count(get_object_vars($changes))) {
87		$changed = true;
88		$data = $this->get(Converter::class)->toArray([
89		'changes' => $changes,
90		'producer' => $producer,
91		'service' => $mapper->serviceName,
92		'context' => $this->get(Context::class),
93		]);
94		$this->getQueue('event.changes')->put($data);
95		}
96
97		$spy->reset();
98		}
99		}
100	1	return $changed;
101		}
102		}
103

basis-company / framework.php

Push — master ( 96f8f0...f08c31 )

Event::hasChanges() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like