Completed
Push — master ( 0f3a09...bff253 )
by Dmitry
05:08
created

Http::process()   D

Complexity

Conditions 9
Paths 22

Size

Total Lines 35
Code Lines 23

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 15
CRAP Score 10.8889

Importance

Changes 0
Metric Value
dl 0
loc 35
ccs 15
cts 21
cp 0.7143
rs 4.909
c 0
b 0
f 0
cc 9
eloc 23
nc 22
nop 1
crap 10.8889
1
<?php
2
3
namespace Basis;
4
5
use League\Container\Container;
6
use LogicException;
7
8
class Http
9
{
10
    private $app;
11
12 1
    public function __construct(Application $app)
13
    {
14 1
        $this->app = $app;
15 1
    }
16
17 1
    public function process(string $uri): ?string
18
    {
19 1
        list($controller, $method) = $this->getChain($uri);
20 1
        $className = "Controller\\".ucfirst($controller);
21 1
        $class = $this->app->get(Filesystem::class)->completeClassName($className);
22 1
        if (!class_exists($class)) {
23
            $frameworkClass = $this->app->get(Framework::class)->completeClassName($className);
24
        }
25
26 1
        if (!class_exists($class)) {
27
            if (isset($frameworkClass) && !class_exists($frameworkClass)) {
28
                throw new LogicException("No class for $controller $controller, [$class, $frameworkClass]");
29
            }
30
            $class = $frameworkClass;
0 ignored issues
show
Bug introduced by
The variable $frameworkClass does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
31
        }
32
33 1
        if (!method_exists($class, $method)) {
34 1
            if (!method_exists($class, '__process')) {
35
                return "$controller/$method not found";
36
            }
37 1
            $url = substr($uri, strlen($controller)+2);
38 1
            $method = '__process';
39
        } else {
40 1
            $url = substr($uri, (strlen($controller) + strlen($method) + 3));
41
        }
42
43 1
        $container = $this->app->get(Container::class);
44 1
        $result = $container->call([$container->get($class), $method], ['url' => $url]);
45
46 1
        if (is_array($result) || is_object($result)) {
47
            return json_encode($result);
48
        } else {
49 1
            return $result;
50
        }
51
    }
52
53 1
    public function getChain(string $uri) : array
54
    {
55 1
        list($clean) = explode('?', $uri);
56 1
        $chain = [];
57 1
        foreach (explode('/', $clean) as $k => $v) {
58 1
            if ($v) {
59 1
                $chain[] = $v;
60
            }
61
        }
62
63 1
        if (!count($chain)) {
64 1
            $chain[] = 'index';
65
        }
66
67 1
        if (count($chain) == 1) {
68 1
            $chain[] = 'index';
69
        }
70
71 1
        return $chain;
72
    }
73
}
74