Event::index() - Code Metrics - Inspection of "event handler wildcard support" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 359e01...a426b2 )

by Dmitry

created 2018-01-19 13:04 UTC

Event::index() D

↳ Parent: Event

Complexity

Conditions	9
Paths	139

Size

Total Lines	41
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	41
ccs	0
cts	35
cp	0
rs	4.6666
cc	9
eloc	24
nc	139
nop	3
crap	90

<?php

namespace Basis\Controller;

use Basis\Application;
use Basis\Event as BasisEvent;
use Basis\Service;
use Exception;

class Event
{
    public function index(Application $app, BasisEvent $event, Service $service)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        try {
            $context = $this->getRequestContext();
            $subscription = $event->getSubscription();

            $patterns = [];
            foreach (array_keys($subscription) as $pattern) {
                if ($service->eventMatch($context->event, $pattern)) {
                    $patterns[] = $pattern;
                }
            }

            if (!count($patterns)) {
                $service->unsubscribe($context->event);
                throw new Exception("No subscription on event ".$_REQUEST['event'], 1);
            }

            $listeners = [];
            foreach ($patterns as $pattern) {
                foreach ($subscription[$pattern] as $listener) {
                    if (!array_key_exists($listener, $listeners)) {
                        $listeners[$listener] = $app->get('Listener\\'.$listener);
                    }
                }
            }

            $result = [];
            foreach ($listeners as $nick => $listener) {
                $result[$nick] = $this->handleEvent($app, $listener, $context);
            }

            return [
                'success' => true,
                'data' => $result,
            ];

        } catch (Exception $e) {
            return ['success' => false, 'message' => $e->getMessage()];
        }
    }

    private function getRequestContext()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!array_key_exists('event', $_REQUEST)) {
            throw new Exception('No event defined');
        }

        if (!array_key_exists('context', $_REQUEST)) {
            throw new Exception('No context defined');
        }

        $context = json_decode($_REQUEST['context']);

        if (!$context) {
            throw new Exception('Invalid context');
        }

        $context->event = $_REQUEST['event'];

        return $context;
    }

    private function handleEvent($app, $instance, $context)
    {
        foreach ($context as $k => $v) {
            $instance->$k = $v;
        }
        if (!method_exists($instance, 'run')) {
            throw new Exception('No run method for '.$class);
        }

        return $app->call([$instance, 'run']);
    }
}


1			<?php
2
3			namespace Basis\Controller;
4
5			use Basis\Application;
6			use Basis\Event as BasisEvent;
7			use Basis\Service;
8			use Exception;
9
10			class Event
11			{
12			public function index(Application $app, BasisEvent $event, Service $service)
			0 ignored issues – show Coding Style introduced 2017-08-13 10:52 UTC by Report Bug Copy Issue Report `index` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
13			{
14			try {
15			$context = $this->getRequestContext();
16			$subscription = $event->getSubscription();
17
18			$patterns = [];
19			foreach (array_keys($subscription) as $pattern) {
20			if ($service->eventMatch($context->event, $pattern)) {
21			$patterns[] = $pattern;
22			}
23			}
24
25			if (!count($patterns)) {
26			$service->unsubscribe($context->event);
27			throw new Exception("No subscription on event ".$_REQUEST['event'], 1);
28			}
29
30			$listeners = [];
31			foreach ($patterns as $pattern) {
32			foreach ($subscription[$pattern] as $listener) {
33			if (!array_key_exists($listener, $listeners)) {
34			$listeners[$listener] = $app->get('Listener\\'.$listener);
35			}
36			}
37			}
38
39			$result = [];
40			foreach ($listeners as $nick => $listener) {
41			$result[$nick] = $this->handleEvent($app, $listener, $context);
42			}
43
44			return [
45			'success' => true,
46			'data' => $result,
47			];
48
49			} catch (Exception $e) {
50			return ['success' => false, 'message' => $e->getMessage()];
51			}
52			}
53
54			private function getRequestContext()
			0 ignored issues – show Coding Style introduced 2018-01-18 13:54 UTC by Report Bug Copy Issue Report `getRequestContext` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
55			{
56			if (!array_key_exists('event', $_REQUEST)) {
57			throw new Exception('No event defined');
58			}
59
60			if (!array_key_exists('context', $_REQUEST)) {
61			throw new Exception('No context defined');
62			}
63
64			$context = json_decode($_REQUEST['context']);
65
66			if (!$context) {
67			throw new Exception('Invalid context');
68			}
69
70			$context->event = $_REQUEST['event'];
71
72			return $context;
73			}
74
75			private function handleEvent($app, $instance, $context)
76			{
77			foreach ($context as $k => $v) {
78			$instance->$k = $v;
79			}
80			if (!method_exists($instance, 'run')) {
81			throw new Exception('No run method for '.$class);
82			}
83
84			return $app->call([$instance, 'run']);
85			}
86			}
87

basis-company / framework.php

Push — master ( 359e01...a426b2 )

Event::index() D

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like