CoreProvider::register() - Code Metrics - Inspection of "fake mapper data sync" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1f1a8e...ab56b8 )

by Dmitry

created 2018-02-27 14:33 UTC

CoreProvider::register() B

↳ Parent: CoreProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	1

Importance

Changes	2
Bugs	2	Features	0

Metric	Value
dl	0
loc	26
ccs	20
cts	20
cp	1
rs	8.8571
c	2
b	2
f	0
cc	1
eloc	15
nc	1
nop	0
crap	1

<?php

namespace Basis\Provider;

use Basis\Application;
use Basis\Config;
use Basis\Converter;
use Basis\Dispatcher;
use Basis\Filesystem;
use Basis\Framework;
use Basis\Http;
use GuzzleHttp\Client;
use League\Container\ServiceProvider\AbstractServiceProvider;

class CoreProvider extends AbstractServiceProvider
{
    protected $provides = [
        Config::class,
        Converter::class,
        Dispatcher::class,
        Framework::class,
        Http::class,
    ];

    public function register()
    {
        $this->getContainer()->share(Config::class, function () {
            $framework = $this->getContainer()->get(Framework::class);
            $fs = $this->getContainer()->get(Filesystem::class);
            $converter = $this->getContainer()->get(Converter::class);
            return new Config($framework, $fs, $converter);
        });

        $this->getContainer()->share(Converter::class, function () {
            return new Converter();
        });

        $this->getContainer()->share(Dispatcher::class, function () {
            $client = $this->getContainer()->get(Client::class);
            return new Dispatcher($client);
        });

        $this->getContainer()->share(Framework::class, function () {
            return new Framework($this->getContainer(), dirname(dirname(__DIR__)));

        });

        $this->getContainer()->share(Http::class, function () {
            return new Http($this->getContainer()->get(Application::class));
        });
    }
}


1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Application;
6		use Basis\Config;
7		use Basis\Converter;
8		use Basis\Dispatcher;
9		use Basis\Filesystem;
10		use Basis\Framework;
11		use Basis\Http;
12		use GuzzleHttp\Client;
13		use League\Container\ServiceProvider\AbstractServiceProvider;
14
15		class CoreProvider extends AbstractServiceProvider
16		{
17		protected $provides = [
18		Config::class,
19		Converter::class,
20		Dispatcher::class,
21		Framework::class,
22		Http::class,
23		];
24
25		public function register()
26		{
27	37	$this->getContainer()->share(Config::class, function () {
28	37	$framework = $this->getContainer()->get(Framework::class);
29	37	$fs = $this->getContainer()->get(Filesystem::class);
30	37	$converter = $this->getContainer()->get(Converter::class);
31	37	return new Config($framework, $fs, $converter);
32	22	});
33
34	22	$this->getContainer()->share(Converter::class, function () {
35	22	return new Converter();
36	22	});
37
38	22	$this->getContainer()->share(Dispatcher::class, function () {
39	1	$client = $this->getContainer()->get(Client::class);
40	1	return new Dispatcher($client);
41	22	});
42
43	37	$this->getContainer()->share(Framework::class, function () {
44	37	return new Framework($this->getContainer(), dirname(dirname(__DIR__)));
		0 ignored issues – show Compatibility introduced 2017-11-10 06:46 UTC by Report Bug Copy Issue Report `$this->getContainer()` of type `object<League\Container\ContainerInterface>` is not a sub-type of `object<Basis\Application>`. It seems like you assume a concrete implementation of the interface `League\Container\ContainerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
45	22	});
46
47	22	$this->getContainer()->share(Http::class, function () {
48	1	return new Http($this->getContainer()->get(Application::class));
49	22	});
50	22	}
51		}
52

basis-company / framework.php

Push — master ( 1f1a8e...ab56b8 )

CoreProvider::register() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like