These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace Basis\Provider; |
||
4 | |||
5 | use Basis\Service; |
||
6 | use League\Container\ServiceProvider\AbstractServiceProvider; |
||
7 | use Predis\Client; |
||
8 | |||
9 | class PredisProvider extends AbstractServiceProvider |
||
10 | { |
||
11 | protected $provides = [ |
||
12 | Client::class, |
||
13 | ]; |
||
14 | |||
15 | public function register() |
||
16 | { |
||
17 | $this->getContainer()->share(Client::class, function () { |
||
0 ignored issues
–
show
|
|||
18 | $service = $this->getContainer()->get(Service::class); |
||
19 | $host = getenv('REDIS_SERVICE_HOST'); |
||
20 | if (!$host) { |
||
21 | $redisService = $service->getName().'-redis'; |
||
22 | $host = $service->getHost($redisService)->address; |
||
23 | } |
||
24 | $client = new Client([ |
||
25 | 'scheme' => 'tcp', |
||
26 | 'host' => $host, |
||
27 | 'port' => 6379, |
||
28 | ]); |
||
29 | return $client; |
||
30 | }); |
||
31 | } |
||
32 | } |
||
33 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: