| Conditions | 12 |
| Paths | 20 |
| Total Lines | 35 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 22 |
| CRAP Score | 12 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | 37 | public function dispatch(string $job, array $params = [], string $service = null) |
|
| 23 | { |
||
| 24 | 37 | if (array_key_exists($job, $this->test->mockInstances)) { |
|
| 25 | 7 | $mocks = $this->test->mockInstances[$job]; |
|
| 26 | 7 | $valid = null; |
|
| 27 | 7 | foreach ($mocks as $mock) { |
|
| 28 | 7 | if ($mock->params == $params || (!$mock->params && !$valid)) { |
|
| 29 | 7 | $valid = $mock; |
|
| 30 | } |
||
| 31 | } |
||
| 32 | 7 | if ($valid) { |
|
| 33 | 7 | $result = $valid->result; |
|
| 34 | 7 | if (is_callable($result)) { |
|
| 35 | 4 | $result = $result($params); |
|
| 36 | } |
||
| 37 | 7 | $valid->calls++; |
|
| 38 | 7 | return $this->get(Converter::class)->toObject($result); |
|
| 39 | } |
||
| 40 | } |
||
| 41 | 37 | if ($this->test->disableRemote) { |
|
| 42 | 36 | if (!$this->get(Runner::class)->hasJob($job)) { |
|
| 43 | 1 | throw new Exception("Remote calls ($job) are disabled for tests"); |
|
| 44 | } |
||
| 45 | } |
||
| 46 | |||
| 47 | 37 | $converter = $this->get(Converter::class); |
|
| 48 | |||
| 49 | 37 | $global = $this->test->params ?: []; |
|
| 50 | 37 | $global = $converter->toObject($global); |
|
| 51 | 37 | if (is_object($global)) { |
|
| 52 | 2 | $global = get_object_vars($global); |
|
| 53 | } |
||
| 54 | |||
| 55 | 37 | return parent::dispatch($job, array_merge($params, $global), $service); |
|
| 56 | } |
||
| 57 | } |
||
| 58 |