Application::get() - Code Metrics - Inspection of "major mapper update" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 772acc...7ea003 )

by Dmitry

created 2017-10-31 12:08 UTC

Application::get() A

↳ Parent: Application

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	8.7414

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
ccs	3
cts	9
cp	0.3333
rs	9.2
cc	4
eloc	9
nc	3
nop	2
crap	8.7414

<?php

namespace Basis;

use League\Container\Container;
use League\Container\ReflectionContainer;
use Tarantool\Mapper\Mapper;
use Tarantool\Mapper\Plugin\Annotation;
use Tarantool\Mapper\Repository;

class Application extends Container
{
    public function __construct(string $root)
    {
        parent::__construct();

        $fs = new Filesystem($this, $root);

        $this->share(Application::class, $this);
        $this->share(Container::class, $this);
        $this->share(Filesystem::class, $fs);

        $this->addServiceProvider(Provider\CoreProvider::class);
        $this->addServiceProvider(Provider\ServiceProvider::class);
        $this->addServiceProvider(Provider\TarantoolProvider::class);

        foreach ($fs->listClasses('Provider') as $provider) {
            $this->addServiceProvider($provider);
        }

        $this->delegate(new ReflectionContainer());
    }

    public function dispatch(string $job, array $params = [], string $service = null)
    {
        if ($service) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if ($this->get(Service::class)->getName() == $service) {
                $service = null;
            }
        }

        $runner = $this->get(Runner::class);
        if (!$service && $runner->hasJob($job)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $runner->dispatch($job, $params);
        }

        $dispatcher = $this->get(Dispatcher::class);
        return $dispatcher->dispatch($job, $params, $service);
    }

    public function get($alias, array $args = [])
    {
        if (!$this->hasShared($alias, true) && is_subclass_of($alias, Repository::class)) {

            $spaceName = $this->get(Mapper::class)
                ->getPlugin(Annotation::class)
                ->getRepositorySpaceName($alias);

            if ($spaceName) {
                $instance = $this->get(Mapper::class)->getRepository($spaceName);
                $this->share($alias, $instance);
            }
        }
        return parent::get($alias, $args);
    }
}


1		<?php
2
3		namespace Basis;
4
5		use League\Container\Container;
6		use League\Container\ReflectionContainer;
7		use Tarantool\Mapper\Mapper;
8		use Tarantool\Mapper\Plugin\Annotation;
9		use Tarantool\Mapper\Repository;
10
11		class Application extends Container
12		{
13	11	public function __construct(string $root)
14		{
15	11	parent::__construct();
16
17	11	$fs = new Filesystem($this, $root);
18
19	11	$this->share(Application::class, $this);
20	11	$this->share(Container::class, $this);
21	11	$this->share(Filesystem::class, $fs);
22
23	11	$this->addServiceProvider(Provider\CoreProvider::class);
24	11	$this->addServiceProvider(Provider\ServiceProvider::class);
25	11	$this->addServiceProvider(Provider\TarantoolProvider::class);
26
27	11	foreach ($fs->listClasses('Provider') as $provider) {
28	11	$this->addServiceProvider($provider);
29		}
30
31	11	$this->delegate(new ReflectionContainer());
32	11	}
33
34	6	public function dispatch(string $job, array $params = [], string $service = null)
35		{
36	6	if ($service) {
		0 ignored issues – show Bug Best Practice introduced 2017-08-26 09:47 UTC by Report Bug Copy Issue Report The expression `$service` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37		if ($this->get(Service::class)->getName() == $service) {
38		$service = null;
39		}
40		}
41
42	6	$runner = $this->get(Runner::class);
43	6	if (!$service && $runner->hasJob($job)) {
		0 ignored issues – show Bug Best Practice introduced 2017-08-26 09:47 UTC by Report Bug Copy Issue Report The expression `$service` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
44	6	return $runner->dispatch($job, $params);
45		}
46
47		$dispatcher = $this->get(Dispatcher::class);
48		return $dispatcher->dispatch($job, $params, $service);
49		}
50
51	11	public function get($alias, array $args = [])
52		{
53	11	if (!$this->hasShared($alias, true) && is_subclass_of($alias, Repository::class)) {
		0 ignored issues – show Bug introduced 2017-05-18 09:48 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Tarantool\Mapper\Repository::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
54		$spaceName = $this->get(Mapper::class)
55		->getPlugin(Annotation::class)
56		->getRepositorySpaceName($alias);
57
58		if ($spaceName) {
59		$instance = $this->get(Mapper::class)->getRepository($spaceName);
60		$this->share($alias, $instance);
61		}
62		}
63	11	return parent::get($alias, $args);
64		}
65		}
66

basis-company / framework.php

Push — master ( 772acc...7ea003 )

Application::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like