basis-company /
framework.php
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 25 |
| Code Lines | 14 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 18 |
| CRAP Score | 1.0001 |
| Changes | 2 | ||
| Bugs | 2 | Features | 0 |
| 1 | <?php |
||
| 24 | public function register() |
||
| 25 | { |
||
| 26 | 21 | $this->getContainer()->share(Config::class, function () { |
|
| 27 | 21 | $framework = $this->getContainer()->get(Framework::class); |
|
| 28 | 21 | $fs = $this->getContainer()->get(Filesystem::class); |
|
| 29 | 21 | $converter = $this->getContainer()->get(Converter::class); |
|
| 30 | 21 | return new Config($framework, $fs, $converter); |
|
| 31 | 21 | }); |
|
| 32 | |||
| 33 | 21 | $this->getContainer()->share(Converter::class, function () { |
|
| 34 | 21 | return new Converter(); |
|
| 35 | 21 | }); |
|
| 36 | |||
| 37 | 21 | $this->getContainer()->share(Dispatcher::class, function () { |
|
| 38 | return new Dispatcher(); |
||
| 39 | 21 | }); |
|
| 40 | |||
| 41 | 21 | $this->getContainer()->share(Framework::class, function () { |
|
| 42 | 21 | return new Framework($this->getContainer(), dirname(dirname(__DIR__))); |
|
|
|
|||
| 43 | 21 | }); |
|
| 44 | |||
| 45 | 21 | $this->getContainer()->share(Http::class, function () { |
|
| 46 | 1 | return new Http($this->getContainer()->get(Application::class)); |
|
| 47 | 21 | }); |
|
| 48 | 21 | } |
|
| 49 | } |
||
| 50 |
This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.
Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.