Lock::unlock() - Code Metrics - Inspection of "implement redis basis.lock" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 073c6d...49d4ca )

by Dmitry

created 2018-11-01 18:20 UTC

Lock::unlock() A

↳ Parent: Lock

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	14
cp	0
rs	9.7333
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	20

<?php

namespace Basis;

use Exception;
use Predis\Client;

class Lock
{
    private $redis;
    private $locks = [];

    public function __construct(Client $redis)
    {
        $this->redis = $redis;
        register_shutdown_function([$this, 'releaseLocks']);
    }

    public function acquire($name, $ttl = 1)
    {
        while (!$this->lock($name, $ttl)) {
            $this->waitUnlock($name);
        }
        return true;
    }

    public function exists($name)
    {
        return $this->redis->get("lock-$name") !== null;
    }

    public function lock($name, $ttl = 1)
    {
        if (in_array($name, $this->locks)) {
            throw new Exception("Lock $name was already registered");
        }
        $result = $this->redis->set("lock-$name", 1, 'EX', $ttl, 'NX');
        if ($result) {
            $this->locks[] = $name;
            return true;
        }
        return false;
    }

    public function releaseLocks()
    {
        foreach ($this->locks as $name) {
            $this->unlock($name);
        }
    }

    public function unlock($name)
    {
        if (!in_array($name, $this->locks)) {
            throw new Exception("Lock $name was already registered");
        }
        
        foreach ($this->locks as $i => $candidate) {
            if ($candidate == $name) {
                unset($this->locks[$i]);
                $this->redis->del("lock-$name");
                break;
            }
        }

        $this->locks = array_values($this->locks);
    }

    public function waitUnlock($name)
    {
        while ($this->exists($name)) {
            usleep(100);
        }
        return true;
    }
}


1			<?php
2
3			namespace Basis;
4
5			use Exception;
6			use Predis\Client;
7
8			class Lock
9			{
10			private $redis;
11			private $locks = [];
12
13			public function __construct(Client $redis)
14			{
15			$this->redis = $redis;
16			register_shutdown_function([$this, 'releaseLocks']);
17			}
18
19			public function acquire($name, $ttl = 1)
20			{
21			while (!$this->lock($name, $ttl)) {
22			$this->waitUnlock($name);
23			}
24			return true;
25			}
26
27			public function exists($name)
28			{
29			return $this->redis->get("lock-$name") !== null;
30			}
31
32			public function lock($name, $ttl = 1)
33			{
34			if (in_array($name, $this->locks)) {
35			throw new Exception("Lock $name was already registered");
36			}
37			$result = $this->redis->set("lock-$name", 1, 'EX', $ttl, 'NX');
38			if ($result) {
39			$this->locks[] = $name;
40			return true;
41			}
42			return false;
43			}
44
45			public function releaseLocks()
46			{
47			foreach ($this->locks as $name) {
48			$this->unlock($name);
49			}
50			}
51
52			public function unlock($name)
53			{
54			if (!in_array($name, $this->locks)) {
55			throw new Exception("Lock $name was already registered");
56			}
57
58			foreach ($this->locks as $i => $candidate) {
59			if ($candidate == $name) {
60			unset($this->locks[$i]);
61			$this->redis->del("lock-$name");
62			break;
63			}
64			}
65
66			$this->locks = array_values($this->locks);
67			}
68
69			public function waitUnlock($name)
70			{
71			while ($this->exists($name)) {
72			usleep(100);
73			}
74			return true;
75			}
76			}
77

basis-company / framework.php

Push — master ( 073c6d...49d4ca )

Lock::unlock() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like