TestingTest::test() - Code Metrics - Inspection of "add test.mock, extract toolkit" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1ea0c...72efe0 )

by Dmitry

created 2017-12-12 15:31 UTC

TestingTest::test() B

↳ Parent: TestingTest

Complexity

Conditions	4
Paths	1

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	29
rs	8.5806
cc	4
eloc	17
nc	1
nop	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	TestingTest.php$0 ➔ testMock()	0	21	4

<?php

namespace Test;

use Basis\Filesystem;
use Basis\Job;
use Basis\Test;

class TestingTest extends TestSuite
{
    public function test()
    {
        $userTest = new class($this->app) extends Test {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            public function testMock($frameworkTest)
            {
                $config = [
                    [['name' => 'nekufa'], ['value' => 'nekufa!']],
                    [['name' => 'bazyaba'], function () {
                        return ['value' => 'bazyaba!'];
                    }],
                    [[], ['value' => 'anonymous!']],
                ];
                foreach ($config as [$params, $value]) {
                    $this->mock('service.call', $params)->willReturn($value);
function someFunction() {
    $x = 5;
    echo $x;
}
                }

                foreach ($config as [$params, $value]) {
                    $result = $this->dispatch('service.call', $params);
                    if (is_callable($value)) {
                        $value = $value();
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    }
                    $frameworkTest->assertSame($result, $value);
                }
            }
        };

        $userTest->setup();
        $userTest->testMock($this);
    }
}


1			<?php
2
3			namespace Test;
4
5			use Basis\Filesystem;
6			use Basis\Job;
7			use Basis\Test;
8
9			class TestingTest extends TestSuite
10			{
11			public function test()
12			{
13			$userTest = new class($this->app) extends Test {
			0 ignored issues – show Documentation introduced 2017-12-12 15:34 UTC by Report Bug Copy Issue Report `$this->app` is of type `object<Basis\Application>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
14			public function testMock($frameworkTest)
15			{
16			$config = [
17			[['name' => 'nekufa'], ['value' => 'nekufa!']],
18			[['name' => 'bazyaba'], function () {
19			return ['value' => 'bazyaba!'];
20			}],
21			[[], ['value' => 'anonymous!']],
22			];
23			foreach ($config as [$params, $value]) {
24			$this->mock('service.call', $params)->willReturn($value);
			0 ignored issues – show Bug introduced 2017-12-12 15:34 UTC by Report Bug Copy Issue Report The variable `$params` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-12-12 15:34 UTC by Report Bug Copy Issue Report The variable `$value` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
25			}
26
27			foreach ($config as [$params, $value]) {
28			$result = $this->dispatch('service.call', $params);
29			if (is_callable($value)) {
30			$value = $value();
			0 ignored issues – show Bug introduced 2017-12-12 15:34 UTC by Report Bug Copy Issue Report The variable `$value` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
31			}
32			$frameworkTest->assertSame($result, $value);
33			}
34			}
35			};
36
37			$userTest->setup();
38			$userTest->testMock($this);
39			}
40			}
41

basis-company / framework.php

Push — master ( d1ea0c...72efe0 )

TestingTest::test() B

Complexity

Size

Duplication

Importance

1 Method

Available Fixes

Duplication Side-by-Side

Filter issues like