ServiceProvider::register() - Code Metrics - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

ServiceProvider::register() A
last analyzed 2020-03-03 11:24 UTC

↳ Parent: ServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1.343

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	3
cts	10
cp	0.3
rs	9.7998
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1.343

<?php

namespace Basis\Provider;

use Basis\Application;
use Basis\Cache;
use Basis\Config;
use Basis\Event;
use Basis\Filesystem;
use Basis\Service;
use League\Container\ServiceProvider\AbstractServiceProvider;
use Tarantool\Mapper\Pool;

class ServiceProvider extends AbstractServiceProvider
{
    protected $provides = [
        Event::class,
        Service::class,
    ];

    public function register()
    {
        $this->getContainer()->share(Event::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $app = $this->getContainer()->get(Application::class);
            return new Event($app);
        });

        $this->getContainer()->share(Service::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $config = $this->getContainer()->get(Config::class);
            $app = $this->getContainer()->get(Application::class);
            $cache = $this->getContainer()->get(Cache::class);
            return new Service($config['service'], $app, $cache);
        });
    }
}


ServiceProvider::register() A
last analyzed 2020-03-03 11:24 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Application;
6		use Basis\Cache;
7		use Basis\Config;
8		use Basis\Event;
9		use Basis\Filesystem;
10		use Basis\Service;
11		use League\Container\ServiceProvider\AbstractServiceProvider;
12		use Tarantool\Mapper\Pool;
13
14		class ServiceProvider extends AbstractServiceProvider
15		{
16		protected $provides = [
17		Event::class,
18		Service::class,
19		];
20
21	5	public function register()
22		{
23		$this->getContainer()->share(Event::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24	5	$app = $this->getContainer()->get(Application::class);
25	5	return new Event($app);
26		});
27
28		$this->getContainer()->share(Service::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
29		$config = $this->getContainer()->get(Config::class);
30		$app = $this->getContainer()->get(Application::class);
31		$cache = $this->getContainer()->get(Cache::class);
32		return new Service($config['service'], $app, $cache);
33		});
34		}
35		}
36

basis-company / framework.php

ServiceProvider::register() A last analyzed 2020-03-03 11:24 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ServiceProvider::register() A
last analyzed 2020-03-03 11:24 UTC