ClickhouseProvider::register() - Code Metrics - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

ClickhouseProvider::register() A
last analyzed 2020-03-03 11:24 UTC

↳ Parent: ClickhouseProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	11
cts	11
cp	1
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace Basis\Provider;

use Basis\Clickhouse;
use Basis\Config;
use Basis\Service;
use ClickHouseDB\Client;
use League\Container\ServiceProvider\AbstractServiceProvider;

class ClickhouseProvider extends AbstractServiceProvider
{
    protected $provides = [
        Client::class,
    ];

    public function register()
    {
        $this->getContainer()->share(Clickhouse::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new Clickhouse($this->getContainer());

        });

        $this->getContainer()->share(Client::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $serviceName = $this->getContainer()->get(Service::class)->getName();
            $config = $this->getContainer()->get(Config::class)['clickhouse'];

            $clickhouse = new Client($config);
            $clickhouse->write('create database if not exists '.$serviceName);
            $clickhouse->database($serviceName);

            return $clickhouse;
        });
    }
}


ClickhouseProvider::register() A
last analyzed 2020-03-03 11:24 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Clickhouse;
6		use Basis\Config;
7		use Basis\Service;
8		use ClickHouseDB\Client;
9		use League\Container\ServiceProvider\AbstractServiceProvider;
10
11		class ClickhouseProvider extends AbstractServiceProvider
12		{
13		protected $provides = [
14		Client::class,
15		];
16
17	3	public function register()
18		{
19		$this->getContainer()->share(Clickhouse::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
20	2	return new Clickhouse($this->getContainer());
		0 ignored issues – show Compatibility introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report `$this->getContainer()` of type `object<Psr\Container\ContainerInterface>` is not a sub-type of `object<Basis\Application>`. It seems like you assume a concrete implementation of the interface `Psr\Container\ContainerInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
21	3	});
22
23		$this->getContainer()->share(Client::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24	3	$serviceName = $this->getContainer()->get(Service::class)->getName();
25	3	$config = $this->getContainer()->get(Config::class)['clickhouse'];
26
27	3	$clickhouse = new Client($config);
28	3	$clickhouse->write('create database if not exists '.$serviceName);
29	3	$clickhouse->database($serviceName);
30
31	3	return $clickhouse;
32	3	});
33	3	}
34		}
35

basis-company / framework.php

ClickhouseProvider::register() A last analyzed 2020-03-03 11:24 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ClickhouseProvider::register() A
last analyzed 2020-03-03 11:24 UTC