| Conditions | 1 |
| Paths | 1 |
| Total Lines | 148 |
| Code Lines | 89 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 114 | public function testFlatToNestedComplexTree() |
||
| 115 | { |
||
| 116 | $flatTree = [ |
||
| 117 | [ |
||
| 118 | 'id' => '1', |
||
| 119 | 'parent' => null, |
||
| 120 | 'level' => 1, |
||
| 121 | ], |
||
| 122 | [ |
||
| 123 | 'id' => '1.2', |
||
| 124 | 'parent' => '1', |
||
| 125 | 'level' => 2, |
||
| 126 | ], |
||
| 127 | [ |
||
| 128 | 'id' => '1.2.1', |
||
| 129 | 'parent' => '1.2', |
||
| 130 | 'level' => 3, |
||
| 131 | ], |
||
| 132 | [ |
||
| 133 | 'id' => '1.2.1.1', |
||
| 134 | 'parent' => '1.2.1', |
||
| 135 | 'level' => 4, |
||
| 136 | ], |
||
| 137 | [ |
||
| 138 | 'id' => '2.1', |
||
| 139 | 'parent' => '1', |
||
| 140 | 'level' => 2, |
||
| 141 | ], |
||
| 142 | [ |
||
| 143 | 'id' => '2.1.1', |
||
| 144 | 'parent' => '2.1', |
||
| 145 | 'level' => 3, |
||
| 146 | ], |
||
| 147 | [ |
||
| 148 | 'id' => '2.1.2', |
||
| 149 | 'parent' => '2.1', |
||
| 150 | 'level' => 3, |
||
| 151 | ], |
||
| 152 | [ |
||
| 153 | 'id' => '2.1.3', |
||
| 154 | 'parent' => '2.1', |
||
| 155 | 'level' => 3, |
||
| 156 | ], |
||
| 157 | [ |
||
| 158 | 'id' => '2', |
||
| 159 | 'parent' => null, |
||
| 160 | 'level' => 1, |
||
| 161 | ], |
||
| 162 | [ |
||
| 163 | 'id' => '2.1', |
||
| 164 | 'parent' => '2', |
||
| 165 | 'level' => 2, |
||
| 166 | ], |
||
| 167 | [ |
||
| 168 | 'id' => '2.1.1', |
||
| 169 | 'parent' => '2.1', |
||
| 170 | 'level' => 3, |
||
| 171 | ], |
||
| 172 | [ |
||
| 173 | 'id' => '2.2', |
||
| 174 | 'parent' => '2', |
||
| 175 | 'level' => 2, |
||
| 176 | ], |
||
| 177 | ]; |
||
| 178 | $result = Utilities::flatToNested($flatTree); |
||
| 179 | |||
| 180 | $this->assertEquals( |
||
| 181 | [ |
||
| 182 | [ |
||
| 183 | 'id' => '1', |
||
| 184 | 'parent' => null, |
||
| 185 | 'level' => 1, |
||
| 186 | '_children' => [ |
||
| 187 | [ |
||
| 188 | 'id' => '1.2', |
||
| 189 | 'parent' => '1', |
||
| 190 | 'level' => 2, |
||
| 191 | '_children' => [ |
||
| 192 | [ |
||
| 193 | 'id' => '1.2.1', |
||
| 194 | 'parent' => '1.2', |
||
| 195 | 'level' => 3, |
||
| 196 | '_children' => [ |
||
| 197 | [ |
||
| 198 | 'id' => '1.2.1.1', |
||
| 199 | 'parent' => '1.2.1', |
||
| 200 | 'level' => 4, |
||
| 201 | '_children' => [], |
||
| 202 | ], |
||
| 203 | ], |
||
| 204 | ], |
||
| 205 | ], |
||
| 206 | ], |
||
| 207 | [ |
||
| 208 | 'id' => '2.1', |
||
| 209 | 'parent' => '1', |
||
| 210 | 'level' => 2, |
||
| 211 | '_children' => [ |
||
| 212 | [ |
||
| 213 | 'id' => '2.1.1', |
||
| 214 | 'parent' => '2.1', |
||
| 215 | 'level' => 3, |
||
| 216 | '_children' => [], |
||
| 217 | ], |
||
| 218 | [ |
||
| 219 | 'id' => '2.1.2', |
||
| 220 | 'parent' => '2.1', |
||
| 221 | 'level' => 3, |
||
| 222 | '_children' => [], |
||
| 223 | ], |
||
| 224 | [ |
||
| 225 | 'id' => '2.1.3', |
||
| 226 | 'parent' => '2.1', |
||
| 227 | 'level' => 3, |
||
| 228 | '_children' => [], |
||
| 229 | ], |
||
| 230 | ], |
||
| 231 | ], |
||
| 232 | ], |
||
| 233 | ], |
||
| 234 | [ |
||
| 235 | 'id' => '2', |
||
| 236 | 'parent' => null, |
||
| 237 | 'level' => 1, |
||
| 238 | '_children' => [ |
||
| 239 | [ |
||
| 240 | 'id' => '2.1', |
||
| 241 | 'parent' => '2', |
||
| 242 | 'level' => 2, |
||
| 243 | '_children' => [ |
||
| 244 | [ |
||
| 245 | 'id' => '2.1.1', |
||
| 246 | 'parent' => '2.1', |
||
| 247 | 'level' => 3, |
||
| 248 | '_children' => [], |
||
| 249 | ], |
||
| 250 | ], |
||
| 251 | ], |
||
| 252 | [ |
||
| 253 | 'id' => '2.2', |
||
| 254 | 'parent' => '2', |
||
| 255 | 'level' => 2, |
||
| 256 | '_children' => [], |
||
| 257 | ], |
||
| 258 | ], |
||
| 259 | ], |
||
| 260 | ], $result); |
||
| 261 | } |
||
| 262 | |||
| 308 |