StefanoTree\NestedSet\MoveStrategy\Bottom

Complexity

Total Complexity

25

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

90.48%

Importance

Changes	6
Bugs	2	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getNewParentId()	0	5	1
A	getLevelShift()	0	4	1
A	getHoleLeftIndex()	0	10	4
A	getHoleRightIndex()	0	10	4
A	getSourceNodeIndexShift()	0	11	4
A	fixHoleFromIndex()	0	10	4
A	makeHoleFromIndex()	0	4	1
A	canMoveBranch()	0	8	3
A	isSourceNodeAtRequiredPosition()	0	9	3

<?php
namespace StefanoTree\NestedSet\MoveStrategy;

use StefanoTree\Exception;

class Bottom
    extends MoveStrategyAbstract

The extends keyword must be on the same line as the class name

{
    public function getNewParentId()
    {
        return $this->getTargetNode()
                    ->getParentId();
    }

    public function getLevelShift()
    {
        return $this->getTargetNode()->getLevel() - $this->getSourceNode()->getLevel();
    }

    public function getHoleLeftIndex()
    {
        if ($this->isMovedToRoot() || $this->isMovedDown()) {
            return $this->getSourceNode()->getLeft();
        } elseif ($this->isMovedUp()) {
            return $this->getSourceNode()->getLeft() + $this->getIndexShift();
        } else {
            throw new Exception\BaseException('Cannot move node');
        }
    }

    public function getHoleRightIndex()
    {
        if ($this->isMovedToRoot() || $this->isMovedDown()) {
            return $this->getSourceNode()->getRight();
        } elseif ($this->isMovedUp()) {
            return $this->getSourceNode()->getRight() + $this->getIndexShift();
        } else {
            throw new Exception\BaseException('Cannot move node');
        }
    }

    public function getSourceNodeIndexShift()
    {
        if ($this->isMovedToRoot() || $this->isMovedDown()) {
            return $this->getTargetNode()->getRight() - $this->getSourceNode()->getLeft() + 1;
        } elseif ($this->isMovedUp()) {
            return $this->getTargetNode()->getRight() - $this->getSourceNode()->getLeft()
                + 1 - $this->getIndexShift();
        } else {
            throw new Exception\BaseException('Cannot move node');
        }
    }

    public function fixHoleFromIndex()
    {
        if ($this->isMovedToRoot() || $this->isMovedDown()) {
            return $this->getSourceNode()->getLeft();
        } elseif ($this->isMovedUp()) {
            return $this->getSourceNode()->getLeft() + $this->getIndexShift();
        } else {
            throw new Exception\BaseException('Cannot move node');
        }
    }

    public function makeHoleFromIndex()
    {
        return $this->getTargetNode()->getRight();
    }

    public function canMoveBranch()
    {
        if (false == parent::canMoveBranch()) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return false;
        }

        return ($this->getTargetNode()->isRoot()) ? false : true;
    }

    public function isSourceNodeAtRequiredPosition()
    {
        $sourceNode = $this->getSourceNode();
        $targetNode = $this->getTargetNode();

        return ($targetNode->getRight() == ($sourceNode->getLeft() - 1) &&
                $targetNode->getParentId() == $sourceNode->getParentId()) ?
            true : false;
    }
}