| Conditions | 4 | 
| Paths | 5 | 
| Total Lines | 144 | 
| Code Lines | 32 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 4 | ||
| Bugs | 0 | Features | 0 | 
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 22 | public static function createDbScheme()  | 
            ||
| 23 |     { | 
            ||
| 24 | $connection = self::getPDOConnection();  | 
            ||
| 25 | |||
| 26 | $queries = array();  | 
            ||
| 27 | |||
| 28 |         if ('mysql' == TEST_STEFANO_DB_VENDOR) { | 
            ||
| 
                                                                                                    
                        
                         | 
                |||
| 29 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal';  | 
            ||
| 30 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_with_scope';  | 
            ||
| 31 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_metadata';  | 
            ||
| 32 | |||
| 33 | $queries[] = 'CREATE TABLE `tree_traversal` (  | 
            ||
| 34 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT,  | 
            ||
| 35 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL,  | 
            ||
| 36 | `lft` int(11) NOT NULL,  | 
            ||
| 37 | `rgt` int(11) NOT NULL,  | 
            ||
| 38 | `parent_id` int(11) DEFAULT NULL,  | 
            ||
| 39 | `level` int(11) DEFAULT NULL,  | 
            ||
| 40 | PRIMARY KEY (`tree_traversal_id`),  | 
            ||
| 41 | KEY `parent_id` (`parent_id`),  | 
            ||
| 42 | KEY `level` (`level`),  | 
            ||
| 43 | KEY `lft` (`lft`),  | 
            ||
| 44 | KEY `rgt` (`rgt`)  | 
            ||
| 45 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin';  | 
            ||
| 46 | |||
| 47 | $queries[] = 'ALTER TABLE `tree_traversal`  | 
            ||
| 48 | ADD FOREIGN KEY (`parent_id`)  | 
            ||
| 49 | REFERENCES `tree_traversal` (`tree_traversal_id`)  | 
            ||
| 50 | ON DELETE CASCADE ON UPDATE CASCADE';  | 
            ||
| 51 | |||
| 52 | $queries[] = 'CREATE TABLE `tree_traversal_with_scope` (  | 
            ||
| 53 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT,  | 
            ||
| 54 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL,  | 
            ||
| 55 | `lft` int(11) NOT NULL,  | 
            ||
| 56 | `rgt` int(11) NOT NULL,  | 
            ||
| 57 | `parent_id` int(11) DEFAULT NULL,  | 
            ||
| 58 | `level` int(11) DEFAULT NULL,  | 
            ||
| 59 | `scope` int(11) NOT NULL,  | 
            ||
| 60 | PRIMARY KEY (`tree_traversal_id`),  | 
            ||
| 61 | KEY `parent_id` (`parent_id`),  | 
            ||
| 62 | KEY `level` (`level`),  | 
            ||
| 63 | KEY `lft` (`lft`),  | 
            ||
| 64 | KEY `rgt` (`rgt`),  | 
            ||
| 65 | KEY `scope` (`scope`)  | 
            ||
| 66 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin';  | 
            ||
| 67 | |||
| 68 | $queries[] = 'CREATE TABLE `tree_traversal_metadata` (  | 
            ||
| 69 | `tree_traversal_metadata_id` int(11) NOT NULL AUTO_INCREMENT,  | 
            ||
| 70 | `tree_traversal_id` int(11) NOT NULL,  | 
            ||
| 71 | `lft` int(11) DEFAULT NULL,  | 
            ||
| 72 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL,  | 
            ||
| 73 | PRIMARY KEY (`tree_traversal_metadata_id`),  | 
            ||
| 74 | KEY `tree_traversal_id` (`tree_traversal_id`)  | 
            ||
| 75 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin';  | 
            ||
| 76 | |||
| 77 | $queries[] = 'ALTER TABLE `tree_traversal_with_scope`  | 
            ||
| 78 | ADD FOREIGN KEY (`parent_id`)  | 
            ||
| 79 | REFERENCES `tree_traversal_with_scope` (`tree_traversal_id`)  | 
            ||
| 80 | ON DELETE CASCADE ON UPDATE CASCADE';  | 
            ||
| 81 |         } elseif ('pgsql' == TEST_STEFANO_DB_VENDOR) { | 
            ||
| 82 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal';  | 
            ||
| 83 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_with_scope';  | 
            ||
| 84 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_metadata';  | 
            ||
| 85 | |||
| 86 | $queries[] = 'CREATE TABLE tree_traversal (  | 
            ||
| 87 | tree_traversal_id serial NOT NULL,  | 
            ||
| 88 | name character varying(255),  | 
            ||
| 89 | lft integer NOT NULL,  | 
            ||
| 90 | rgt integer NOT NULL,  | 
            ||
| 91 | parent_id integer,  | 
            ||
| 92 | level integer,  | 
            ||
| 93 | CONSTRAINT tree_traversal_pkey PRIMARY KEY (tree_traversal_id),  | 
            ||
| 94 | CONSTRAINT tree_traversal_parent_id_fkey FOREIGN KEY (parent_id)  | 
            ||
| 95 | REFERENCES public.tree_traversal (tree_traversal_id) MATCH SIMPLE  | 
            ||
| 96 | ON UPDATE CASCADE ON DELETE CASCADE  | 
            ||
| 97 | )';  | 
            ||
| 98 | |||
| 99 | $queries[] = 'CREATE INDEX tree_traversal_level  | 
            ||
| 100 | ON public.tree_traversal  | 
            ||
| 101 | USING btree (level)';  | 
            ||
| 102 | |||
| 103 | $queries[] = 'CREATE INDEX tree_traversal_lft  | 
            ||
| 104 | ON public.tree_traversal  | 
            ||
| 105 | USING btree (lft)';  | 
            ||
| 106 | |||
| 107 | $queries[] = 'CREATE INDEX tree_traversal_parent_id  | 
            ||
| 108 | ON public.tree_traversal  | 
            ||
| 109 | USING btree (parent_id)';  | 
            ||
| 110 | |||
| 111 | $queries[] = 'CREATE INDEX tree_traversal_rgt  | 
            ||
| 112 | ON public.tree_traversal  | 
            ||
| 113 | USING btree (rgt)';  | 
            ||
| 114 | |||
| 115 | $queries[] = 'CREATE TABLE tree_traversal_with_scope (  | 
            ||
| 116 | tree_traversal_id serial NOT NULL,  | 
            ||
| 117 | name character varying(255),  | 
            ||
| 118 | lft integer NOT NULL,  | 
            ||
| 119 | rgt integer NOT NULL,  | 
            ||
| 120 | parent_id integer,  | 
            ||
| 121 | level integer,  | 
            ||
| 122 | scope integer NOT NULL,  | 
            ||
| 123 | CONSTRAINT tree_traversal_with_scope_pkey PRIMARY KEY (tree_traversal_id),  | 
            ||
| 124 | CONSTRAINT tree_traversal_with_scope_parent_id_fkey FOREIGN KEY (parent_id)  | 
            ||
| 125 | REFERENCES public.tree_traversal_with_scope (tree_traversal_id) MATCH SIMPLE  | 
            ||
| 126 | ON UPDATE CASCADE ON DELETE CASCADE  | 
            ||
| 127 | )';  | 
            ||
| 128 | |||
| 129 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_level  | 
            ||
| 130 | ON public.tree_traversal_with_scope  | 
            ||
| 131 | USING btree (level)';  | 
            ||
| 132 | |||
| 133 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_lft  | 
            ||
| 134 | ON public.tree_traversal_with_scope  | 
            ||
| 135 | USING btree (lft)';  | 
            ||
| 136 | |||
| 137 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_parent_id  | 
            ||
| 138 | ON public.tree_traversal_with_scope  | 
            ||
| 139 | USING btree (parent_id)';  | 
            ||
| 140 | |||
| 141 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_rgt  | 
            ||
| 142 | ON public.tree_traversal_with_scope  | 
            ||
| 143 | USING btree (rgt)';  | 
            ||
| 144 | |||
| 145 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_scope  | 
            ||
| 146 | ON public.tree_traversal_with_scope  | 
            ||
| 147 | USING btree (scope)';  | 
            ||
| 148 | |||
| 149 | $queries[] = 'CREATE TABLE tree_traversal_metadata (  | 
            ||
| 150 | tree_traversal_metadata_id serial NOT NULL,  | 
            ||
| 151 | tree_traversal_id integer NOT NULL,  | 
            ||
| 152 | lft integer,  | 
            ||
| 153 | name character varying(255),  | 
            ||
| 154 | CONSTRAINT tree_traversal_metadata_pkey PRIMARY KEY (tree_traversal_metadata_id)  | 
            ||
| 155 | )';  | 
            ||
| 156 | |||
| 157 | $queries[] = 'CREATE INDEX tree_traversal_metadata_tree_traversal_id  | 
            ||
| 158 | ON public.tree_traversal_metadata  | 
            ||
| 159 | USING btree (tree_traversal_id)';  | 
            ||
| 160 |         } else { | 
            ||
| 161 |             throw new \Exception(sprintf('Unsupported vendor %s', TEST_STEFANO_DB_VENDOR)); | 
            ||
| 162 | }  | 
            ||
| 163 | |||
| 164 |         foreach ($queries as $query) { | 
            ||
| 165 | $connection->query($query);  | 
            ||
| 166 | }  | 
            ||
| 293 |