Conditions | 4 |
Paths | 5 |
Total Lines | 123 |
Code Lines | 28 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
17 | public static function createDbScheme() |
||
18 | { |
||
19 | $connection = self::getPDOConnection(); |
||
20 | |||
21 | $queries = array(); |
||
22 | |||
23 | if ('mysql' == TEST_STEFANO_DB_ADAPTER) { |
||
24 | $queries[] = 'DROP TABLE IF EXISTS `tree_traversal`'; |
||
25 | $queries[] = 'DROP TABLE IF EXISTS `tree_traversal_with_scope`'; |
||
26 | |||
27 | $queries[] = 'CREATE TABLE `tree_traversal` ( |
||
28 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT, |
||
29 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL, |
||
30 | `lft` int(11) NOT NULL, |
||
31 | `rgt` int(11) NOT NULL, |
||
32 | `parent_id` int(11) DEFAULT NULL, |
||
33 | `level` int(11) DEFAULT NULL, |
||
34 | PRIMARY KEY (`tree_traversal_id`), |
||
35 | KEY `parent_id` (`parent_id`), |
||
36 | KEY `level` (`level`), |
||
37 | KEY `lft` (`lft`), |
||
38 | KEY `rgt` (`rgt`) |
||
39 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin'; |
||
40 | |||
41 | $queries[] = 'ALTER TABLE `tree_traversal` |
||
42 | ADD FOREIGN KEY (`parent_id`) |
||
43 | REFERENCES `tree_traversal` (`tree_traversal_id`) |
||
44 | ON DELETE CASCADE ON UPDATE CASCADE'; |
||
45 | |||
46 | $queries[] = 'CREATE TABLE `tree_traversal_with_scope` ( |
||
47 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT, |
||
48 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL, |
||
49 | `lft` int(11) NOT NULL, |
||
50 | `rgt` int(11) NOT NULL, |
||
51 | `parent_id` int(11) DEFAULT NULL, |
||
52 | `level` int(11) DEFAULT NULL, |
||
53 | `scope` int(11) NOT NULL, |
||
54 | PRIMARY KEY (`tree_traversal_id`), |
||
55 | KEY `parent_id` (`parent_id`), |
||
56 | KEY `level` (`level`), |
||
57 | KEY `lft` (`lft`), |
||
58 | KEY `rgt` (`rgt`), |
||
59 | KEY `scope` (`scope`) |
||
60 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin'; |
||
61 | |||
62 | $queries[] = 'ALTER TABLE `tree_traversal_with_scope` |
||
63 | ADD FOREIGN KEY (`parent_id`) |
||
64 | REFERENCES `tree_traversal_with_scope` (`tree_traversal_id`) |
||
65 | ON DELETE CASCADE ON UPDATE CASCADE'; |
||
66 | } elseif ('pgsql' == TEST_STEFANO_DB_ADAPTER) { |
||
67 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal'; |
||
68 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_with_scope'; |
||
69 | |||
70 | $queries[] = 'CREATE TABLE tree_traversal ( |
||
71 | tree_traversal_id serial NOT NULL, |
||
72 | name character varying(255), |
||
73 | lft integer NOT NULL, |
||
74 | rgt integer NOT NULL, |
||
75 | parent_id integer, |
||
76 | level integer, |
||
77 | CONSTRAINT tree_traversal_pkey PRIMARY KEY (tree_traversal_id), |
||
78 | CONSTRAINT tree_traversal_parent_id_fkey FOREIGN KEY (parent_id) |
||
79 | REFERENCES public.tree_traversal (tree_traversal_id) MATCH SIMPLE |
||
80 | ON UPDATE CASCADE ON DELETE CASCADE |
||
81 | )'; |
||
82 | |||
83 | $queries[] = 'CREATE INDEX tree_traversal_level |
||
84 | ON public.tree_traversal |
||
85 | USING btree (level)'; |
||
86 | |||
87 | $queries[] = 'CREATE INDEX tree_traversal_lft |
||
88 | ON public.tree_traversal |
||
89 | USING btree (lft)'; |
||
90 | |||
91 | $queries[] = 'CREATE INDEX tree_traversal_parent_id |
||
92 | ON public.tree_traversal |
||
93 | USING btree (parent_id)'; |
||
94 | |||
95 | $queries[] = 'CREATE INDEX tree_traversal_rgt |
||
96 | ON public.tree_traversal |
||
97 | USING btree (rgt)'; |
||
98 | |||
99 | $queries[] = 'CREATE TABLE tree_traversal_with_scope ( |
||
100 | tree_traversal_id serial NOT NULL, |
||
101 | name character varying(255), |
||
102 | lft integer NOT NULL, |
||
103 | rgt integer NOT NULL, |
||
104 | parent_id integer, |
||
105 | level integer, |
||
106 | scope integer NOT NULL, |
||
107 | CONSTRAINT tree_traversal_with_scope_pkey PRIMARY KEY (tree_traversal_id), |
||
108 | CONSTRAINT tree_traversal_with_scope_parent_id_fkey FOREIGN KEY (parent_id) |
||
109 | REFERENCES public.tree_traversal_with_scope (tree_traversal_id) MATCH SIMPLE |
||
110 | ON UPDATE CASCADE ON DELETE CASCADE |
||
111 | )'; |
||
112 | |||
113 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_level |
||
114 | ON public.tree_traversal_with_scope |
||
115 | USING btree (level)'; |
||
116 | |||
117 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_lft |
||
118 | ON public.tree_traversal_with_scope |
||
119 | USING btree (lft)'; |
||
120 | |||
121 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_parent_id |
||
122 | ON public.tree_traversal_with_scope |
||
123 | USING btree (parent_id)'; |
||
124 | |||
125 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_rgt |
||
126 | ON public.tree_traversal_with_scope |
||
127 | USING btree (rgt)'; |
||
128 | |||
129 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_scope |
||
130 | ON public.tree_traversal_with_scope |
||
131 | USING btree (scope)'; |
||
132 | } else { |
||
133 | throw new \Exception(sprintf('Unsupported vendor %s', TEST_STEFANO_DB_ADAPTER)); |
||
134 | } |
||
135 | |||
136 | foreach ($queries as $query) { |
||
137 | $connection->query($query); |
||
138 | } |
||
139 | } |
||
140 | |||
236 |