StefanoDb::beginTransaction() - Code Metrics - Inspection of "added - adapter tests" - bartko-s/stefano-tree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 66df04...390d88 )

by Bartko

created 2016-11-10 15:49 UTC

StefanoDb::beginTransaction() A

↳ Parent: StefanoDb

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0
crap	1

<?php
namespace StefanoTree\NestedSet\Adapter;

class StefanoDb
    extends Zend2

{
    public function beginTransaction()
    {
        $this->getDbAdapter()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
             ->begin();
    }

    public function commitTransaction()
    {
        $this->getDbAdapter()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
             ->commit();
    }

    public function rollbackTransaction()
    {
        $this->getDbAdapter()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
             ->rollback();
    }
}


Push — develop ( 66df04...390d88 )

StefanoDb::beginTransaction() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		namespace StefanoTree\NestedSet\Adapter;
3
4		class StefanoDb
5		extends Zend2
		0 ignored issues – show Coding Style introduced 2016-11-10 15:53 UTC by Report Bug Copy Issue Report The extends keyword must be on the same line as the class name Loading history...
6		{
7	3	public function beginTransaction()
8		{
9	3	$this->getDbAdapter()
		0 ignored issues – show Bug introduced 2016-11-10 15:53 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Zend\Db\Adapter\Adapter` as the method `begin()` does only exist in the following sub-classes of `Zend\Db\Adapter\Adapter`: `StefanoDb\Adapter\Adapter`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
10	3	->begin();
11	3	}
12
13	2	public function commitTransaction()
14		{
15	2	$this->getDbAdapter()
		0 ignored issues – show Bug introduced 2016-11-10 15:53 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Zend\Db\Adapter\Adapter` as the method `commit()` does only exist in the following sub-classes of `Zend\Db\Adapter\Adapter`: `StefanoDb\Adapter\Adapter`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
16	2	->commit();
17	2	}
18
19	2	public function rollbackTransaction()
20		{
21	2	$this->getDbAdapter()
		0 ignored issues – show Bug introduced 2016-11-10 15:53 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Zend\Db\Adapter\Adapter` as the method `rollback()` does only exist in the following sub-classes of `Zend\Db\Adapter\Adapter`: `StefanoDb\Adapter\Adapter`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
22	2	->rollback();
23	2	}
24		}
25

bartko-s / stefano-tree

Push — develop ( 66df04...390d88 )

StefanoDb::beginTransaction() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like