| Conditions | 5 |
| Paths | 6 |
| Total Lines | 148 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 24 | public static function createDbScheme() |
||
| 25 | { |
||
| 26 | $connection = self::getPDOConnection(); |
||
| 27 | |||
| 28 | $queries = array(); |
||
| 29 | |||
| 30 | if ('mysql' == TEST_STEFANO_DB_VENDOR) { |
||
| 31 | if (self::$mysqlDbSchemeCreated) { |
||
| 32 | return; |
||
| 33 | } else { |
||
| 34 | self::$mysqlDbSchemeCreated = true; |
||
| 35 | } |
||
| 36 | $queries[] = 'CREATE TABLE `tree_traversal` ( |
||
| 37 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 38 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL, |
||
| 39 | `lft` int(11) NOT NULL, |
||
| 40 | `rgt` int(11) NOT NULL, |
||
| 41 | `parent_id` int(11) DEFAULT NULL, |
||
| 42 | `level` int(11) DEFAULT NULL, |
||
| 43 | PRIMARY KEY (`tree_traversal_id`), |
||
| 44 | KEY `parent_id` (`parent_id`), |
||
| 45 | KEY `level` (`level`), |
||
| 46 | KEY `lft` (`lft`), |
||
| 47 | KEY `rgt` (`rgt`) |
||
| 48 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin'; |
||
| 49 | |||
| 50 | $queries[] = 'ALTER TABLE `tree_traversal` |
||
| 51 | ADD FOREIGN KEY (`parent_id`) |
||
| 52 | REFERENCES `tree_traversal` (`tree_traversal_id`) |
||
| 53 | ON DELETE CASCADE ON UPDATE CASCADE'; |
||
| 54 | |||
| 55 | $queries[] = 'CREATE TABLE `tree_traversal_with_scope` ( |
||
| 56 | `tree_traversal_id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 57 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL, |
||
| 58 | `lft` int(11) NOT NULL, |
||
| 59 | `rgt` int(11) NOT NULL, |
||
| 60 | `parent_id` int(11) DEFAULT NULL, |
||
| 61 | `level` int(11) DEFAULT NULL, |
||
| 62 | `scope` int(11) NOT NULL, |
||
| 63 | PRIMARY KEY (`tree_traversal_id`), |
||
| 64 | KEY `parent_id` (`parent_id`), |
||
| 65 | KEY `level` (`level`), |
||
| 66 | KEY `lft` (`lft`), |
||
| 67 | KEY `rgt` (`rgt`), |
||
| 68 | KEY `scope` (`scope`) |
||
| 69 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin'; |
||
| 70 | |||
| 71 | $queries[] = 'CREATE TABLE `tree_traversal_metadata` ( |
||
| 72 | `tree_traversal_metadata_id` int(11) NOT NULL AUTO_INCREMENT, |
||
| 73 | `tree_traversal_id` int(11) NOT NULL, |
||
| 74 | `lft` int(11) DEFAULT NULL, |
||
| 75 | `name` varchar(255) COLLATE utf8_bin DEFAULT NULL, |
||
| 76 | PRIMARY KEY (`tree_traversal_metadata_id`), |
||
| 77 | KEY `tree_traversal_id` (`tree_traversal_id`) |
||
| 78 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin'; |
||
| 79 | |||
| 80 | $queries[] = 'ALTER TABLE `tree_traversal_with_scope` |
||
| 81 | ADD FOREIGN KEY (`parent_id`) |
||
| 82 | REFERENCES `tree_traversal_with_scope` (`tree_traversal_id`) |
||
| 83 | ON DELETE CASCADE ON UPDATE CASCADE'; |
||
| 84 | } elseif ('pgsql' == TEST_STEFANO_DB_VENDOR) { |
||
| 85 | // Run this workaround before each test. DbUnit has issue with postgres https://github.com/sebastianbergmann/dbunit/issues/58 |
||
| 86 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal'; |
||
| 87 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_with_scope'; |
||
| 88 | $queries[] = 'DROP TABLE IF EXISTS tree_traversal_metadata'; |
||
| 89 | |||
| 90 | $queries[] = 'CREATE TABLE tree_traversal ( |
||
| 91 | tree_traversal_id serial NOT NULL, |
||
| 92 | name character varying(255), |
||
| 93 | lft integer NOT NULL, |
||
| 94 | rgt integer NOT NULL, |
||
| 95 | parent_id integer, |
||
| 96 | level integer, |
||
| 97 | CONSTRAINT tree_traversal_pkey PRIMARY KEY (tree_traversal_id), |
||
| 98 | CONSTRAINT tree_traversal_parent_id_fkey FOREIGN KEY (parent_id) |
||
| 99 | REFERENCES public.tree_traversal (tree_traversal_id) MATCH SIMPLE |
||
| 100 | ON UPDATE CASCADE ON DELETE CASCADE |
||
| 101 | )'; |
||
| 102 | |||
| 103 | $queries[] = 'CREATE INDEX tree_traversal_level |
||
| 104 | ON public.tree_traversal |
||
| 105 | USING btree (level)'; |
||
| 106 | |||
| 107 | $queries[] = 'CREATE INDEX tree_traversal_lft |
||
| 108 | ON public.tree_traversal |
||
| 109 | USING btree (lft)'; |
||
| 110 | |||
| 111 | $queries[] = 'CREATE INDEX tree_traversal_parent_id |
||
| 112 | ON public.tree_traversal |
||
| 113 | USING btree (parent_id)'; |
||
| 114 | |||
| 115 | $queries[] = 'CREATE INDEX tree_traversal_rgt |
||
| 116 | ON public.tree_traversal |
||
| 117 | USING btree (rgt)'; |
||
| 118 | |||
| 119 | $queries[] = 'CREATE TABLE tree_traversal_with_scope ( |
||
| 120 | tree_traversal_id serial NOT NULL, |
||
| 121 | name character varying(255), |
||
| 122 | lft integer NOT NULL, |
||
| 123 | rgt integer NOT NULL, |
||
| 124 | parent_id integer, |
||
| 125 | level integer, |
||
| 126 | scope integer NOT NULL, |
||
| 127 | CONSTRAINT tree_traversal_with_scope_pkey PRIMARY KEY (tree_traversal_id), |
||
| 128 | CONSTRAINT tree_traversal_with_scope_parent_id_fkey FOREIGN KEY (parent_id) |
||
| 129 | REFERENCES public.tree_traversal_with_scope (tree_traversal_id) MATCH SIMPLE |
||
| 130 | ON UPDATE CASCADE ON DELETE CASCADE |
||
| 131 | )'; |
||
| 132 | |||
| 133 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_level |
||
| 134 | ON public.tree_traversal_with_scope |
||
| 135 | USING btree (level)'; |
||
| 136 | |||
| 137 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_lft |
||
| 138 | ON public.tree_traversal_with_scope |
||
| 139 | USING btree (lft)'; |
||
| 140 | |||
| 141 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_parent_id |
||
| 142 | ON public.tree_traversal_with_scope |
||
| 143 | USING btree (parent_id)'; |
||
| 144 | |||
| 145 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_rgt |
||
| 146 | ON public.tree_traversal_with_scope |
||
| 147 | USING btree (rgt)'; |
||
| 148 | |||
| 149 | $queries[] = 'CREATE INDEX tree_traversal_with_scope_scope |
||
| 150 | ON public.tree_traversal_with_scope |
||
| 151 | USING btree (scope)'; |
||
| 152 | |||
| 153 | $queries[] = 'CREATE TABLE tree_traversal_metadata ( |
||
| 154 | tree_traversal_metadata_id serial NOT NULL, |
||
| 155 | tree_traversal_id integer NOT NULL, |
||
| 156 | lft integer, |
||
| 157 | name character varying(255), |
||
| 158 | CONSTRAINT tree_traversal_metadata_pkey PRIMARY KEY (tree_traversal_metadata_id) |
||
| 159 | )'; |
||
| 160 | |||
| 161 | $queries[] = 'CREATE INDEX tree_traversal_metadata_tree_traversal_id |
||
| 162 | ON public.tree_traversal_metadata |
||
| 163 | USING btree (tree_traversal_id)'; |
||
| 164 | } else { |
||
| 165 | throw new \Exception(sprintf('Unsupported vendor %s', TEST_STEFANO_DB_VENDOR)); |
||
| 166 | } |
||
| 167 | |||
| 168 | foreach ($queries as $query) { |
||
| 169 | $connection->query($query); |
||
| 170 | } |
||
| 171 | } |
||
| 172 | |||
| 287 |