BantenprovZonaSeeder::insertData() - Code Metrics - Inspection of "Merge pull request #4 from arifin09/master" - bantenprov/zona - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bc33b...f90d05 )

unknown

created 2018-04-10 16:11 UTC

BantenprovZonaSeeder::insertData() A

↳ Parent: BantenprovZonaSeeder

Complexity

Conditions	3
Paths	4

Size

Total Lines	52
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	35
nc	4
nop	0
dl	0
loc	52
rs	9.4929
c	0
b	0
f	0

How to fix Long Method

<?php
use Illuminate\Database\Seeder;
/**
 * Usage :
 * [1] $ composer dump-autoload -o
 * [2] $ php artisan db:seed --class=BantenprovZonaSeeder
 */
class BantenprovZonaSeeder extends Seeder
namespace YourVendor;

class YourClass { }
{
    /* text color */
    protected $RED     ="\033[0;31m";
    protected $CYAN    ="\033[0;36m";
    protected $YELLOW  ="\033[1;33m";
    protected $ORANGE  ="\033[0;33m";
    protected $PUR     ="\033[0;35m";
    protected $GRN     ="\e[32m";
    protected $WHI     ="\e[37m";
    protected $NC      ="\033[0m";
    /* File name */
    /* location : /databse/seeds/file_name.csv */
    protected $fileName = "BantenprovZonaSeeder.csv";
    /* text info : default (true) */

    protected $textInfo = true;
    /* model class */
    protected $model;
    /* __construct */
    public function __construct(){
        $this->model = new Bantenprov\Zona\Models\Bantenprov\Zona\Zona;
    }
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        $this->insertData();
    }
    /* function insert data */
    protected function insertData()
    {
        /* silahkan di rubah sesuai kebutuhan */
        foreach($this->readCSV() as $data){

            
        	$this->model->create([
            	'user_id' => $data['user_id'],
				'master_zona_id' => $data['master_zona_id'],
				'nomor_un' => $data['nomor_un'],
				'sekolah_id' => $data['sekolah_id'],
                'zona_siswa' => $data['zona_siswa'],
                'zona_sekolah' => $data['zona_sekolah'],
                'lokasi_siswa' => $data['lokasi_siswa'],
                'lokasi_sekolah' => $data['lokasi_sekolah'],
                'nilai_zona' => $data['nilai_zona'],

        	]);
        

        }

        if($this->textInfo){                
            echo "============[DATA]============\n";
            $this->orangeText('user_id : ').$this->greenText($data['user_id']);
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
			echo"\n";
			$this->orangeText('master_zona_id : ').$this->greenText($data['master_zona_id']);
			echo"\n";
			$this->orangeText('nomor_un : ').$this->greenText($data['nomor_un']);
			echo"\n";
			$this->orangeText('sekolah_id : ').$this->greenText($data['sekolah_id']);
			echo"\n";
            $this->orangeText('zona_siswa : ').$this->greenText($data['zona_siswa']);
            echo"\n";
            $this->orangeText('zona_sekolah : ').$this->greenText($data['zona_sekolah']);
            echo"\n";
            $this->orangeText('lokasi_siswa : ').$this->greenText($data['lokasi_siswa']);
            echo"\n";
            $this->orangeText('lokasi_sekolah : ').$this->greenText($data['lokasi_sekolah']);
            echo"\n";
            $this->orangeText('nilai_zona : ').$this->greenText($data['nilai_zona']);
            echo"\n";

            
            
        
            echo "============[DATA]============\n\n";
        }

        $this->greenText('[ SEEDER DONE ]');
        echo"\n\n";
    }
    /* text color: orange */
    protected function orangeText($text)
    {
        printf($this->ORANGE.$text.$this->NC);
    }
    /* text color: green */
    protected function greenText($text)
    {
        printf($this->GRN.$text.$this->NC);
    }
    /* function read CSV file */
    protected function readCSV()
    {
        $file = fopen(database_path("seeds/".$this->fileName), "r");
        $all_data = array();
        $row = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        while(($data = fgetcsv($file, 1000, ",")) !== FALSE){
            $all_data[] = ['user_id' => $data[0],
                           'master_zona_id' => $data[1],
                           'nomor_un' => $data[2],
                           'sekolah_id' => $data[3],
                           'zona_siswa' => $data[4],
                           'zona_sekolah' => $data[5],
                           'lokasi_siswa' => $data[6],
                           'lokasi_sekolah' => $data[7],
                           'nilai_zona' => $data[8],
                          ];
        }
        fclose($file);
        return  $all_data;
    }
}


1			<?php
2			use Illuminate\Database\Seeder;
3			/**
4			* Usage :
5			* [1] $ composer dump-autoload -o
6			* [2] $ php artisan db:seed --class=BantenprovZonaSeeder
7			*/
8			class BantenprovZonaSeeder extends Seeder
			0 ignored issues – show Coding Style Compatibility introduced 2018-03-15 23:59 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			/* text color */
11			protected $RED ="\033[0;31m";
12			protected $CYAN ="\033[0;36m";
13			protected $YELLOW ="\033[1;33m";
14			protected $ORANGE ="\033[0;33m";
15			protected $PUR ="\033[0;35m";
16			protected $GRN ="\e[32m";
17			protected $WHI ="\e[37m";
18			protected $NC ="\033[0m";
19			/* File name */
20			/* location : /databse/seeds/file_name.csv */
21			protected $fileName = "BantenprovZonaSeeder.csv";
22			/* text info : default (true) */
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-04-10 11:33 UTC by Report Bug Copy Issue Report `42%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
23			protected $textInfo = true;
24			/* model class */
25			protected $model;
26			/* __construct */
27			public function __construct(){
28			$this->model = new Bantenprov\Zona\Models\Bantenprov\Zona\Zona;
29			}
30			/**
31			* Run the database seeds.
32			*
33			* @return void
34			*/
35			public function run()
36			{
37			$this->insertData();
38			}
39			/* function insert data */
40			protected function insertData()
41			{
42			/* silahkan di rubah sesuai kebutuhan */
43			foreach($this->readCSV() as $data){
44
45
46			$this->model->create([
47			'user_id' => $data['user_id'],
48			'master_zona_id' => $data['master_zona_id'],
49			'nomor_un' => $data['nomor_un'],
50			'sekolah_id' => $data['sekolah_id'],
51			'zona_siswa' => $data['zona_siswa'],
52			'zona_sekolah' => $data['zona_sekolah'],
53			'lokasi_siswa' => $data['lokasi_siswa'],
54			'lokasi_sekolah' => $data['lokasi_sekolah'],
55			'nilai_zona' => $data['nilai_zona'],
56
57			]);
58
59
60			}
61
62			if($this->textInfo){
63			echo "============[DATA]============\n";
64			$this->orangeText('user_id : ').$this->greenText($data['user_id']);
			0 ignored issues – show Bug introduced 2018-04-10 11:33 UTC by Report Bug Copy Issue Report The variable `$data` seems to be defined by a `foreach` iteration on line `43`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
65			echo"\n";
66			$this->orangeText('master_zona_id : ').$this->greenText($data['master_zona_id']);
67			echo"\n";
68			$this->orangeText('nomor_un : ').$this->greenText($data['nomor_un']);
69			echo"\n";
70			$this->orangeText('sekolah_id : ').$this->greenText($data['sekolah_id']);
71			echo"\n";
72			$this->orangeText('zona_siswa : ').$this->greenText($data['zona_siswa']);
73			echo"\n";
74			$this->orangeText('zona_sekolah : ').$this->greenText($data['zona_sekolah']);
75			echo"\n";
76			$this->orangeText('lokasi_siswa : ').$this->greenText($data['lokasi_siswa']);
77			echo"\n";
78			$this->orangeText('lokasi_sekolah : ').$this->greenText($data['lokasi_sekolah']);
79			echo"\n";
80			$this->orangeText('nilai_zona : ').$this->greenText($data['nilai_zona']);
81			echo"\n";
82
83
84
85
86			echo "============[DATA]============\n\n";
87			}
88
89			$this->greenText('[ SEEDER DONE ]');
90			echo"\n\n";
91			}
92			/* text color: orange */
93			protected function orangeText($text)
94			{
95			printf($this->ORANGE.$text.$this->NC);
96			}
97			/* text color: green */
98			protected function greenText($text)
99			{
100			printf($this->GRN.$text.$this->NC);
101			}
102			/* function read CSV file */
103			protected function readCSV()
104			{
105			$file = fopen(database_path("seeds/".$this->fileName), "r");
106			$all_data = array();
107			$row = 1;
			0 ignored issues – show Unused Code introduced 2018-04-10 11:33 UTC by Report Bug Copy Issue Report `$row` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
108			while(($data = fgetcsv($file, 1000, ",")) !== FALSE){
109			$all_data[] = ['user_id' => $data[0],
110			'master_zona_id' => $data[1],
111			'nomor_un' => $data[2],
112			'sekolah_id' => $data[3],
113			'zona_siswa' => $data[4],
114			'zona_sekolah' => $data[5],
115			'lokasi_siswa' => $data[6],
116			'lokasi_sekolah' => $data[7],
117			'nilai_zona' => $data[8],
118			];
119			}
120			fclose($file);
121			return $all_data;
122			}
123			}
124

bantenprov / zona

Push — master ( 7bc33b...f90d05 )

BantenprovZonaSeeder::insertData() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like