ZonaController::update() - Code Metrics - Inspection of "Merge pull request #12 from fadika06/master" - bantenprov/zona - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f960c...3e2a1d )

unknown

created 2018-04-18 18:35 UTC

ZonaController::update() B

↳ Parent: ZonaController

Complexity

Conditions	7
Paths	7

Size

Total Lines	64
Code Lines	46

Duplication

Lines	26
Ratio	40.63 %

Importance

Changes

Metric	Value
cc	7
eloc	46
nc	7
nop	2
dl	26
loc	64
rs	7.2058
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Bantenprov\Zona\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\BudgetAbsorption\Facades\ZonaFacade;

/* Models */
use Bantenprov\Zona\Models\Bantenprov\Zona\Zona;
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use Bantenprov\Zona\Models\Bantenprov\Zona\MasterZona;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
use App\User;

/* Etc */
use Validator;

/**
 * The ZonaController class.
 *
 * @package Bantenprov\Zona
 * @author  bantenprov <[email protected]>
 */
class ZonaController extends Controller
{  

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $siswa;
    protected $zona;
    protected $master_zona;
    protected $sekolah;
    protected $user;

    public function __construct(Zona $zona, Siswa $siswa, User $user, MasterZona $master_zona, Sekolah $sekolah)
    {
        $this->zona             = $zona;
        $this->siswa            = $siswa;
        $this->user             = $user;
        $this->master_zona      = $master_zona;
        $this->sekolah          = $sekolah;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->zona->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->zona->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('id', 'like', $value)
                    ->orWhere('label', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->with('siswa')->with('master_zona')->with('sekolah')->with('user')->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {   
        $response = [];
        $siswas = $this->siswa->all();
        $master_zonas = $this->master_zona->all();
        $sekolahs = $this->sekolah->all();
        $users_special = $this->user->all();
        $users_standar = $this->user->find(\Auth::User()->id);
        $current_user = \Auth::User();

        $role_check = \Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

            $response['user_special'] = true;
            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }
            $response['user'] = $users_special;
        }else{
            $response['user_special'] = false;
            array_set($users_standar, 'label', $users_standar->name);
            $response['user'] = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        foreach($sekolahs as $sekolah){
            array_set($sekolah, 'lokasi_sekolah', $sekolah->village_id);
            array_set($sekolah, 'zona_sekolah', substr($sekolah->village_id,0,4));
        }

        foreach($siswas as $siswa){
            array_set($siswa, 'label', $siswa->nama_siswa);
            array_set($siswa, 'lokasi_siswa', $siswa->village_id);
            array_set($siswa, 'zona_siswa', substr($siswa->village_id,0,4));
        }

        $response['siswa'] = $siswas;
        $response['current_user'] = $current_user;
        $response['master_zona'] = $master_zonas;
        $response['sekolah'] = $sekolahs;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Zona  $zona
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $zona = $this->zona;
        

        $validator = Validator::make($request->all(), [
            'user_id' => 'required|unique:zonas,user_id',
            'nomor_un' => 'required|unique:zonas,nomor_un',
            'sekolah_id' => 'required',
            'zona_siswa' => 'required',
            'zona_sekolah' => 'required',
            'lokasi_siswa' => 'required',
            'lokasi_sekolah' => 'required',
            'nilai_zona' => 'required',
        ]);

        if($validator->fails()){
            $check = $zona->where('user_id',$request->user_id)->orWhere('nomor_un',$request->nomor_un)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed ! Username, Nama Siswa already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {

                $zona->user_id = $request->input('user_id');
                $zona->nomor_un = $request->input('nomor_un');
                $zona->sekolah_id = $request->input('sekolah_id');
                $zona->zona_siswa = $request->input('zona_siswa');
                $zona->zona_sekolah = $request->input('zona_sekolah');
                $zona->lokasi_siswa = $request->input('lokasi_siswa');
                $zona->lokasi_sekolah = $request->input('lokasi_sekolah');
                $zona->nilai_zona = $request->input('nilai_zona');
                $zona->save();

                

                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        } else {

            $zona->user_id = $request->input('user_id');
                $zona->nomor_un = $request->input('nomor_un');
                $zona->sekolah_id = $request->input('sekolah_id');
                $zona->zona_siswa = $request->input('zona_siswa');
                $zona->zona_sekolah = $request->input('zona_sekolah');
                $zona->lokasi_siswa = $request->input('lokasi_siswa');
                $zona->lokasi_sekolah = $request->input('lokasi_sekolah');
                $zona->nilai_zona = $request->input('nilai_zona');
                $zona->save();

               
            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $zona = $this->zona->findOrFail($id);

        $response['zona'] = $zona;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['master_zona'] = $zona->master_zona;
        $response['sekolah'] = $zona->sekolah;
        $response['siswa'] = $zona->siswa;
        $response['user'] = $zona->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Zona  $zona
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $zona = $this->zona->findOrFail($id);

        array_set($zona->user, 'label', $zona->user->name);
        array_set($zona->siswa, 'label', $zona->siswa->nama_siswa);

        $response['zona'] = $zona;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['master_zona'] = $zona->master_zona;
        $response['sekolah'] = $zona->sekolah;
        $response['siswa'] = $zona->siswa;
        $response['user'] = $zona->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Zona  $zona
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $response = array();
        $message  = array();

        $zona = $this->zona->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'user_id' => 'required|unique:zonas,user_id,'.$id,
            'nomor_un' => 'required|unique:zonas,nomor_un,'.$id,
            'sekolah_id' => 'required',
            'zona_siswa' => 'required',
            'zona_sekolah' => 'required',
            'lokasi_siswa' => 'required',
            'lokasi_sekolah' => 'required',
            'nilai_zona' => 'required',
        ]);

        if ($validator->fails()) {

            foreach($validator->messages()->getMessages() as $key => $error){
                        foreach($error AS $error_get) {
                            array_push($message, $error_get);
                        }                
                    } 

             $check_user  = $this->zona->where('id','!=', $id)->where('user_id', $request->user_id);
             $check_siswa = $this->zona->where('id','!=', $id)->where('nomor_un', $request->nomor_un);
             $check_sekolah = $this->zona->where('id','!=', $id)->where('sekolah_id', $request->sekolah_id);

             if($check_user->count() > 0 || $check_siswa->count() > 0 || $check_sekolah->count() > 0){
                  $response['message'] = implode("\n",$message);
        } else {

            $zona->user_id = $request->input('user_id');
                $zona->nomor_un = $request->input('nomor_un');
                $zona->sekolah_id = $request->input('sekolah_id');
                $zona->zona_siswa = $request->input('zona_siswa');
                $zona->zona_sekolah = $request->input('zona_sekolah');
                $zona->lokasi_siswa = $request->input('lokasi_siswa');
                $zona->lokasi_sekolah = $request->input('lokasi_sekolah');
                $zona->nilai_zona = $request->input('nilai_zona');
                $zona->save();

            $response['message'] = 'success';
        }

        } else {

            $zona->user_id = $request->input('user_id');
                $zona->nomor_un = $request->input('nomor_un');
                $zona->sekolah_id = $request->input('sekolah_id');
                $zona->zona_siswa = $request->input('zona_siswa');
                $zona->zona_sekolah = $request->input('zona_sekolah');
                $zona->lokasi_siswa = $request->input('lokasi_siswa');
                $zona->lokasi_sekolah = $request->input('lokasi_sekolah');
                $zona->nilai_zona = $request->input('nilai_zona');
                $zona->save();

                $response['message'] = 'success';
            }

                $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Zona  $zona
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $zona = $this->zona->findOrFail($id);

        if ($zona->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\Zona\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\BudgetAbsorption\Facades\ZonaFacade;
9
10			/* Models */
11			use Bantenprov\Zona\Models\Bantenprov\Zona\Zona;
12			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
13			use Bantenprov\Zona\Models\Bantenprov\Zona\MasterZona;
14			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
15			use App\User;
16
17			/* Etc */
18			use Validator;
19
20			/**
21			* The ZonaController class.
22			*
23			* @package Bantenprov\Zona
24			* @author bantenprov <[email protected]>
25			*/
26			class ZonaController extends Controller
27			{
			0 ignored issues – show Coding Style introduced 2018-04-11 12:36 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
28			/**
29			* Create a new controller instance.
30			*
31			* @return void
32			*/
33			protected $siswa;
34			protected $zona;
35			protected $master_zona;
36			protected $sekolah;
37			protected $user;
38
39			public function __construct(Zona $zona, Siswa $siswa, User $user, MasterZona $master_zona, Sekolah $sekolah)

bantenprov / zona

Push — master ( 8f960c...3e2a1d )

ZonaController::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like