TransitionController::index() - Code Metrics - Inspection of "Merge pull request #1 from feripratama/master" - bantenprov/vue-workflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f606cd...f6df63 )

unknown

created 2018-04-01 17:10 UTC

TransitionController::index() B

↳ Parent: TransitionController

Complexity

Conditions	5
Paths	16

Size

Total Lines	50
Code Lines	16

Duplication

Lines	50
Ratio	100 %

Importance

Changes

Metric	Value
cc	5
eloc	16
nc	16
nop	1
dl	50
loc	50
rs	8.6315
c	0
b	0
f	0

<?php

namespace Bantenprov\VueWorkflow\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\VueWorkflow\Models\Transition;
use Bantenprov\VueWorkflow\Models\Workflow;
use Bantenprov\VueWorkflow\Models\State;
use Validator;

class TransitionController extends Controller
{

    protected $transitionModel;
    protected $workflowModel;
    protected $stateModel;

    /**
     * [Function] __construct
     * @param
     * 
     * @return 
     */
    public function __construct(Transition $transition, Workflow $workflow, State $state)
    {
        $this->transitionModel = $transition;
        $this->workflowModel = $workflow;
        $this->stateModel = $state;
    }

    /**
     * [Function] index
     * @param Request $req
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * 
     * @return json
     */
    public function index(Request $request)

    {
        // $response;

        //     $param = explode('|',$req->get('sort'));


        //     if($req->get('filter') != ''){

        //         $search = "%{$req->get('filter')}%";

        //         $response = $this->transitionModel->where('name','like',$search)->orderBy($param[0], $param[1])->paginate(10);

        //     }else{
        //         if($req->get('sort') == ''){

        //             $response = $this->transitionModel->paginate(10);

        //         }else{
        //             $response = $this->transitionModel->orderBy($param[0], $param[1])->paginate(10);     

        //         }                
        //     }

        //     foreach($response as $kegiatan){            

        //         array_set($response->data, 'workflow_id', $kegiatan->kegiatan->label);           

        //     }

            // ===================================================

        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->transitionModel->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->transitionModel->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('label', 'like', $value)
                    ->orWhere('description', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);
        
        foreach($response as $workflow){            
            array_set($response->data, 'workflow_id', $workflow->getWorkflow->label);           
        }

        

        return response()->json($response);
    }

    /**
     * [Function] create
     * @param 
     * 
     * @return json
     */
    public function create()
    {        
        $response = $this->workflowModel->all();          

        return response()->json($response);
    }

    /**
     * [Function] getWorkflowState
     * @param 
     * 
     * @return json
     */
    public function getWorkflowState($id)
    {
        if($id == 'undefined'){
            $response = [];  
        }else{
            $response = $this->stateModel->where('workflow_id',$id)->get();  
        }            

        return response()->json($response);
    }

    /**
     * [Function] store
     * @param Request $req
     * 
     * @return json
     */
    public function store(Request $req)
    {
        $request['label']           = $req->label;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $request['name']            = strtolower($req->name);
        $request['workflow_id']     = $req->workflow_id; 
        $request['from']            = $req->from; 
        $request['to']              = $req->to;
        $request['message']         = $req->message;

        // $check = $this->transitionModel->where('name',$req->name)->whereNull('deleted_at')->count();


        $validator = Validator::make($req->all(),[
            'name'          => 'required',
            'label'         => 'required',            
            'message'       => 'required',
            'from'          => 'required',
            'to'            => 'required',
            'workflow_id'   => 'required',
        ]);

        if($validator->fails()){

            //if($check > 0){

                $response['message']    = 'failed transition allready exist !';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['status']     = false;
            // }else{
            //     $response['message']    = 'success add new transition';

            //     $response['status']     = true;

            //     $this->transitionModel->create($request);

            // }                
        }else{
            $response['message']    = 'success add new transition';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['status']     = true;
            $this->transitionModel->create($request);
        }

        return response()->json($response);
    }

    /**
     * [Function] edit
     * @param $id
     * 
     * @return json
     */
    public function edit($id)
    {
        $response = $this->transitionModel
                        ->with('stateTo')
                        ->with('stateFrom')
                        ->with('getWorkflow')
                        ->findOrFail($id);
        $response['status'] = true;
        return response()->json($response);
    }
    
    /**
     * [Function] update
     * @param Request $req
     * @param $id
     * 
     * @return json
     */
    public function update(Request $req,$id)
    {
        $request['label']           = $req->label;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $request['name']            = strtolower($req->name);
        $request['workflow_id']     = $req->workflow_id; 
        $request['from']            = $req->from; 
        $request['to']              = $req->to;
        $request['message']         = $req->message;          
        
        $check = $this->transitionModel->where('name',$req->name)->whereNull('deleted_at')->count();

        if($req->old_name == $req->name){
            $validator = Validator::make($req->all(),[
                'label'         => 'required',
                'name'          => 'required',
                'message'       => 'required',
                'from'          => 'required',
                'to'            => 'required',
                'workflow_id'   => 'required',
            ]);
        }else{
            $validator = Validator::make($req->all(),[
                'label'         => 'required',
                'name'          => 'required|unique:workflow_transition,name',
                'message'       => 'required',
                'from'          => 'required',
                'to'            => 'required',
                'workflow_id'   => 'required',
            ]);
        }
        

        if($validator->fails()){

            if($check > 0){
                $response['message']    = 'failed state allready exist !';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['status']     = false;
            }else{
                $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['status']     = true;
                $this->transitionModel->findOrFail($id)->update($request);
            }                
        }else{
            $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['status']     = true;
            $this->transitionModel->findOrFail($id)->update($request);
        }

        

        return response()->json($response);
    }
    
    /**
     * [Function] destroy
     * @param Request $req
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * 
     * @return json
     */
    public function destroy($id)
    {
        $state = $this->transitionModel->findOrFail($id)->delete();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return response()->json(['status' => true]);
    }
}


1		<?php
2
3		namespace Bantenprov\VueWorkflow\Http\Controllers;
4
5		use App\Http\Controllers\Controller;
6		use Illuminate\Http\Request;
7		use Bantenprov\VueWorkflow\Models\Transition;
8		use Bantenprov\VueWorkflow\Models\Workflow;
9		use Bantenprov\VueWorkflow\Models\State;
10		use Validator;
11
12		class TransitionController extends Controller
13		{
14
15		protected $transitionModel;
16		protected $workflowModel;
17		protected $stateModel;
18
19		/**
20		* [Function] __construct
21		* @param
22		*
23		* @return
24		*/
25		public function __construct(Transition $transition, Workflow $workflow, State $state)
26		{
27		$this->transitionModel = $transition;
28		$this->workflowModel = $workflow;
29		$this->stateModel = $state;
30		}
31
32		/**
33		* [Function] index
34		* @param Request $req
		0 ignored issues – show Bug introduced 2018-04-01 17:12 UTC by Report Bug Copy Issue Report There is no parameter named `$req`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
35		*
36		* @return json
37		*/
38	View Code Duplication	public function index(Request $request)
		0 ignored issues – show Duplication introduced 2018-04-01 17:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...

bantenprov / vue-workflow

Push — master ( f606cd...f6df63 )

TransitionController::index() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like