StateController::update() - Code Metrics - Inspection of "Merge pull request #1 from feripratama/master" - bantenprov/vue-workflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f606cd...f6df63 )

unknown

created 2018-04-01 17:10 UTC

StateController::update() B

↳ Parent: StateController

Complexity

Conditions	4
Paths	6

Size

Total Lines	43
Code Lines	29

Duplication

Lines	14
Ratio	32.56 %

Importance

Changes

Metric	Value
cc	4
eloc	29
nc	6
nop	2
dl	14
loc	43
rs	8.5806
c	0
b	0
f	0

<?php

    namespace Bantenprov\VueWorkflow\Http\Controllers;

    use App\Http\Controllers\Controller;
    use Illuminate\Http\Request;
    use Bantenprov\VueWorkflow\Facades\VueWorkflow;
    use Bantenprov\VueWorkflow\Models\State;
    use Bantenprov\VueWorkflow\Models\Workflow;

    use Validator;

    /**
     * [Class] StateController
     */
    class StateController{

        protected $stateModel;
        protected $workflowModel;

        /**
         * [Function] __construct
         */
        public function __construct(State $state, Workflow $workflow)
        {
            $this->stateModel = $state;
            $this->workflowModel = $workflow;
        }


        /**
         * [Function] index
         * @param Request $req
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
         * 
         * @return json
         */
        public function index(Request $request)

        {
            //dd(response()->json(['message' => 'success', 'status' => true]));

            // $response;

            // $param = explode('|',$req->get('sort'));


            // if($req->get('filter') != ''){

            //     $search = "%{$req->get('filter')}%";

            //     $response = $this->stateModel->where('name','like',$search)->orderBy($param[0], $param[1])->paginate(10);

            // }else{
            //     if($req->get('sort') == ''){

            //         $response = $this->stateModel->paginate(10);

            //     }else{
            //         $response = $this->stateModel->orderBy($param[0], $param[1])->paginate(10);     

            //     }                
            // }

            if (request()->has('sort')) {
                list($sortCol, $sortDir) = explode('|', request()->sort);
    
                $query = $this->stateModel->orderBy($sortCol, $sortDir);
            } else {
                $query = $this->stateModel->orderBy('id', 'asc');
            }
    
            if ($request->exists('filter')) {
                $query->where(function($q) use($request) {
                    $value = "%{$request->filter}%";
                    $q->where('label', 'like', $value)
                        ->orWhere('description', 'like', $value);
                });
            }
    
            $perPage = request()->has('per_page') ? (int) request()->per_page : null;
            $response = $query->paginate($perPage);
            
            foreach($response as $workflow){            
                array_set($response->data, 'workflow_id', $workflow->workflow->label);           
            }

            

            return response()->json($response);
            
        }

        /**
         * [Function] create
         * @param 
         * 
         * @return json
         */
        public function create(){

            $workflows = $this->stateModel->all();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            //dd($workflows);
            // $response = [];

            // foreach($workflows as $workflow){

            //     $response[] = [

            //         'id' => $workflow->workflow->id,

            //         'label' => $workflow->workflow->label

            //     ];
                
            // }
            $workflows =  $this->workflowModel->all();

            $response = $workflows;
            return response()->json($response);

        }

        /**
         * [Function] store
         * @param Request $req
         * 
         * @return json
         */
        public function store(Request $req)
        {
            $request['label']           = $req->label;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $request['name']            = $req->name;
            $request['description']     = $req->description;
            $request['workflow_id']     = $req->workflow_id;
            $request['status']          = 1;            

            $check = $this->stateModel->where('name',$req->name)->whereNull('deleted_at')->count();

            $validator = Validator::make($req->all(),[
                'label'         => 'required',
                'name'          => 'required',
                'description'   => 'required',
                'workflow_id'   => 'required'
            ]);

            if($validator->fails()){

                if($check > 0){
                    $response['message']    = 'failed state allready exist !';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    $response['status']     = false;
                }else{
                    $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    $response['status']     = true;
                    $this->stateModel->create($request);
                }                
            }else{
                $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['status']     = true;
                $this->stateModel->create($request);
            }

            

            return response()->json($response);
        }
        
        /**
         * [Function] edit
         * @param $id
         * 
         * @return json
         */
        public function edit($id)
        {
            $response = $this->stateModel->findOrFail($id);
            $response['status'] = true;
            return response()->json($response);
        }
        
        /**
         * [Function] update
         * @param Request $req
         * @param $id
         * 
         * @return json
         */
        public function update(Request $req,$id)
        {
            $request['label']           = $req->label;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $request['name']            = $req->name;
            $request['description']     = $req->description;
            $request['status']          = 1;            
            
            $check = $this->stateModel->where('name',$req->name)->whereNull('deleted_at')->count();

            if($req->old_name == $req->name){
                $validator = Validator::make($req->all(),[
                    'label'         => 'required',
                    'name'          => 'required',
                    'description'   => 'required',
                ]);
            }else{
                $validator = Validator::make($req->all(),[
                    'label'         => 'required',
                    'name'          => 'required|unique:workflow_state,name',
                    'description'   => 'required',
                ]);
            }
            

            if($validator->fails()){

                if($check > 0){
                    $response['message']    = 'failed state allready exist !';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    $response['status']     = false;
                }else{
                    $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                    $response['status']     = true;
                    $this->stateModel->findOrFail($id)->update($request);
                }                
            }else{
                $response['message']    = 'success add new state';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['status']     = true;
                $this->stateModel->findOrFail($id)->update($request);
            }

            

            return response()->json($response);
        }
        
        /**
         * [Function] destroy
         * @param Request $req
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
         * 
         * @return json
         */
        public function destroy($id)
        {
            $state = $this->stateModel->findOrFail($id)->delete();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            return response()->json(['status' => true]);
        }

    }

1		<?php
2
3		namespace Bantenprov\VueWorkflow\Http\Controllers;
4
5		use App\Http\Controllers\Controller;
6		use Illuminate\Http\Request;
7		use Bantenprov\VueWorkflow\Facades\VueWorkflow;
8		use Bantenprov\VueWorkflow\Models\State;
9		use Bantenprov\VueWorkflow\Models\Workflow;
10
11		use Validator;
12
13		/**
14		* [Class] StateController
15		*/
16		class StateController{
17
18		protected $stateModel;
19		protected $workflowModel;
20
21		/**
22		* [Function] __construct
23		*/
24		public function __construct(State $state, Workflow $workflow)
25		{
26		$this->stateModel = $state;
27		$this->workflowModel = $workflow;
28		}
29
30
31		/**
32		* [Function] index
33		* @param Request $req
		0 ignored issues – show Bug introduced 2018-04-01 17:12 UTC by Report Bug Copy Issue Report There is no parameter named `$req`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
34		*
35		* @return json
36		*/
37	View Code Duplication	public function index(Request $request)
		0 ignored issues – show Duplication introduced 2018-04-01 17:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{

bantenprov / vue-workflow

Push — master ( f606cd...f6df63 )

StateController::update() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like