Bantenprov\VueWorkflow\Http\Controllers\WorkflowController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	198
Duplicated Lines	7.58 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
B	store()	7	25	2
A	__construct()	0	6	1
B	index()	0	36	3
A	create()	0	6	1
A	show()	0	18	2
B	update()	0	25	2
A	storeWorkflow()	0	10	1
A	destroy()	0	6	1
A	edit()	8	8	1

<?php namespace Bantenprov\VueWorkflow\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\VueWorkflow\Facades\VueWorkflow;
use Bantenprov\VueWorkflow\Models\Workflow;
use Bantenprov\VueWorkflow\Models\WorkflowType;
use Bantenprov\VueWorkflow\Models\Transition;

use Validator;

use Bantenprov\VueWorkflow\Http\Traits\WorkflowTrait;

/**
 * The VueWorkflowController class.
 *
 * @package Bantenprov\VueWorkflow
 * @author  bantenprov <developer.bantenprov@gmai.com>
 */
class WorkflowController extends Controller
{

    use WorkflowTrait;
    
    protected $workflowModel;
    protected $workflowTypeModel;

    /**
     * WorkflowController constructor.
     * @param Request $request
     * @param Workflow $workflow
     * @param WorkflowType $workflowType
     */
    public function __construct(Request $request, Workflow $workflow, WorkflowType $workflowType){
        $this->workflowModel        = $workflow;
        $this->workflowTypeModel    = $workflowType; 

        //dd($request->path());

78% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * @param Request $req
     * @return \Illuminate\Http\JsonResponse
     */
    public function index(Request $req)
    {     
             
        // $transition = Transition::where('name','propose-to-propose')->where('workflow_id','19')->first();

68% of this comment could be valid code. Did you maybe forget this after debugging?

        // dd($transition->id);

63% of this comment could be valid code. Did you maybe forget this after debugging?

        //dd($this->getRequest($req->input('sort')));  

80% of this comment could be valid code. Did you maybe forget this after debugging?

        
        //dd(class_basename($this->workflowTypeModel));

70% of this comment could be valid code. Did you maybe forget this after debugging?

        //dd(class_basename(get_class($this)));

73% of this comment could be valid code. Did you maybe forget this after debugging?

        //dd(get_declared_classes());

72% of this comment could be valid code. Did you maybe forget this after debugging?

        // foreach (get_declared_classes() as $value) {

58% of this comment could be valid code. Did you maybe forget this after debugging?

        //     //Illuminate\Database\Eloquent\Model
        //     if(get_parent_class($value) == "Illuminate\Database\Eloquent\Model"){

62% of this comment could be valid code. Did you maybe forget this after debugging?

        //         echo $value."<br>";

58% of this comment could be valid code. Did you maybe forget this after debugging?

        //     }
        //     //echo $value."<br>";
            
        // }
        // dd();
        $response = array();

$response is not used, you could remove the assignment.

        $param = explode('|',$req->get('sort'));

        if($req->get('filter') != ''){
            $search = "%{$req->get('filter')}%";
            $response = $this->workflowModel->where('name','like',$search)->orderBy($param[0], $param[1])->paginate(10);
        }else{
            if($req->get('sort') == ''){
                $response = $this->workflowModel->paginate(10);
            }else{
                $response = $this->workflowModel->orderBy($param[0], $param[1])->paginate(10);     
            }                
        }

        return response()->json($response);
    }

    /**
     * @return \Illuminate\Http\JsonResponse
     */
    public function create()
    {        
        $content_type = config('vue-workflow.content_type');
        
        return response()->json($content_type);
    }

    /**
     * @param Request $req
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Request $req)
    {

        // $request['content_id']      = 1;

60% of this comment could be valid code. Did you maybe forget this after debugging?

        // $request['content_type']    = $req->content_type;

59% of this comment could be valid code. Did you maybe forget this after debugging?

        $request['label']           = $req->label;

$request was never initialized. Although not strictly required by PHP, it is generally a good practice to add $request = array(); before regardless.

        $request['name']            = $req->name;

        $validator = Validator::make($req->all(),[
            'label'             => 'required',
            'name'              => 'required'
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            $response['message']    = 'failed transition allready exist !';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['status']     = false;               
        }else{
            $response['message']    = 'success add new transition';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['status']     = true;                
        }

        //$this->insertWithWorkflow($this->workflowModel, $request);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->workflowModel->create($request);
        return response()->json($response);
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function show($id)
    {
        $check = $this->workflowTypeModel->where('workflow_id',$id)->count();
        
        if($check > 0){
            $response = $this->workflowModel->findOrFail($id);
            $response['workflow_type'] = ['label' =>$this->workflowModel->findOrFail($id)->getWorkflowType->workflow_type];
            $response['content_type'] = ['label' => $this->workflowModel->findOrFail($id)->getWorkflowType->content_type];
            $response['status'] = true;
        }else{
            $response = $this->workflowModel->findOrFail($id);
            $response['workflow_type'] = '-';
            $response['content_type'] = '-';
            $response['status'] = true;
        }
        
        return response()->json($response);
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {        
                
        $response['status']     = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['workflow']   = $this->workflowModel->findOrFail($id);
        
        return response()->json($response);
    }

    /**
     * @param $id
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function update($id, Request $request)
    {      
        
        $validator = Validator::make($request->all(), [
            'label' => 'required',
            'name'  => 'required'
        ]);

        if($validator->fails()){

            $response['status']     = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message']    = 'failed update ';

        }else{

            $response['status']     = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message']    = 'update success';
            $this->workflowModel->findOrFail($id)->update($request->all());

        }
                
        
        
        return response()->json($response);
    }


    /**
     * @param Request $req
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function storeWorkflow(Request $req, $id)
    {
        $workflow['workflow_id']    = $id;

$workflow was never initialized. Although not strictly required by PHP, it is generally a good practice to add $workflow = array(); before regardless.

        $workflow['workflow_type']  = $req->workflow_type;
        $workflow['content_type']   = $req->content_type;

        $this->workflowTypeModel->create($workflow);

        return response()->json(['status' => true, 'message' => 'Success register workflow']);
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     * @throws \Exception
     */
    public function destroy($id)
    {
        $state = $this->workflowModel->findOrFail($id)->delete();

$state is not used, you could remove the assignment.

        return response()->json(['status' => true]);
    }
}