Bantenprov\VueWorkflow\Http\Controllers\TransitionController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	240
Duplicated Lines	32.5 %

Coupling/Cohesion

Components	3
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	index()	50	50	5
A	create()	0	6	1
A	getWorkflowState()	0	10	2
B	store()	14	37	2
A	edit()	0	10	1
B	update()	14	51	4
A	destroy()	0	6	1

<?php

namespace Bantenprov\VueWorkflow\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\VueWorkflow\Models\Transition;
use Bantenprov\VueWorkflow\Models\Workflow;
use Bantenprov\VueWorkflow\Models\State;
use Validator;

class TransitionController extends Controller
{

    protected $transitionModel;
    protected $workflowModel;
    protected $stateModel;

    /**
     * [Function] __construct
     * @param
     * 
     * @return 
     */
    public function __construct(Transition $transition, Workflow $workflow, State $state)
    {
        $this->transitionModel = $transition;
        $this->workflowModel = $workflow;
        $this->stateModel = $state;
    }

    /**
     * [Function] index
     * @param Request $req

There is no parameter named $req. Was it maybe removed?

     * 
     * @return json
     */
    public function index(Request $request)

This method seems to be duplicated in your project.

    {
        // $response;

        //     $param = explode('|',$req->get('sort'));

65% of this comment could be valid code. Did you maybe forget this after debugging?

        //     if($req->get('filter') != ''){

69% of this comment could be valid code. Did you maybe forget this after debugging?

        //         $search = "%{$req->get('filter')}%";

43% of this comment could be valid code. Did you maybe forget this after debugging?

        //         $response = $this->transitionModel->where('name','like',$search)->orderBy($param[0], $param[1])->paginate(10);

76% of this comment could be valid code. Did you maybe forget this after debugging?

        //     }else{
        //         if($req->get('sort') == ''){

67% of this comment could be valid code. Did you maybe forget this after debugging?

        //             $response = $this->transitionModel->paginate(10);

58% of this comment could be valid code. Did you maybe forget this after debugging?

        //         }else{
        //             $response = $this->transitionModel->orderBy($param[0], $param[1])->paginate(10);     

72% of this comment could be valid code. Did you maybe forget this after debugging?

        //         }                
        //     }

        //     foreach($response as $kegiatan){            

70% of this comment could be valid code. Did you maybe forget this after debugging?

        //         array_set($response->data, 'workflow_id', $kegiatan->kegiatan->label);           

62% of this comment could be valid code. Did you maybe forget this after debugging?

        //     }

            // ===================================================

        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->transitionModel->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->transitionModel->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('label', 'like', $value)
                    ->orWhere('description', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);
        
        foreach($response as $workflow){            
            array_set($response->data, 'workflow_id', $workflow->getWorkflow->label);           
        }

        

        return response()->json($response);
    }

    /**
     * [Function] create
     * @param 
     * 
     * @return json
     */
    public function create()
    {        
        $response = $this->workflowModel->all();          

        return response()->json($response);
    }

    /**
     * [Function] getWorkflowState
     * @param 
     * 
     * @return json
     */
    public function getWorkflowState($id)
    {
        if($id == 'undefined'){
            $response = [];  
        }else{
            $response = $this->stateModel->where('workflow_id',$id)->get();  
        }            

        return response()->json($response);
    }

    /**
     * [Function] store
     * @param Request $req
     * 
     * @return json
     */
    public function store(Request $req)
    {
        $request['label']           = $req->label;

$request was never initialized. Although not strictly required by PHP, it is generally a good practice to add $request = array(); before regardless.

        $request['name']            = strtolower($req->name);
        $request['workflow_id']     = $req->workflow_id; 
        $request['from']            = $req->from; 
        $request['to']              = $req->to;
        $request['message']         = $req->message;

        // $check = $this->transitionModel->where('name',$req->name)->whereNull('deleted_at')->count();

67% of this comment could be valid code. Did you maybe forget this after debugging?

        $validator = Validator::make($req->all(),[
            'name'          => 'required',
            'label'         => 'required',            
            'message'       => 'required',
            'from'          => 'required',
            'to'            => 'required',
            'workflow_id'   => 'required',
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            //if($check > 0){

67% of this comment could be valid code. Did you maybe forget this after debugging?

                $response['message']    = 'failed transition allready exist !';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

                $response['status']     = false;
            // }else{
            //     $response['message']    = 'success add new transition';

60% of this comment could be valid code. Did you maybe forget this after debugging?

            //     $response['status']     = true;

60% of this comment could be valid code. Did you maybe forget this after debugging?

            //     $this->transitionModel->create($request);

70% of this comment could be valid code. Did you maybe forget this after debugging?

            // }                
        }else{
            $response['message']    = 'success add new transition';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['status']     = true;
            $this->transitionModel->create($request);
        }

        return response()->json($response);
    }

    /**
     * [Function] edit
     * @param $id
     * 
     * @return json
     */
    public function edit($id)
    {
        $response = $this->transitionModel
                        ->with('stateTo')
                        ->with('stateFrom')
                        ->with('getWorkflow')
                        ->findOrFail($id);
        $response['status'] = true;
        return response()->json($response);
    }
    
    /**
     * [Function] update
     * @param Request $req
     * @param $id
     * 
     * @return json
     */
    public function update(Request $req,$id)
    {
        $request['label']           = $req->label;

$request was never initialized. Although not strictly required by PHP, it is generally a good practice to add $request = array(); before regardless.

        $request['name']            = strtolower($req->name);
        $request['workflow_id']     = $req->workflow_id; 
        $request['from']            = $req->from; 
        $request['to']              = $req->to;
        $request['message']         = $req->message;          
        
        $check = $this->transitionModel->where('name',$req->name)->whereNull('deleted_at')->count();

        if($req->old_name == $req->name){
            $validator = Validator::make($req->all(),[
                'label'         => 'required',
                'name'          => 'required',
                'message'       => 'required',
                'from'          => 'required',
                'to'            => 'required',
                'workflow_id'   => 'required',
            ]);
        }else{
            $validator = Validator::make($req->all(),[
                'label'         => 'required',
                'name'          => 'required|unique:workflow_transition,name',
                'message'       => 'required',
                'from'          => 'required',
                'to'            => 'required',
                'workflow_id'   => 'required',
            ]);
        }
        

        if($validator->fails()){

This code seems to be duplicated across your project.

            if($check > 0){
                $response['message']    = 'failed state allready exist !';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

                $response['status']     = false;
            }else{
                $response['message']    = 'success add new state';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

                $response['status']     = true;
                $this->transitionModel->findOrFail($id)->update($request);
            }                
        }else{
            $response['message']    = 'success add new state';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['status']     = true;
            $this->transitionModel->findOrFail($id)->update($request);
        }

        

        return response()->json($response);
    }
    
    /**
     * [Function] destroy
     * @param Request $req

There is no parameter named $req. Was it maybe removed?

     * 
     * @return json
     */
    public function destroy($id)
    {
        $state = $this->transitionModel->findOrFail($id)->delete();

$state is not used, you could remove the assignment.

        return response()->json(['status' => true]);
    }
}