bantenprov / vue-opd

src/Http/Controllers/VueOpdController.php

<?php

namespace Bantenprov\VueOpd\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Validation\Rule;
use Bantenprov\VueOpd\Facades\VueOpdFacade;

/* Models */
use Bantenprov\VueOpd\Models\Bantenprov\VueOpd\VueOpd;

/* Etc */
use Validator;

/**
 * The VueOpdController class.
 *
 * @package Bantenprov\VueOpd
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class VueOpdController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(VueOpd $vue_opd)
    {
        $this->vue_opd = $vue_opd;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->vue_opd->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->vue_opd->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('id', 'like', $value)
                    ->orWhere('kunker', 'like', $value)
                    ->orWhere('name', 'like', $value)
                    ->orWhere('kunker_sinjab', 'like', $value)
                    ->orWhere('kunker_simral', 'like', $value)
                    ->orWhere('levelunker', 'like', $value)
                    ->orWhere('njab', 'like', $value)
                    ->orWhere('npej', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create($id = null)
    {
        $vue_opd = $this->vue_opd;

        if ($id == null) {
            $vue_opd->id            = null;
            $vue_opd->kunker        = null;
            $vue_opd->name          = null;
            $vue_opd->kunker_sinjab = null;
            $vue_opd->kunker_simral = null;
            $vue_opd->levelunker    = 1;
            $vue_opd->njab          = null;
            $vue_opd->npej          = null;

            $response['vue_opd'] = $vue_opd;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['loaded'] = true;
        } else {
            $vue_opd->id            = null;
            $vue_opd->kunker        = null;
            $vue_opd->name          = null;
            $vue_opd->kunker_sinjab = null;
            $vue_opd->kunker_simral = null;
            $vue_opd->levelunker    = $this->vue_opd->findOrFail($id)->levelunker + 1;
            $vue_opd->njab          = null;
            $vue_opd->npej          = null;

            $response['vue_opd'] = $vue_opd;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['loaded'] = 1 == $vue_opd->levelunker < 5 ? true : false;
        }

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\VueOpd  $vue_opd

There is no parameter named $vue_opd. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store(Request $request, $id = null)
    {
        $vue_opd = $this->vue_opd;

        if ($id == null) {
            $validator = Validator::make($request->all(), [
                'kunker'            => 'required|numeric|digits:15|unique:vue_opds,kunker,NULL,id,deleted_at,NULL',
                'name'              => 'required|max:255',
                'kunker_sinjab'     => 'nullable|numeric|max:255',
                'kunker_simral'     => 'nullable|numeric|max:255',
                'levelunker'        => [
                                        'required',
                                        Rule::in([1]),
                ],
                'njab'              => 'required|max:255',
                'npej'              => 'required|max:255',
            ]);
        } else {
            $validator = Validator::make($request->all(), [
                'kunker'            => 'required|numeric|digits:15|unique:vue_opds,kunker,NULL,id,deleted_at,NULL',
                'name'              => 'required|max:255',
                'kunker_sinjab'     => 'nullable|numeric|max:255',
                'kunker_simral'     => 'nullable|numeric|max:255',
                'levelunker'        => [
                                        'required',
                                        Rule::in([2,3,4,5]),
                ],
                'njab'              => 'required|max:255',
                'npej'              => 'required|max:255',
            ]);
        }

        if($validator->fails()){
            $response['error'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = $validator->errors()->first();
        } else {
            if ($id == null) {
                $vue_opd->kunker        = $request->kunker;
                $vue_opd->name          = $request->name;
                $vue_opd->kunker_sinjab = $request->kunker_sinjab;
                $vue_opd->kunker_simral = $request->kunker_simral;
                $vue_opd->levelunker    = 1;
                $vue_opd->njab          = $request->njab;
                $vue_opd->npej          = $request->npej;
                // $vue_opd->parent_id     = null;

45% of this comment could be valid code. Did you maybe forget this after debugging?

                $vue_opd->save();
            } else {
                $vue_opd->kunker        = $request->kunker;
                $vue_opd->name          = $request->name;
                $vue_opd->kunker_sinjab = $request->kunker_sinjab;
                $vue_opd->kunker_simral = $request->kunker_simral;
                $vue_opd->levelunker    = $this->vue_opd->findOrFail($id)->levelunker + 1;
                $vue_opd->njab          = $request->njab;
                $vue_opd->npej          = $request->npej;
                $vue_opd->parent_id     = $this->vue_opd->findOrFail($id)->id;
                $vue_opd->save();
            }

            $response['error'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = 'Success';
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $vue_opd = $this->vue_opd->findOrFail($id);

        $response['vue_opd'] = $vue_opd;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\VueOpd  $vue_opd

There is no parameter named $vue_opd. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {
        $vue_opd = $this->vue_opd->findOrFail($id);

        $response['vue_opd'] = $vue_opd;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\VueOpd  $vue_opd

There is no parameter named $vue_opd. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $vue_opd = $this->vue_opd->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'kunker'            => 'required|numeric|digits:15|unique:vue_opds,kunker,'.$id.',id,deleted_at,NULL',
            'name'              => 'required|max:255',
            'kunker_sinjab'     => 'nullable|numeric|max:255',
            'kunker_simral'     => 'nullable|numeric|max:255',
            'levelunker'        => [
                                    'required',
                                    Rule::in([1,2,3,4,5]),
            ],
            'njab'              => 'required|max:255',
            'npej'              => 'required|max:255',
        ]);

        if($validator->fails()){
            $response['error'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = $validator->errors()->first();
        } else {
            $vue_opd->kunker        = $request->kunker;
            $vue_opd->name          = $request->name;
            $vue_opd->kunker_sinjab = $request->kunker_sinjab;
            $vue_opd->kunker_simral = $request->kunker_simral;
            // $vue_opd->levelunker    = $request->levelunker;

46% of this comment could be valid code. Did you maybe forget this after debugging?

            $vue_opd->njab          = $request->njab;
            $vue_opd->npej          = $request->npej;
            $vue_opd->save();

            $response['error'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = 'Success';
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\VueOpd  $vue_opd

There is no parameter named $vue_opd. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $vue_opd = $this->vue_opd->findOrFail($id);

        if ($vue_opd->delete()) {
            $response['loaded'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['loaded'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        return json_encode($response);
    }
}