VueOpdController::edit() - Code Metrics - Inspection of "repackage from group-egovernment" - bantenprov/vue-opd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6ee175...4a5f9e )

unknown

created 2018-02-24 09:39 UTC

VueOpdController::edit() A

↳ Parent: VueOpdController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Bantenprov\VueOpd\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\BudgetAbsorption\Facades\VueOpdFacade;

/* Models */
use Bantenprov\VueOpd\Models\Bantenprov\VueOpd\VueOpd;

/* Etc */
use Validator;

/**
 * The VueOpdController class.
 *
 * @package Bantenprov\VueOpd
 * @author  bantenprov <[email protected]>
 */
class VueOpdController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct(VueOpd $vue_opd)
    {
        $this->vue_opd = $vue_opd;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->vue_opd->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->vue_opd->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('id', 'like', $value)
                    ->orWhere('kunker', 'like', $value)
                    ->orWhere('name', 'like', $value)
                    ->orWhere('kunker_sinjab', 'like', $value)
                    ->orWhere('kunker_simral', 'like', $value)
                    ->orWhere('levelunker', 'like', $value)
                    ->orWhere('njab', 'like', $value)
                    ->orWhere('npej', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\VueOpd  $vue_opd
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\VueOpd  $vue_opd
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\VueOpd  $vue_opd
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\VueOpd  $vue_opd
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $vue_opd = $this->vue_opd->findOrFail($id);

        if ($vue_opd->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\VueOpd\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\BudgetAbsorption\Facades\VueOpdFacade;
9
10			/* Models */
11			use Bantenprov\VueOpd\Models\Bantenprov\VueOpd\VueOpd;
12
13			/* Etc */
14			use Validator;
15
16			/**
17			* The VueOpdController class.
18			*
19			* @package Bantenprov\VueOpd
20			* @author bantenprov <[email protected]>
21			*/
22			class VueOpdController extends Controller
23			{
24			/**
25			* Create a new controller instance.
26			*
27			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
28			*/
29			public function __construct(VueOpd $vue_opd)
30			{
31			$this->vue_opd = $vue_opd;
32			}
33
34			/**
35			* Display a listing of the resource.
36			*
37			* @return \Illuminate\Http\Response
38			*/
39			public function index(Request $request)
40			{
41			if (request()->has('sort')) {
42			list($sortCol, $sortDir) = explode('\|', request()->sort);
43
44			$query = $this->vue_opd->orderBy($sortCol, $sortDir);
45			} else {
46			$query = $this->vue_opd->orderBy('id', 'asc');
47			}
48
49			if ($request->exists('filter')) {
50			$query->where(function($q) use($request) {
51			$value = "%{$request->filter}%";
52			$q->where('id', 'like', $value)
53			->orWhere('kunker', 'like', $value)
54			->orWhere('name', 'like', $value)
55			->orWhere('kunker_sinjab', 'like', $value)
56			->orWhere('kunker_simral', 'like', $value)
57			->orWhere('levelunker', 'like', $value)
58			->orWhere('njab', 'like', $value)
59			->orWhere('npej', 'like', $value);
60			});
61			}
62
63			$perPage = request()->has('per_page') ? (int) request()->per_page : null;
64			$response = $query->paginate($perPage);
65
66			return response()->json($response)
67			->header('Access-Control-Allow-Origin', '*')
68			->header('Access-Control-Allow-Methods', 'GET');
69			}
70
71			/**
72			* Show the form for creating a new resource.
73			*
74			* @return \Illuminate\Http\Response
75			*/
76			public function create()
77			{
78			//
79			}
80
81			/**
82			* Display the specified resource.
83			*
84			* @param \App\VueOpd $vue_opd
			0 ignored issues – show Bug introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report There is no parameter named `$vue_opd`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
85			* @return \Illuminate\Http\Response
86			*/
87			public function store(Request $request)
88			{
89			//
90			}
91
92			/**
93			* Store a newly created resource in storage.
94			*
95			* @param \Illuminate\Http\Request $request
			0 ignored issues – show Bug introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report There is no parameter named `$request`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
96			* @return \Illuminate\Http\Response
97			*/
98			public function show($id)
99			{
100			//
101			}
102
103			/**
104			* Show the form for editing the specified resource.
105			*
106			* @param \App\VueOpd $vue_opd
			0 ignored issues – show Bug introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report There is no parameter named `$vue_opd`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
107			* @return \Illuminate\Http\Response
108			*/
109			public function edit($id)
110			{
111			//
112			}
113
114			/**
115			* Update the specified resource in storage.
116			*
117			* @param \Illuminate\Http\Request $request
118			* @param \App\VueOpd $vue_opd
			0 ignored issues – show Bug introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report There is no parameter named `$vue_opd`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
119			* @return \Illuminate\Http\Response
120			*/
121			public function update(Request $request, $id)
122			{
123			//
124			}
125
126			/**
127			* Remove the specified resource from storage.
128			*
129			* @param \App\VueOpd $vue_opd
			0 ignored issues – show Bug introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report There is no parameter named `$vue_opd`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
130			* @return \Illuminate\Http\Response
131			*/
132			public function destroy($id)
133			{
134			$vue_opd = $this->vue_opd->findOrFail($id);
135
136			if ($vue_opd->delete()) {
137			$response['status'] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report `$response` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$response = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
138			} else {
139			$response['status'] = false;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-02-24 09:41 UTC by Report Bug Copy Issue Report `$response` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$response = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
140			}
141
142			return json_encode($response);
143			}
144			}
145

bantenprov / vue-opd

Push — master ( 6ee175...4a5f9e )

VueOpdController::edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like