SktmController::update() - Code Metrics - Inspection of "Fix CRUD master sktm and index and delete sktm" - bantenprov/sktm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2018-04-23 10:27 UTC

SktmController::update() B

↳ Parent: SktmController

Complexity

Conditions	4
Paths	3

Size

Total Lines	60
Code Lines	39

Duplication

Lines	39
Ratio	65 %

Importance

Changes

Metric	Value
cc	4
eloc	39
nc	3
nop	2
dl	39
loc	60
rs	8.9618
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Bantenprov\Sktm\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Bantenprov\Sktm\Facades\SktmFacade;

/* Models */
use Bantenprov\Sktm\Models\Bantenprov\Sktm\Sktm;
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
use App\User;
use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;

/* Etc */
use Validator;
use Auth;

/**
 * The SktmController class.
 *
 * @package Bantenprov\Sktm
 * @author  bantenprov <[email protected]>
 */
class SktmController extends Controller
{
    protected $sktm;
    protected $siswa;
    protected $master_sktm;
    protected $user;
    protected $nilai;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->sktm         = new Sktm;
        $this->siswa        = new Siswa;
        $this->master_sktm  = new MasterSktm;
        $this->user         = new User;
        $this->nilai        = new Sktm;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->sktm->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->sktm->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";

                $q->where('nomor_un', 'like', $value)
                    ->orWhere('no_sktm', 'like', $value);
            });
        }

        $perPage    = request()->has('per_page') ? (int) request()->per_page : null;

        $response   = $query->with(['siswa', 'master_sktm', 'user'])->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()
    {
        $sktms = $this->sktm->with(['siswa', 'master_sktm', 'user'])->get();

        foreach ($sktms as $sktm) {
            if ($sktm->siswa !== null) {
                array_set($sktm, 'label', $sktm->siswa->nomor_un.' - '.$sktm->siswa->nama_siswa);
            } else {
                array_set($sktm, 'label', $sktm->nomor_un.' - ');
            }
        }

        $response['sktms']  = $sktms;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $sktm           = $this->sktm->getAttributes();
        $siswas         = $this->siswa->getAttributes();
        $users          = $this->user->getAttributes();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        foreach ($siswas as $siswa) {
            array_set($siswa, 'label', $siswa->nomor_un.' - '.$siswa->nama_siswa);
        }

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if ($role_check) {

            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        } else {
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['sktm']           = $sktm;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['siswas']         = $siswas;
        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $sktm = $this->sktm;

        $validator = Validator::make($request->all(), [
            'nomor_un'          => "required|exists:{$this->siswa->getTable()},nomor_un|unique:{$this->sktm->getTable()},nomor_un,NULL,id,deleted_at,NULL",
            'bahasa_indonesia'  => 'required|numeric|min:0|max:100',
            'bahasa_inggris'    => 'required|numeric|min:0|max:100',
            'matematika'        => 'required|numeric|min:0|max:100',
            'ipa'               => 'required|numeric|min:0|max:100',
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sktm->nomor_un         = $request->input('nomor_un');
            $sktm->bahasa_indonesia = $request->input('bahasa_indonesia');
            $sktm->bahasa_inggris   = $request->input('bahasa_inggris');
            $sktm->matematika       = $request->input('matematika');
            $sktm->ipa              = $request->input('ipa');
            $sktm->user_id          = $request->input('user_id');

            $nilai = $this->nilai->updateOrCreate(
                [
                    'nomor_un'  => $sktm->nomor_un,
                ],
                [
                    'nomor_un'  => $sktm->nomor_un,
                    'bobot'     => $sktm->calcSktmBobot($request),
                    'sktm'  => $sktm->calcSktmSktm($request),
                    'total'     => null,
                    'user_id'   => $sktm->user_id,
                ]
            );

            DB::beginTransaction();

            if ($sktm->save() && $nilai->save())
            {
                DB::commit();

                $error      = false;
                $message    = 'Success';
            } else {
                DB::rollBack();

                $error      = true;
                $message    = 'Failed';
            }
        }

        $response['sktm']   = $sktm;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = $error;
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Sktm  $nilai
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        $sktm = $this->sktm->with(['siswa', 'master_sktm', 'user'])->findOrFail($id);

        $response['sktm']   = $sktm;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Sktm  $nilai
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $sktm           = $this->sktm->with(['siswa', 'master_sktm', 'user'])->findOrFail($id);
        $siswas         = $this->siswa->getAttributes();
        $users          = $this->user->getAttributes();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        if ($sktm->siswa !== null) {
            array_set($sktm->siswa, 'label', $sktm->siswa->nomor_un.' - '.$sktm->siswa->nama_siswa);
        }

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if ($sktm->user !== null) {
            array_set($sktm->user, 'label', $sktm->user->name);
        }

        if ($role_check) {

            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        } else {
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['sktm']       = $sktm;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['siswas']         = $siswas;
        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Sktm  $nilai
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $sktm = $this->sktm->with(['siswa', 'master_sktm', 'user'])->findOrFail($id);

        $validator = Validator::make($request->all(), [
            // 'nomor_un'          => "required|exists:{$this->siswa->getTable()},nomor_un|unique:{$this->sktm->getTable()},nomor_un,{$id},id,deleted_at,NULL",

            'bahasa_indonesia'  => 'required|numeric|min:0|max:100',
            'bahasa_inggris'    => 'required|numeric|min:0|max:100',
            'matematika'        => 'required|numeric|min:0|max:100',
            'ipa'               => 'required|numeric|min:0|max:100',
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $sktm->nomor_un         = $sktm->nomor_un; // $request->input('nomor_un');

            $sktm->bahasa_indonesia = $request->input('bahasa_indonesia');
            $sktm->bahasa_inggris   = $request->input('bahasa_inggris');
            $sktm->matematika       = $request->input('matematika');
            $sktm->ipa              = $request->input('ipa');
            $sktm->user_id          = $request->input('user_id');

            $nilai = $this->nilai->updateOrCreate(
                [
                    'nomor_un'  => $sktm->nomor_un,
                ],
                [
                    'nomor_un'  => $sktm->nomor_un,
                    'bobot'     => $sktm->calcSktmBobot($request),
                    'sktm'  => $sktm->calcSktmSktm($request),
                    'total'     => null,
                    'user_id'   => $sktm->user_id,
                ]
            );

            DB::beginTransaction();

            if ($sktm->save() && $nilai->save())
            {
                DB::commit();

                $error      = false;
                $message    = 'Success';
            } else {
                DB::rollBack();

                $error      = true;
                $message    = 'Failed';
            }
        }

        $response['sktm']   = $sktm;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = $error;
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Sktm  $nilai
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $sktm = $this->sktm->findOrFail($id);

        if ($sktm->delete()) {
            $response['message']    = 'Success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\Sktm\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Facades\DB;
9			use Bantenprov\Sktm\Facades\SktmFacade;
10
11			/* Models */
12			use Bantenprov\Sktm\Models\Bantenprov\Sktm\Sktm;
13			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
14			use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
15			use App\User;
16			use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;
17
18			/* Etc */
19			use Validator;
20			use Auth;
21
22			/**
23			* The SktmController class.
24			*
25			* @package Bantenprov\Sktm
26			* @author bantenprov <[email protected]>
27			*/
28			class SktmController extends Controller
29			{
30			protected $sktm;
31			protected $siswa;
32			protected $master_sktm;
33			protected $user;
34			protected $nilai;
35
36			/**
37			* Create a new controller instance.
38			*
39			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-04-23 10:29 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...

bantenprov / sktm

Pull Request — master (#12)

SktmController::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like