Bantenprov\Sktm\Http\Controllers\MasterSktmController

Complexity

Total Complexity

19

Size/Duplication

Total Lines	231
Duplicated Lines	29.87 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	create()	0	13	2
B	index()	0	29	5
B	store()	23	39	3
A	show()	0	10	1
A	edit()	11	12	1
B	update()	23	50	4
A	destroy()	12	12	2

<?php

namespace Bantenprov\Sktm\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Sktm\Facades\SktmFacade;

/* Models */
use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
use App\User;

/* Etc */
use Validator;

/**
 * The SktmController class.
 *
 * @package Bantenprov\Sktm
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class MasterSktmController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $master_sktm;
    protected $user;

    public function __construct(MasterSktm $master_sktm, User $user)
    {
        $this->master_sktm = $master_sktm;
        $this->user = $user;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->master_sktm->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->master_sktm->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('nama', 'like', $value)
                    ->orWhere('nilai', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        foreach($response as $user){
            array_set($response->data, 'user', $user->user->name);
        }

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */

    public function create()
    {
        $users = $this->user->all();

        foreach($users as $user){
            array_set($user, 'label', $user->name);
        }
        
        $response['user'] = $users;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Sktm  $sktm

There is no parameter named $sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $master_sktm = $this->master_sktm;

        $validator = Validator::make($request->all(), [
            'user_id' => 'required|unique:master_sktms,user_id',
            'nama' => 'required',
            'nilai' => 'required',
            'instansi' => 'required',
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            $check = $master_sktm->where('user_id',$request->user_id)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed, Username ' . $request->user_id . ' already exists';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            } else {
                $master_sktm->user_id = $request->input('user_id');
                $master_sktm->nama = $request->input('nama');
                $master_sktm->nilai = $request->input('nilai');
                $master_sktm->instansi = $request->input('instansi');
                $master_sktm->save();

                $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            }
        } else {
                $master_sktm->user_id = $request->input('user_id');
                $master_sktm->nama = $request->input('nama');
                $master_sktm->nilai = $request->input('nilai');
                $master_sktm->instansi = $request->input('instansi');
                $master_sktm->save();

            $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $master_sktm = $this->master_sktm->findOrFail($id);
        
        $response['user'] = $master_sktm->user;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['master_sktm'] = $master_sktm;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Sktm  $sktm
     * @return \Illuminate\Http\Response

There is no parameter named $sktm. Was it maybe removed?

     */

    public function edit($id)

This method seems to be duplicated in your project.

    {
        $master_sktm = $this->master_sktm->findOrFail($id);

        array_set($master_sktm->user, 'label', $master_sktm->user->name);

        $response['master_sktm'] = $master_sktm;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['user'] = $master_sktm->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Sktm  $sktm

There is no parameter named $sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $master_sktm = $this->master_sktm->findOrFail($id);

        if ($request->input('user_id') == $request->input('user_id'))
        {
            $validator = Validator::make($request->all(), [
                'user_id' => 'required|unique:master_sktms,user_id',
                'nama' => 'required',
                'nilai' => 'required',
                'instansi' => 'required',
                
            ]);
        } else {
            $validator = Validator::make($request->all(), [
                'user_id' => 'required|unique:master_sktms,user_id',
                'nama' => 'required',
                'nilai' => 'required',
                'instansi' => 'required',
            ]);
        }

        if ($validator->fails()) {

This code seems to be duplicated across your project.

            $check = $master_sktm->where('user_id',$request->user_id)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed, Username ' . $request->user_id . ' already exists';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            } else {
                $master_sktm->user_id = $request->input('user_id');
                $master_sktm->nama = $request->input('nama');
                $master_sktm->nilai = $request->input('nilai');
                $master_sktm->instansi = $request->input('instansi');
                $master_sktm->save();

                $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            }
        } else {
                $master_sktm->user_id = $request->input('user_id');
                $master_sktm->nama = $request->input('nama');
                $master_sktm->nilai = $request->input('nilai');
                $master_sktm->instansi = $request->input('instansi');
                $master_sktm->save();

            $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Sktm  $sktm

There is no parameter named $sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $master_sktm = $this->master_sktm->findOrFail($id);

        if ($master_sktm->delete()) {
            $response['status'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['status'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        return json_encode($response);
    }
}