Bantenprov\Sktm\Http\Controllers\MasterSktmController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	280
Duplicated Lines	45.71 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	get()	11	11	1
B	store()	32	32	2
A	show()	11	11	1
B	edit()	43	43	5
B	update()	31	31	2
A	destroy()	0	16	2
B	index()	0	27	4
B	create()	0	39	4

<?php

namespace Bantenprov\Sktm\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Bantenprov\Sktm\Facades\SktmFacade;

/* Models */
use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
use App\User;

/* Etc */
use Validator;
use Auth;

/**
 * The MasterSktmController class.
 *
 * @package Bantenprov\Sktm
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class MasterSktmController extends Controller
{
    protected $master_sktm;
    protected $user;

    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->master_sktm  = new MasterSktm;
        $this->user         = new User;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->master_sktm->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->master_sktm->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";

                $q->where('nama', 'like', $value)
                    ->orWhere('instansi', 'like', $value);
            });
        }

        $perPage    = request()->has('per_page') ? (int) request()->per_page : null;

        $response   = $query->with(['user'])->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()

This method seems to be duplicated in your project.

    {
        $master_sktms = $this->master_sktm->with(['user'])->get();

        $response['master_sktms']   = $master_sktms;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $master_sktm    = $this->master_sktm->getAttributes();
        $users          = $this->user->getAttributes();

$users is not used, you could remove the assignment.

        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if ($role_check) {
            $user_special = true;

            foreach ($users_special as $user) {
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        } else {
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['master_sktm']    = $master_sktm;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)

This method seems to be duplicated in your project.

    {
        $master_sktm = $this->master_sktm;

        $validator = Validator::make($request->all(), [
            'nama'      => "required|max:255|unique:{$this->master_sktm->getTable()},nama,NULL,id,instansi,{$request->input('instansi')},deleted_at,NULL",
            'instansi'  => 'required|max:255',
            'nilai'     => 'required|numeric|max:100',
            'user_id'   => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {
            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $master_sktm->nama      = $request->input('nama');
            $master_sktm->instansi  = $request->input('instansi');
            $master_sktm->nilai     = $request->input('nilai');
            $master_sktm->user_id   = $request->input('user_id');
            $master_sktm->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['master_sktm']    = $master_sktm;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']          = $error;
        $response['message']        = $message;
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\MasterSktm  $master_sktm

There is no parameter named $master_sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $master_sktm = $this->master_sktm->with(['user'])->findOrFail($id);

        $response['master_sktm']    = $master_sktm;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\MasterSktm  $master_sktm

There is no parameter named $master_sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $master_sktm    = $this->master_sktm->with(['user'])->findOrFail($id);
        $users          = $this->user->getAttributes();

$users is not used, you could remove the assignment.

        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if ($master_sktm->user !== null) {
            array_set($master_sktm->user, 'label', $master_sktm->user->name);
        }

        if ($role_check) {
            $user_special = true;

            foreach ($users_special as $user) {
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        } else {
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['master_sktm']    = $master_sktm;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\MasterSktm  $master_sktm

There is no parameter named $master_sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

This method seems to be duplicated in your project.

    {
        $master_sktm = $this->master_sktm->with(['user'])->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'nama'      => "required|max:255|unique:{$this->master_sktm->getTable()},nama,{$id},id,instansi,{$request->input('instansi')},deleted_at,NULL",
            'instansi'  => 'required|max:255',
            'nilai'     => 'required|numeric|max:100',
            'user_id'   => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {
            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $master_sktm->nama      = $request->input('nama');
            $master_sktm->instansi  = $request->input('instansi');
            $master_sktm->nilai     = $request->input('nilai');
            $master_sktm->user_id   = $request->input('user_id');
            $master_sktm->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\MasterSktm  $master_sktm

There is no parameter named $master_sktm. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $master_sktm = $this->master_sktm->findOrFail($id);

        if ($master_sktm->delete()) {
            $response['message']    = 'Success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}