SiswaController - Code Metrics - Inspection of "Merge pull request #26 from arifin09/master" - bantenprov/siswa - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( f8ff77...d44702 )

unknown
created 2018-04-26 20:46 UTC
SiswaController A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	390
Duplicated Lines	14.1 %
Coupling/Cohesion

Components	1
Dependencies	1
Importance

Changes
Metric	Value
dl	55
loc	390
rs	10
c	0
b	0
f	0
wmc	29
lcom	1
cbo	1
9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	index()	0	36	6
A	get()	0	19	3
A	destroy()	0	16	2
F	create()	0	77	10
A	store()	27	59	2
A	show()	0	15	2
B	edit()	0	25	1
A	update()	28	61	2
How to fix Duplicated Code

<?php

namespace Bantenprov\Siswa\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Siswa\Facades\SiswaFacade;

/* Models */
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use Laravolt\Indonesia\Models\Province;
use Laravolt\Indonesia\Models\City;
use Laravolt\Indonesia\Models\District;
use Laravolt\Indonesia\Models\Village;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\ProdiSekolah;
use App\User;

/* Etc */
use Validator;
use Auth;

/**
 * The SiswaController class.
 *
 * @package Bantenprov\Siswa
 * @author  bantenprov <[email protected]>
 */
class SiswaController extends Controller
{
    protected $siswa;
    protected $province;
    protected $city;
    protected $district;
    protected $village;
    protected $sekolah;
    protected $prodi_sekolah;
    protected $user;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->siswa            = new Siswa;
        $this->province         = new Province;
        $this->city             = new City;
        $this->district         = new District;
        $this->village          = new Village;
        $this->sekolah          = new Sekolah;
        $this->prodi_sekolah    = new ProdiSekolah;
        $this->user             = new User;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->siswa->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->siswa->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";

                $q->where('nomor_un', 'like', $value)
                    ->orWhere('nik', 'like', $value)
                    ->orWhere('nama_siswa', 'like', $value)
                    ->orWhere('no_kk', 'like', $value)
                    ->orWhere('nisn', 'like', $value);
            });
        }

        $perPage    = request()->has('per_page') ? (int) request()->per_page : null;

        $response   = $query->with(['province', 'city', 'district', 'village', 'sekolah', 'prodi_sekolah', 'user'])->paginate($perPage);

        foreach($response as $siswa){
            if (isset($siswa->prodi_sekolah->program_keahlian)) {
                $siswa->prodi_sekolah->program_keahlian;
            }
        }

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()
    {
        $siswas = $this->siswa->with(['province', 'city', 'district', 'village', 'sekolah', 'prodi_sekolah', 'user'])->get();

        foreach($siswas as $siswa){
            array_set($siswa, 'label', $siswa->nama_siswa);

            if (isset($siswa->prodi_sekolah->program_keahlian)) {
                $siswa->prodi_sekolah->program_keahlian;
            }
        }

        $response['siswas']   = $siswas;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create(Request $request)
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $siswa          = $this->siswa->getAttributes();
        $provinces      = $this->province->getAttributes();
        $cities         = $this->city->getAttributes();
        $districts      = $this->district->getAttributes();
        $villages       = $this->village->getAttributes();
        $sekolahs       = $this->sekolah->get();
        $prodi_sekolahs = $this->prodi_sekolah->get();
        $users          = $this->user->getAttributes();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        // dd($prodi_sekolahs);


        foreach($provinces as $province){
            array_set($province, 'label', $province->name);
        }

        foreach($cities as $city){
            array_set($city, 'label', $city->name);
        }

        foreach($districts as $district){
            array_set($district, 'label', $district->name);
        }

        foreach($villages as $village){
            array_set($village, 'label', $village->name);
        }

        foreach($sekolahs as $sekolah){
            array_set($sekolah, 'label', $sekolah->nama);
        }

        foreach($prodi_sekolahs as $prodi_sekolah){
            array_set($prodi_sekolah, 'label', $prodi_sekolah->keterangan);
        }

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){
            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        }else{
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['siswa']          = $siswa;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['provinces']      = $provinces;
        $response['cities']         = $cities;
        $response['districts']      = $districts;
        $response['villages']       = $villages;
        $response['sekolahs']       = $sekolahs;
        $response['prodi_sekolahs'] = $prodi_sekolahs;
        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $siswa      = $this->siswa;
        $validator  = Validator::make($request->all(), [
            'nomor_un'          => "required|max:255|unique:{$this->siswa->getTable()},nomor_un,NULL,id,deleted_at,NULL",
            'nik'               => "required|digits:16|unique:{$this->siswa->getTable()},nik,NULL,id,deleted_at,NULL",
            'nama_siswa'        => 'required|max:255',
            'no_kk'             => "required|digits:16|unique:{$this->siswa->getTable()},no_kk,NULL,id,deleted_at,NULL",
            'alamat_kk'         => 'required|max:255',
            'province_id'       => "required|exists:{$this->province->getTable()},id",
            'city_id'           => "required|exists:{$this->city->getTable()},id",
            'district_id'       => "required|exists:{$this->district->getTable()},id",
            'village_id'        => "required|exists:{$this->village->getTable()},id",
            'tempat_lahir'      => 'required|max:255',
            'tgl_lahir'         => 'required|date',
            'jenis_kelamin'     => 'required|max:255',
            'agama'             => 'required|max:255',
            'nisn'              => "required|between:6,15|unique:{$this->siswa->getTable()},nisn,NULL,id,deleted_at,NULL",
            'tahun_lulus'       => 'required|date_format:Y',
            'sekolah_id'        => "required|exists:{$this->sekolah->getTable()},id",
            'prodi_sekolah_id'  => "required|exists:{$this->prodi_sekolah->getTable()},id",
            'user_id'           => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();
        } else {
            $siswa->user_id             = $request->input('user_id');
            $siswa->nomor_un            = $request->input('nomor_un');
            $siswa->nik                 = $request->input('nik');
            $siswa->nama_siswa          = $request->input('nama_siswa');
            $siswa->no_kk               = $request->input('no_kk');
            $siswa->alamat_kk           = $request->input('alamat_kk');
            $siswa->province_id         = $request->input('province_id');
            $siswa->city_id             = $request->input('city_id');
            $siswa->district_id         = $request->input('district_id');
            $siswa->village_id          = $request->input('village_id');
            $siswa->tempat_lahir        = $request->input('tempat_lahir');
            $siswa->tgl_lahir           = $request->input('tgl_lahir');
            $siswa->jenis_kelamin       = $request->input('jenis_kelamin');
            $siswa->agama               = $request->input('agama');
            $siswa->nisn                = $request->input('nisn');
            $siswa->sekolah_id          = $request->input('sekolah_id');
            $siswa->prodi_sekolah_id    = $request->input('prodi_sekolah_id');
            $siswa->tahun_lulus         = $request->input('tahun_lulus');
            $siswa->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['siswa']      = $siswa;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = $error;
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Siswa  $siswa
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $siswa = $this->siswa->with(['province', 'city', 'district', 'village', 'sekolah', 'prodi_sekolah', 'user'])->findOrFail($id);

        if (isset($siswa->prodi_sekolah->program_keahlian)) {
            $siswa->prodi_sekolah->program_keahlian;
        }

        $response['siswa']      = $siswa;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Siswa  $siswa
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $siswa = $this->siswa->with(['province', 'city', 'district', 'village', 'sekolah', 'prodi_sekolah', 'user'])->findOrFail($id);

        $response['siswa']['province'] = array_add($siswa->province, 'label', $siswa->province->name);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $response['siswa']['city'] = array_add($siswa->city, 'label', $siswa->city->name);

        $response['siswa']['district'] = array_add($siswa->district, 'label', $siswa->district->name);

        $response['siswa']['village'] = array_add($siswa->village, 'label', $siswa->village->name);

        $response['siswa']['sekolah'] = array_add($siswa->sekolah, 'label', $siswa->sekolah->nama);

        $response['siswa']['prodi_sekolah'] = array_add($siswa->prodi_sekolah, 'label', $siswa->prodi_sekolah->keterangan);



        $response['siswa']      = $siswa;
        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Siswa  $siswa
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $siswa = $this->siswa->with(['province', 'city', 'district', 'village', 'sekolah', 'prodi_sekolah', 'user'])->findOrFail($id);

            $validator = Validator::make($request->all(), [
                'nomor_un'          => "required|max:255|unique:{$this->siswa->getTable()},nomor_un,{$id},id,deleted_at,NULL",
                'nik'               => "required|digits:16|unique:{$this->siswa->getTable()},nik,{$id},id,deleted_at,NULL",
                'nama_siswa'        => 'required|max:255',
                'no_kk'             => "required|digits:16|unique:{$this->siswa->getTable()},no_kk,{$id},id,deleted_at,NULL",
                'alamat_kk'         => 'required|max:255',
                'province_id'       => "required|exists:{$this->province->getTable()},id",
                'city_id'           => "required|exists:{$this->city->getTable()},id",
                'district_id'       => "required|exists:{$this->district->getTable()},id",
                'village_id'        => "required|exists:{$this->village->getTable()},id",
                'tempat_lahir'      => 'required|max:255',
                'tgl_lahir'         => 'required|date',
                'jenis_kelamin'     => 'required|max:255',
                'agama'             => 'required|max:255',
                'nisn'              => "required|between:4,17|unique:{$this->siswa->getTable()},nisn,{$id},id,deleted_at,NULL",
                'tahun_lulus'       => 'required|date_format:Y',
                'sekolah_id'        => "required|exists:{$this->sekolah->getTable()},id",
                'prodi_sekolah_id'  => "required|exists:{$this->prodi_sekolah->getTable()},id",
                'user_id'           => "required|exists:{$this->user->getTable()},id",

                ]);

            if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();

            } else {
                $siswa->user_id             = $request->input('user_id');
                $siswa->nomor_un            = $request->input('nomor_un');
                $siswa->nik                 = $request->input('nik');
                $siswa->nama_siswa          = $request->input('nama_siswa');
                $siswa->no_kk               = $request->input('no_kk');
                $siswa->alamat_kk           = $request->input('alamat_kk');
                $siswa->province_id         = $request->input('province_id');
                $siswa->city_id             = $request->input('city_id');
                $siswa->district_id         = $request->input('district_id');
                $siswa->village_id          = $request->input('village_id');
                $siswa->tempat_lahir        = $request->input('tempat_lahir');
                $siswa->tgl_lahir           = $request->input('tgl_lahir');
                $siswa->jenis_kelamin       = $request->input('jenis_kelamin');
                $siswa->agama               = $request->input('agama');
                $siswa->nisn                = $request->input('nisn');
                $siswa->sekolah_id          = $request->input('sekolah_id');
                $siswa->prodi_sekolah_id    = $request->input('prodi_sekolah_id');
                $siswa->tahun_lulus         = $request->input('tahun_lulus');
                $siswa->save();

                $error      = false;
                $message    = 'Success';
            }

        $response['error']      = $error;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Siswa  $siswa
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $siswa = $this->siswa->findOrFail($id);

        if ($siswa->delete()) {
            $response['message']    = 'Success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}

1			<?php
2
3			namespace Bantenprov\Siswa\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\Siswa\Facades\SiswaFacade;
9
10			/* Models */
11			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
12			use Laravolt\Indonesia\Models\Province;
13			use Laravolt\Indonesia\Models\City;
14			use Laravolt\Indonesia\Models\District;
15			use Laravolt\Indonesia\Models\Village;
16			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
17			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\ProdiSekolah;
18			use App\User;
19
20			/* Etc */
21			use Validator;
22			use Auth;
23
24			/**
25			* The SiswaController class.
26			*
27			* @package Bantenprov\Siswa
28			* @author bantenprov <[email protected]>
29			*/
30			class SiswaController extends Controller
31			{
32			protected $siswa;
33			protected $province;
34			protected $city;
35			protected $district;
36			protected $village;
37			protected $sekolah;
38			protected $prodi_sekolah;
39			protected $user;
40
bantenprov / siswa

Push — master ( f8ff77...d44702 )

SiswaController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like
