SeleksiController::update() - Code Metrics - Inspection of "Merge pull request #3 from fadika06/master" - bantenprov/seleksi - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( b76649...5832b1 )

unknown
created 2018-04-17 00:18 UTC
SeleksiController::update() C

↳ Parent: SeleksiController
Complexity

Conditions	7
Paths	7
Size

Total Lines	51
Code Lines	34
Duplication

Lines	18
Ratio	35.29 %
Importance

Changes
Metric	Value
cc	7
eloc	34
nc	7
nop	2
dl	18
loc	51
rs	6.9743
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Bantenprov\Seleksi\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;

/* Models */
use Bantenprov\Seleksi\Models\Bantenprov\Seleksi\Seleksi;
use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;
use App\User;

/* Etc */
use Validator;

/**
 * The SeleksiController class.
 *
 * @package Bantenprov\Seleksi
 * @author  bantenprov <[email protected]>
 */
class SeleksiController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $pendaftaran;
    protected $seleksi;
    protected $siswa;
    protected $nilai;
    protected $user;

    public function __construct(Seleksi $seleksi, Pendaftaran $pendaftaran, User $user, Siswa $siswa, Nilai $nilai)
    {
        $this->seleksi        = $seleksi;
        $this->pendaftaran    = $pendaftaran;
        $this->user           = $user;
        $this->siswa          = $siswa;
        $this->nilai          = $nilai;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->seleksi->with('pendaftaran')->with('user')->with('siswa')->with('nilai')->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->seleksi->with('pendaftaran')->with('user')->with('siswa')->with('nilai')->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('nilai_id', 'like', $value)
                    ->orWhere('pendaftaran_id', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $response = [];

        $pendaftarans = $this->pendaftaran->all();
        $siswas = $this->siswa->all();
        $nilais = $this->nilai->all();
        $users_special = $this->user->all();
        $users_standar = $this->user->find(\Auth::User()->id);
        $current_user = \Auth::User();

        $role_check = \Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){
            $response['user_special'] = true;
            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }
            $response['user'] = $users_special;
        }else{
            $response['user_special'] = false;
            array_set($users_standar, 'label', $users_standar->name);
            $response['user'] = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        foreach($pendaftarans as $pendaftaran){
            array_set($pendaftaran, 'label', $pendaftaran->kegiatan->description);
        }

        foreach($siswas as $siswa){
            array_set($siswa, 'label', $siswa->nama_siswa);
        }

        foreach($nilais as $nilai){
            array_set($nilai, 'label', $nilai->siswa->nama_siswa);
        }

        $response['current_user'] = $current_user;
        $response['pendaftaran'] = $pendaftarans;
        $response['siswa'] = $siswas;
        $response['nilai'] = $nilais;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Seleksi  $seleksi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $seleksi = $this->seleksi;
        $current_user_id = $request->user_id;

        $validator = Validator::make($request->all(), [
            'pendaftaran_id' => 'required|unique:seleksis,pendaftaran_id',
            'user_id' => 'required',
            'nilai_id' => 'required|unique:seleksis,nilai_id',
            'nomor_un' => 'required|unique:seleksis,nomor_un'
        ]);

        if($validator->fails()){

            $check = $seleksi->where('pendaftaran_id', $request->pendaftaran_id)->orWhere('nilai_id', $request->nilai_id)->orWhere('nomor_un', $request->nomor_un)->whereNull('deleted_at')->count();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            if ($check > 0) {
                $response['message'] = 'Failed, Pendaftaran, Nama Siswa, Nilai already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $seleksi->pendaftaran_id = $request->input('pendaftaran_id');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $seleksi->user_id = $current_user_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $seleksi->nomor_un = $request->input('nomor_un');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $seleksi->nilai_id = $request->input('nilai_id');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $seleksi->save();                

                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        } else {
            $seleksi->pendaftaran_id = $request->input('pendaftaran_id');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $seleksi->user_id = $current_user_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $seleksi->nomor_un = $request->input('nomor_un');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $seleksi->nilai_id = $request->input('nilai_id');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $seleksi->save();
            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $seleksi = $this->seleksi->findOrFail($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $response['seleksi'] = $seleksi;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['pendaftaran'] = $seleksi->pendaftaran;
        $response['user'] = $seleksi->user;
        $response['siswa'] = $seleksi->siswa;
        $response['nilai'] = $seleksi->nilai;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Seleksi  $seleksi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $seleksi = $this->seleksi->findOrFail($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        array_set($seleksi->user, 'label', $seleksi->user->name);
        array_set($seleksi->pendaftaran, 'label', $seleksi->pendaftaran->kegiatan->description);
        array_set($seleksi->siswa, 'label', $seleksi->siswa->nama_siswa);
        array_set($seleksi->nilai, 'label', $seleksi->nilai->siswa->nama_siswa);


        $response['seleksi'] = $seleksi;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['pendaftaran'] = $seleksi->pendaftaran;
        $response['user'] = $seleksi->user;
        $response['siswa'] = $seleksi->siswa;
        $response['nilai'] = $seleksi->nilai;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Seleksi  $seleksi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {

        $response = array();
        $message  = array();
        $seleksi = $this->seleksi->findOrFail($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            $validator = Validator::make($request->all(), [
                'user_id' => 'required',
                'pendaftaran_id' => 'required|unique:seleksis,pendaftaran_id,'.$id,
                'nomor_un' => 'required|unique:seleksis,nomor_un,'.$id,
                'nilai_id' => 'required|unique:seleksis,nilai_id,'.$id,
            ]);

        if ($validator->fails()) {

            foreach($validator->messages()->getMessages() as $key => $error){
                        foreach($error AS $error_get) {
                            array_push($message, $error_get);
                        }
                    }

             $check_pendaftaran = $this->seleksi->where('id','!=', $id)->where('pendaftaran_id', $request->pendaftaran_id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
             $check_siswa = $this->seleksi->where('id','!=', $id)->where('nomor_un', $request->nomor_un);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
             $check_nilai = $this->seleksi->where('id','!=', $id)->where('nilai_id', $request->nilai_id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

             if($check_pendaftaran->count() > 0 || $check_siswa->count() > 0 || $check_nilai->count() > 0){
                  $response['message'] = implode("\n",$message);
            } else {

                $seleksi->user_id = $request->input('user_id');
                $seleksi->pendaftaran_id = $request->input('pendaftaran_id');
                $seleksi->nomor_un = $request->input('nomor_un');
                $seleksi->nilai_id = $request->input('nilai_id');
                $seleksi->save();

                $response['message'] = 'success';
            }
        } else {

            $seleksi->user_id = $request->input('user_id');
                $seleksi->pendaftaran_id = $request->input('pendaftaran_id');
                $seleksi->nomor_un = $request->input('nomor_un');
                $seleksi->nilai_id = $request->input('nilai_id');
                $seleksi->save();

            $response['message'] = 'success';
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Seleksi  $seleksi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $seleksi = $this->seleksi->findOrFail($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if ($seleksi->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}
1			<?php
2
3			namespace Bantenprov\Seleksi\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8
9			/* Models */
10			use Bantenprov\Seleksi\Models\Bantenprov\Seleksi\Seleksi;
11			use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
12			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
13			use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;
14			use App\User;
15
16			/* Etc */
17			use Validator;
18
19			/**
20			* The SeleksiController class.
21			*
22			* @package Bantenprov\Seleksi
23			* @author bantenprov <[email protected]>
24			*/
25			class SeleksiController extends Controller
26			{
27			/**
28			* Create a new controller instance.
29			*
30			* @return void
31			*/
32			protected $pendaftaran;
33			protected $seleksi;
34			protected $siswa;
35			protected $nilai;
36			protected $user;
37
38			public function __construct(Seleksi $seleksi, Pendaftaran $pendaftaran, User $user, Siswa $siswa, Nilai $nilai)
39			{
40			$this->seleksi = $seleksi;
bantenprov / seleksi

Push — master ( b76649...5832b1 )

SeleksiController::update() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
