Bantenprov\Sekolah\Http\Controllers\JenisSekolahController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	203
Duplicated Lines	47.78 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	index()	13	25	4
A	get()	15	15	2
B	create()	15	39	4
A	store()	8	8	1
A	show()	11	11	1
A	edit()	11	11	1
A	update()	8	8	1
A	destroy()	16	16	2

<?php

namespace Bantenprov\Sekolah\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Sekolah\Facades\SekolahFacade;

/* Models */
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\JenisSekolah;
use App\User;

/* Etc */
use Auth;

/**
 * The JenisSekolahController class.
 *
 * @package Bantenprov\Sekolah
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class JenisSekolahController extends Controller
{
    protected $jenis_sekolah;
    protected $user;

    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->jenis_sekolah    = new JenisSekolah;
        $this->user             = new User;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {

This code seems to be duplicated across your project.

            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->jenis_sekolah->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->jenis_sekolah->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {

This code seems to be duplicated across your project.

            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('jenis_sekolah', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;

        $response = $query->with('user')->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function get()

This method seems to be duplicated in your project.

    {
        $jenis_sekolahs = $this->jenis_sekolah->with('user')->get();

        foreach($jenis_sekolahs as $jenis_sekolah){
            array_set($jenis_sekolah, 'label', $jenis_sekolah->jenis_sekolah);
        }

        $response['jenis_sekolahs']   = $jenis_sekolahs;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $user_id        = isset(Auth::User()->id) ? Auth::User()->id : null;
        $jenis_sekolah        = $this->jenis_sekolah->getAttributes();
        $users          = $this->user->getAttributes();

$users is not used, you could remove the assignment.

        $users_special  = $this->user->all();
        $users_standar  = $this->user->findOrFail($user_id);
        $current_user   = Auth::User();

        $role_check = Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

This code seems to be duplicated across your project.

            $user_special = true;

            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }

            $users = $users_special;
        }else{
            $user_special = false;

            array_set($users_standar, 'label', $users_standar->name);

            $users = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['jenis_sekolah']        = $jenis_sekolah;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['users']          = $users;
        $response['user_special']   = $user_special;
        $response['current_user']   = $current_user;
        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)

This method seems to be duplicated in your project.

    {
        $response['error']          = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\JenisSekolah  $jenis_sekolah

There is no parameter named $jenis_sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $jenis_sekolah = $this->jenis_sekolah->with(['user'])->findOrFail($id);

        $response['jenis_sekolah']    = $jenis_sekolah;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\JenisSekolah  $jenis_sekolah

There is no parameter named $jenis_sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {
        $jenis_sekolah = $this->jenis_sekolah->with(['user'])->findOrFail($id);

        $response['jenis_sekolah']    = $jenis_sekolah;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['error']      = false;
        $response['message']    = 'Success';
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\JenisSekolah  $jenis_sekolah

There is no parameter named $jenis_sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

This method seems to be duplicated in your project.

    {
        $response['error']          = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\JenisSekolah  $jenis_sekolah

There is no parameter named $jenis_sekolah. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $jenis_sekolah = $this->jenis_sekolah->findOrFail($id);

        if ($jenis_sekolah->delete()) {
            $response['message']    = 'Success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = true;
            $response['status']     = true;
        } else {
            $response['message']    = 'Failed';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['success']    = false;
            $response['status']     = false;
        }

        return json_encode($response);
    }
}