Bantenprov\PemakaianBahuJalan\Http\Controllers\TarifController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	146
Duplicated Lines	47.95 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	5	1
A	create()	0	6	1
B	store()	41	41	2
A	show()	0	4	1
A	edit()	0	6	1
B	update()	29	29	2
A	destroy()	0	6	1

<?php 

namespace Bantenprov\PemakaianBahuJalan\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\PemakaianBahuJalan\Facades\Tarif;
use Bantenprov\PemakaianBahuJalan\Models\TarifModel;
use Bantenprov\MasterTarif\Models\MasterTarifModel;
use Ramsey\Uuid\Uuid;

class TarifController extends Controller 
{
  /**
   * Display a listing of the resource.
   *
   * @return Response
   */
  public function index()
  {
    $tarifs = TarifModel::all();
    return view('pemakaian-bahu-jalan::index',compact('tarifs'));
  }

  /**
   * Show the form for creating a new resource.
   *
   * @return Response
   */
  public function create()
  {
    //$mastertarifs = MasterTarifModel::where('levelunker', '=', 1)->get();

62% of this comment could be valid code. Did you maybe forget this after debugging?

    $mastertarifs = MasterTarifModel::all();
    return view('pemakaian-bahu-jalan::create',compact('mastertarifs')); 
  }

  /**
   * Store a newly created resource in storage.
   *
   * @return Response
   */
  public function store(Request $request)

This method seems to be duplicated in your project.

  {
    
    //$daftar_retribusi = TarifModel::find($request->daftar_retribusi_id);

54% of this comment could be valid code. Did you maybe forget this after debugging?

    $request->validate([            
        'uraian'                => 'required',
        'wilayah_kota'          => 'required',
        'wilayah_kabupaten'     => 'required',
        'satuan'                => 'required',
        'master_tarif_id'       => 'required',        
    ]);

    /*

71% of this comment could be valid code. Did you maybe forget this after debugging?

    if(is_null($daftar_retribusi)){
        return redirect()->back()->withErrors('Error : retribusi yang dipilih tidak ditemukan');
    }
    */

    // if($request->status > 1 && $request->status < 0){

50% of this comment could be valid code. Did you maybe forget this after debugging?

    //     return redirect()->back()->withErrors('Error : status salah');

69% of this comment could be valid code. Did you maybe forget this after debugging?

    // }
    if($request->tarif == 'on'){
      $tarif  = 0;
    }else{
      $tarif  = 1;
    }

    TarifModel::create([
        'uuid'                  => Uuid::uuid5(Uuid::NAMESPACE_DNS, 'bantenprov.go.id'.date('YmdHis')),
        'uraian'                => $request->uraian,
        'tarif'                 => $tarif,
        'wilayah_kota'          => $request->wilayah_kota,
        'wilayah_kabupaten'     => $request->wilayah_kabupaten,
        'satuan'                => $request->satuan,
        'master_tarif_id'       => $request->master_tarif_id,
        'user_id'               => \Auth::user()->id,
        'user_update'           => \Auth::user()->id,
    ]);
    $request->session()->flash('message', 'Successfully add new data');
    return redirect()->route('tarif.index');
  }

  /**
   * Display the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function show($id)
  {
    
  }

  /**
   * Show the form for editing the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function edit($id)
  {
    $tarif = TarifModel::find($id);
    $mastertarifs = MasterTarifModel::all();    
    return view('pemakaian-bahu-jalan::edit', compact('tarif','mastertarifs'));
  }

  /**
   * Update the specified resource in storage.
   *
   * @param  int  $id
   * @return Response
   */
  public function update(Request $request, $id)

This method seems to be duplicated in your project.

  {
    $request->validate([            
      'uraian'                => 'required',
      'wilayah_kota'          => 'required',
      'wilayah_kabupaten'     => 'required',
      'satuan'                => 'required',
      'master_tarif_id'       => 'required',        
    ]);
  
    if($request->tarif == 'on'){
      $tarif  = 1;
    }else{
      $tarif  = 0;
    }
    TarifModel::find($id)->update([            
        'uuid'                  => Uuid::uuid5(Uuid::NAMESPACE_DNS, 'bantenprov.go.id'.date('YmdHis')),
        'uraian'                => $request->uraian,
        'tarif'                 => $tarif,
        'wilayah_kota'          => $request->wilayah_kota,
        'wilayah_kabupaten'     => $request->wilayah_kabupaten,
        'satuan'                => $request->satuan,
        'master_tarif_id'       => $request->master_tarif_id,
        'user_id'               => \Auth::user()->id,
        'user_update'           => \Auth::user()->id,
    ]);
    $request->session()->flash('message', 'Successfully add new data');
    return redirect()->route('tarif.index');
  }

  /**
   * Remove the specified resource from storage.
   *
   * @param  int  $id
   * @return Response
   */
  public function destroy(Request $request, $id)
  {
    TarifModel::find($id)->delete();
    $request->session()->flash('message', 'Successfully delete data');
    return redirect()->route('tarif.index');
  }
  
}

?>

It is not recommended to use PHP's closing tag ?> in files other than templates.