bantenprov / prestasi

src/Http/Controllers/JenisPrestasiController.php

<?php

namespace Bantenprov\Prestasi\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Bantenprov\Prestasi\Facades\PrestasiFacade;

/* Models */
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\JenisPrestasi;
use App\User;

/* Etc */
use Validator;
use Auth;

/**
 * The PrestasiController class.
 *
 * @package Bantenprov\Prestasi
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class JenisPrestasiController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $jenis_prestasi;
    protected $user;

    public function __construct(JenisPrestasi $jenis_prestasi, User $user)
    {
        $this->jenis_prestasi = $jenis_prestasi;
        $this->user = $user;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

This method seems to be duplicated in your project.

    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->jenis_prestasi->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->jenis_prestasi->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('user_id', 'like', $value)
                    ->orWhere('nama', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->with('user')->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */

    public function create()
    {
        $response = [];

        $users_special = $this->user->all();
        $users_standar = $this->user->find(\Auth::User()->id);
        $current_user = \Auth::User();

        $role_check = \Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

This code seems to be duplicated across your project.

            $response['user_special'] = true;
            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }
            $response['user'] = $users_special;
        }else{
            $response['user_special'] = false;
            array_set($users_standar, 'label', $users_standar->name);
            $response['user'] = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['current_user'] = $current_user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Prestasi  $prestasi

There is no parameter named $prestasi. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $jenis_prestasi = $this->jenis_prestasi;

        $validator = Validator::make($request->all(), [
            /*'user_id' => 'required|unique:jenis_prestasis,user_id',*/

67% of this comment could be valid code. Did you maybe forget this after debugging?

            'user_id' => 'required',
            'nama' => 'required',
        ]);

        if($validator->fails()){
            $check = $jenis_prestasi->where('label',$request->label)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed ! Username, already exists';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            } else {

This code seems to be duplicated across your project.

                $jenis_prestasi->user_id = $request->input('user_id');
                $jenis_prestasi->nama = $request->input('nama');
                $jenis_prestasi->save();

                $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            }
        } else {

This code seems to be duplicated across your project.

                $jenis_prestasi->user_id = $request->input('user_id');
                $jenis_prestasi->nama = $request->input('nama');
                $jenis_prestasi->save();

            $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $jenis_prestasi = $this->jenis_prestasi->findOrFail($id);

        $response['user'] = $jenis_prestasi->user;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['jenis_prestasi'] = $jenis_prestasi;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Prestasi  $prestasi
     * @return \Illuminate\Http\Response

There is no parameter named $prestasi. Was it maybe removed?

     */

    public function edit($id)

This method seems to be duplicated in your project.

    {
        $jenis_prestasi = $this->jenis_prestasi->findOrFail($id);

        array_set($jenis_prestasi->user, 'label', $jenis_prestasi->user->name);

        $response['jenis_prestasi'] = $jenis_prestasi;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['user'] = $jenis_prestasi->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Prestasi  $prestasi

There is no parameter named $prestasi. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $response = array();
        $message  = array();
        $jenis_prestasi = $this->jenis_prestasi->findOrFail($id);

            $validator = Validator::make($request->all(), [
                /*'user_id' => 'required|unique:jenis_prestasis,user_id,'.$id,*/

63% of this comment could be valid code. Did you maybe forget this after debugging?

                'user_id' => 'required',
                'nama' => 'required',

            ]);

        if ($validator->fails()) {

            foreach($validator->messages()->getMessages() as $key => $error){
                        foreach($error AS $error_get) {
                            array_push($message, $error_get);
                        }
                    }

             $check_user = $this->jenis_prestasi->where('id','!=', $id)->where('label', $request->label);

             if($check_user->count() > 0){
                  $response['message'] = implode("\n",$message);
            } else {

This code seems to be duplicated across your project.

                $jenis_prestasi->user_id = $request->input('user_id');
                $jenis_prestasi->nama = $request->input('nama');
                $jenis_prestasi->save();

                $response['message'] = 'success';
            }
        } else {

This code seems to be duplicated across your project.

                $jenis_prestasi->user_id = $request->input('user_id');
                $jenis_prestasi->nama = $request->input('nama');
                $jenis_prestasi->save();

            $response['message'] = 'success';
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Prestasi  $prestasi

There is no parameter named $prestasi. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $jenis_prestasi = $this->jenis_prestasi->findOrFail($id);

        if ($jenis_prestasi->delete()) {
            $response['status'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['status'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        return json_encode($response);
    }
}