PrestasiController::update() - Code Metrics - Inspection of "Merge pull request #16 from achmadhadikurnia/maste..." - bantenprov/prestasi - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 4eaaa2...06a8e1 )

unknown
created 2018-04-25 03:06 UTC
PrestasiController::update() A

↳ Parent: PrestasiController
Complexity

Conditions	4
Paths	3
Size

Total Lines	56
Code Lines	34
Duplication

Lines	56
Ratio	100 %
Importance

Changes
Metric	Value
cc	4
eloc	34
nc	3
nop	2
dl	56
loc	56
rs	9.0544
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Bantenprov\Prestasi\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Bantenprov\Prestasi\Facades\PrestasiFacade;

/* Models */
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\Prestasi;
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use App\User;
use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;

/* Etc */
use Validator;
use Auth;

/**
 * The PrestasiController class.
 *
 * @package Bantenprov\Prestasi
 * @author  bantenprov <[email protected]>
 */
class PrestasiController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $prestasi;
    protected $siswa;
    protected $master_prestasi;
    protected $user;
    protected $nilai;

    public function __construct()
    {
        $this->prestasi         = new Prestasi;
        $this->siswa            = new Siswa;
        $this->master_prestasi  = new MasterPrestasi;
        $this->user             = new User;
        $this->nilai            = new Nilai;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->prestasi->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->prestasi->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('nomor_un', 'like', $value)
                    ->orWhere('nama_lomba', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->with('user')->with('master_prestasi')->with('siswa')->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */

    public function create()
    {
        $response = [];

        $master_prestasis = $this->master_prestasi->all();
        $siswas = $this->siswa->all();
        $users_special = $this->user->all();
        $users_standar = $this->user->find(\Auth::User()->id);
        $current_user = \Auth::User();

        $role_check = \Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){

            $response['user_special'] = true;
            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }
            $response['user'] = $users_special;
        }else{
            $response['user_special'] = false;
            array_set($users_standar, 'label', $users_standar->name);
            $response['user'] = $users_standar;
        }

        array_set($current_user, 'label', $current_user->name);

        $response['current_user'] = $current_user;

        foreach($master_prestasis as $master_prestasi){
            if($master_prestasi->juara == 1){
                $juara = "Juara 1";
            }elseif($master_prestasi->juara == 2){
                $juara = "Juara 2";
            }elseif($master_prestasi->juara == 3){
                $juara = "Juara 3";
            }else{
                $juara = "Juara Harapan 1";
            }

            if($master_prestasi->tingkat == 1){
                $tingkat = "Tingkat Internasional";
            }elseif($master_prestasi->tingkat == 2){
                $tingkat = "Tingkat Nasional";
            }elseif($master_prestasi->tingkat == 3){
                $tingkat = "Tingkat Provinsi";
            }else{
                $tingkat = "Tingkat Kabupaten/Kota";
            }

            array_set($master_prestasi, 'label', "( ".$juara." ".$tingkat." ) - ".$master_prestasi->jenis_prestasi->nama);
        }

        foreach($siswas as $siswa){
            array_set($siswa, 'label', $siswa->nama_siswa);
        }

        $response['master_prestasi'] = $master_prestasis;
        $response['siswa'] = $siswas;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)

    {
        $prestasi = $this->prestasi;

        $validator = Validator::make($request->all(), [
            'nomor_un'              => "required|exists:{$this->siswa->getTable()},nomor_un|unique:{$this->prestasi->getTable()},nomor_un,NULL,id,deleted_at,NULL",
            'master_prestasi_id'    => "required|exists:{$this->master_prestasi->getTable()},id",
            'nama_lomba'            => 'required|max:255',
            // 'nilai'             => 'required|numeric|min:0|max:100',

            'user_id'               => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {
            $error                  = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $response['message']    = $validator->errors()->first();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $prestasi_master_prestasi_id    = $request->input('master_prestasi_id');
            $master_prestasi                = $this->master_prestasi->findOrFail($prestasi_master_prestasi_id);

            $prestasi->nomor_un             = $request->input('nomor_un');
            $prestasi->master_prestasi_id   = $prestasi_master_prestasi_id;
            $prestasi->nama_lomba           = $request->input('nama_lomba');
            $prestasi->nilai                = $master_prestasi->nilai;
            $prestasi->user_id              = $request->input('user_id');

            $nilai = $this->nilai->updateOrCreate(
                [
                    'nomor_un'  => $prestasi->nomor_un,
                ],
                [
                    'prestasi'  => $prestasi->nilai,
                    'total'     => null,
                    'user_id'   => $prestasi->user_id,
                ]
            );

            DB::beginTransaction();

            if ($prestasi->save() && $nilai->save())
            {
                DB::commit();

                $error      = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                DB::rollBack();

                $error                  = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $response['message']    = 'Failed';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        $prestasi = $this->prestasi->findOrFail($id);

        $response['user'] = $prestasi->user;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['master_prestasi'] = $prestasi->master_prestasi;
        $response['siswa'] = $prestasi->siswa;
        $response['prestasi'] = $prestasi;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Prestasi  $prestasi
     * @return \Illuminate\Http\Response
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */

    public function edit($id)
    {
        $prestasi = $this->prestasi->findOrFail($id);

        array_set($prestasi->user, 'label', $prestasi->user->name);
        array_set($prestasi->master_prestasi, 'label', $prestasi->master_prestasi->juara);
        array_set($prestasi->siswa, 'label', $prestasi->siswa->nama_siswa);

        $response['master_prestasi'] = $prestasi->master_prestasi;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['siswa'] = $prestasi->siswa;
        $response['prestasi'] = $prestasi;
        $response['user'] = $prestasi->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

    {
        $prestasi = $this->prestasi;

        $validator = Validator::make($request->all(), [
            'nomor_un'              => "required|exists:{$this->siswa->getTable()},nomor_un|unique:{$this->prestasi->getTable()},nomor_un,{$id},id,deleted_at,NULL",
            'master_prestasi_id'    => "required|exists:{$this->master_prestasi->getTable()},id",
            'nama_lomba'            => 'required|max:255',
            // 'nilai'             => 'required|numeric|min:0|max:100',

            'user_id'               => "required|exists:{$this->user->getTable()},id",
        ]);

        if ($validator->fails()) {
            $error                  = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $response['message']    = $validator->errors()->first();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $prestasi_master_prestasi_id    = $request->input('master_prestasi_id');
            $master_prestasi                = $this->master_prestasi->findOrFail($prestasi_master_prestasi_id);

            $prestasi->nomor_un             = $request->input('nomor_un');
            $prestasi->master_prestasi_id   = $prestasi_master_prestasi_id;
            $prestasi->nama_lomba           = $request->input('nama_lomba');
            $prestasi->nilai                = $master_prestasi->nilai;
            $prestasi->user_id              = $request->input('user_id');

            $nilai = $this->nilai->updateOrCreate(
                [
                    'nomor_un'  => $prestasi->nomor_un,
                ],
                [
                    'prestasi'  => $prestasi->nilai,
                    'total'     => null,
                    'user_id'   => $prestasi->user_id,
                ]
            );

            DB::beginTransaction();

            if ($prestasi->save() && $nilai->save())
            {
                DB::commit();

                $error      = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                DB::rollBack();

                $error                  = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $response['message']    = 'Failed';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $prestasi = $this->prestasi->findOrFail($id);

        if ($prestasi->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}

1			<?php
2
3			namespace Bantenprov\Prestasi\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Facades\DB;
9			use Bantenprov\Prestasi\Facades\PrestasiFacade;
10
11			/* Models */
12			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\Prestasi;
13			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
14			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
15			use App\User;
16			use Bantenprov\Nilai\Models\Bantenprov\Nilai\Nilai;
17
18			/* Etc */
19			use Validator;
20			use Auth;
21
22			/**
23			* The PrestasiController class.
24			*
25			* @package Bantenprov\Prestasi
26			* @author bantenprov <[email protected]>
27			*/
28			class PrestasiController extends Controller
29			{
30			/**
31			* Create a new controller instance.
32			*
33			* @return void
34			*/
35			protected $prestasi;
36			protected $siswa;
37			protected $master_prestasi;
38			protected $user;
39			protected $nilai;
40
bantenprov / prestasi

Push — master ( 4eaaa2...06a8e1 )

PrestasiController::update() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
