MasterPrestasiController::update() - Code Metrics - Inspection of "Merge pull request #7 from fadika06/master" - bantenprov/prestasi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9a5d67...747ab4 )

unknown

created 2018-03-30 07:04 UTC

MasterPrestasiController::update() B

↳ Parent: MasterPrestasiController

Complexity

Conditions	5
Paths	7

Size

Total Lines	57
Code Lines	38

Duplication

Lines	14
Ratio	24.56 %

Importance

Changes

Metric	Value
cc	5
eloc	38
nc	7
nop	2
dl	14
loc	57
rs	8.7433
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Bantenprov\Prestasi\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\Prestasi\Facades\PrestasiFacade;

/* Models */
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\JenisPrestasi;
use App\User;

/* Etc */
use Validator;

/**
 * The PrestasiController class.
 *
 * @package Bantenprov\Prestasi
 * @author  bantenprov <[email protected]>
 */
class MasterPrestasiController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $master_prestasi;
    protected $jenis_prestasi;
    protected $user;

    public function __construct(MasterPrestasi $master_prestasi, JenisPrestasi $jenis_prestasi, User $user)
    {
        $this->master_prestasi = $master_prestasi;
        $this->jenis_prestasi = $jenis_prestasi;
        $this->user = $user;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->master_prestasi->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->master_prestasi->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('nilai', 'like', $value)
                    ->orWhere('bobot', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->with('user')->with('jenis_prestasi')->paginate($perPage);


        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */

    public function create()

    {
        $users = $this->user->all();
        $jenis_prestasis = $this->jenis_prestasi->all();

        foreach($users as $user){
            array_set($user, 'label', $user->name);
        }

        foreach($jenis_prestasis as $jenis_prestasi){
            array_set($jenis_prestasi, 'label', $jenis_prestasi->nama_jenis_prestasi);
        }
        
        $response['jenis_prestasi'] = $jenis_prestasis;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['user'] = $users;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $master_prestasi = $this->master_prestasi;

        $validator = Validator::make($request->all(), [
            /*'user_id' => 'required|unique:master_prestasis,user_id',*/

            'user_id' => 'required',
            'jenis_prestasi_id' => 'required',
            'juara' => 'required',
            'tingkat' => 'required',
            'nilai' => 'required',
            'bobot' => 'required',
        ]);

        if($validator->fails()){
            $check = $jenis_prestasi->where('label',$request->label)->whereNull('deleted_at')->count();


            if ($check > 0) {

                $response['message'] = 'Failed ! Username, already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $master_prestasi->jenis_prestasi_id = $request->input('jenis_prestasi_id');
                $master_prestasi->user_id = $request->input('user_id');
                $master_prestasi->juara = $request->input('juara');
                $master_prestasi->tingkat = $request->input('tingkat');
                $master_prestasi->nilai = $request->input('nilai');
                $master_prestasi->bobot = $request->input('bobot');
                $master_prestasi->save();

                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        } else {
                $master_prestasi->jenis_prestasi_id = $request->input('jenis_prestasi_id');
                $master_prestasi->user_id = $request->input('user_id');
                $master_prestasi->juara = $request->input('juara');
                $master_prestasi->tingkat = $request->input('tingkat');
                $master_prestasi->nilai = $request->input('nilai');
                $master_prestasi->bobot = $request->input('bobot');
                $master_prestasi->save();

            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        $master_prestasi = $this->master_prestasi->findOrFail($id);
        
        $response['user'] = $master_prestasi->user;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['jenis_prestasi'] = $master_prestasi->jenis_prestasi;
        $response['master_prestasi'] = $master_prestasi;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Prestasi  $prestasi
     * @return \Illuminate\Http\Response
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */

    public function edit($id)

    {
        $master_prestasi = $this->master_prestasi->findOrFail($id);

        array_set($master_prestasi->user, 'label', $master_prestasi->user->name);
        array_set($master_prestasi->jenis_prestasi, 'label', $master_prestasi->jenis_prestasi->nama_jenis_prestasi);

        $response['master_prestasi'] = $master_prestasi;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['jenis_prestasi'] = $master_prestasi->jenis_prestasi;
        $response['user'] = $master_prestasi->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {   
        $response = array();
        $message  = array();
        $master_prestasi = $this->master_prestasi->findOrFail($id);

            $validator = Validator::make($request->all(), [
                /*'user_id' => 'required|unique:sktms,user_id,'.$id,*/

                'user_id' => 'required',
                'jenis_prestasi_id' => 'required',
                'juara' => 'required',
                'tingkat' => 'required',
                'nilai' => 'required',
                'bobot' => 'required',
                
            ]);

        if ($validator->fails()) {

            foreach($validator->messages()->getMessages() as $key => $error){
                        foreach($error AS $error_get) {
                            array_push($message, $error_get);
                        }                
                    } 

            $check_user = $this->master_prestasi->where('id','!=', $id)->where('label', $request->label);

             if($check_user->count() > 0){

                  $response['message'] = implode("\n",$message);

            } else {
                $master_prestasi->user_id = $request->input('user_id');
                $master_prestasi->jenis_prestasi_id = $request->input('jenis_prestasi_id');
                $master_prestasi->juara = $request->input('juara');
                $master_prestasi->tingkat = $request->input('tingkat');
                $master_prestasi->nilai = $request->input('nilai');
                $master_prestasi->bobot = $request->input('bobot');
                $master_prestasi->save();

                $response['message'] = 'success';
            }
        } else {
                $master_prestasi->user_id = $request->input('user_id');
                $master_prestasi->jenis_prestasi_id = $request->input('jenis_prestasi_id');
                $master_prestasi->juara = $request->input('juara');
                $master_prestasi->tingkat = $request->input('tingkat');
                $master_prestasi->nilai = $request->input('nilai');
                $master_prestasi->bobot = $request->input('bobot');
                $master_prestasi->save();

            $response['message'] = 'success';
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Prestasi  $prestasi
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $master_prestasi = $this->master_prestasi->findOrFail($id);

        if ($master_prestasi->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\Prestasi\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\Prestasi\Facades\PrestasiFacade;
9
10			/* Models */
11			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
12			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\JenisPrestasi;
13			use App\User;
14
15			/* Etc */
16			use Validator;
17
18			/**
19			* The PrestasiController class.
20			*
21			* @package Bantenprov\Prestasi
22			* @author bantenprov <[email protected]>
23			*/
24			class MasterPrestasiController extends Controller
25			{
26			/**
27			* Create a new controller instance.
28			*
29			* @return void
30			*/
31			protected $master_prestasi;
32			protected $jenis_prestasi;
33			protected $user;
34
35			public function __construct(MasterPrestasi $master_prestasi, JenisPrestasi $jenis_prestasi, User $user)
36			{
37			$this->master_prestasi = $master_prestasi;
38			$this->jenis_prestasi = $jenis_prestasi;
39			$this->user = $user;
40			}

bantenprov / prestasi

Push — master ( 9a5d67...747ab4 )

MasterPrestasiController::update() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like