PendaftaranController::update() - Code Metrics - Inspection of "Merge pull request #15 from feripratama/master" - bantenprov/pendaftaran - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad81a8...20ded6 )

unknown

created 2018-03-24 18:48 UTC

PendaftaranController::update() D

↳ Parent: PendaftaranController

Complexity

Conditions	14
Paths	28

Size

Total Lines	94
Code Lines	71

Duplication

Lines	24
Ratio	25.53 %

Importance

Changes

Metric	Value
cc	14
eloc	71
nc	28
nop	2
dl	24
loc	94
rs	4.9516
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Bantenprov\Pendaftaran\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\BudgetAbsorption\Facades\PendaftaranFacade;
use Bantenprov\VueWorkflow\Http\Traits\WorkflowTrait;

/* Models */
use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
use Bantenprov\Kegiatan\Models\Bantenprov\Kegiatan\Kegiatan;
use App\User;

/* Etc */
use Validator;

/**
 * The PendaftaranController class.
 *
 * @package Bantenprov\Pendaftaran
 * @author  bantenprov <[email protected]>
 */
class PendaftaranController extends Controller
{  

    use WorkflowTrait;
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $kegiatanModel;
    protected $pendaftaran;
    protected $user;

    public function __construct(Pendaftaran $pendaftaran, Kegiatan $kegiatan, User $user)
    {
        $this->pendaftaran      = $pendaftaran;
        $this->kegiatanModel    = $kegiatan;
        $this->user             = $user;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->pendaftaran->with('kegiatan')->with('user')->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->pendaftaran->with('kegiatan')->with('user')->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('label', 'like', $value)
                    ->orWhere('description', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $kegiatan = $this->kegiatanModel->all();
        $users_special = $this->user->all();
        $users_standar = $this->user->find(\Auth::User()->id);
        
        $role_check = \Auth::User()->hasRole(['superadministrator','administrator']);

        if($role_check){
            $response['user_special'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            foreach($users_special as $user){
                array_set($user, 'label', $user->name);
            }
            $response['user'] = $users_special;
        }else{
            $response['user_special'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            array_set($users_standar, 'label', $users_standar->name);
            $response['user'] = $users_standar;
        } 

        $response['kegiatan'] = $kegiatan;        
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $pendaftaran = $this->pendaftaran;

        $validator = Validator::make($request->all(), [
            'kegiatan_id' => 'required',
            'user_id' => 'required|max:16|unique:pendaftarans,user_id',
            'label' => 'required|max:16|unique:pendaftarans,label',
            'description' => 'max:255',
        ]);

        if($validator->fails()){

            $check = $pendaftaran->where('label',$request->label)->orWhere('user_id', $request->user_id)->whereNull('deleted_at')->count();

            if ($check > 0) {

                $response['message'] = 'Failed, label or user already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
                $pendaftaran->user_id = $request->input('user_id');
                $pendaftaran->label = $request->input('label');
                $pendaftaran->description = $request->input('description');                
                $pendaftaran->save();

                $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        } else {
            $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
            $pendaftaran->user_id = $request->input('user_id');
            $pendaftaran->label = $request->input('label');
            $pendaftaran->description = $request->input('description');            
            $pendaftaran->save();
            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $pendaftaran = $this->pendaftaran->findOrFail($id);

        $response['pendaftaran'] = $pendaftaran;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['kegiatan'] = $pendaftaran->kegiatan;
        $response['user'] = $pendaftaran->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $pendaftaran = $this->pendaftaran->findOrFail($id);

        array_set($pendaftaran->user, 'label', $pendaftaran->user->name);

        $response['pendaftaran'] = $pendaftaran;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['kegiatan'] = $pendaftaran->kegiatan;
        $response['user'] = $pendaftaran->user;
        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {                
        $pendaftaran = $this->pendaftaran->findOrFail($id);

        if($request->old_label == $request->label && $request->user_id != $request->old_user_id){
            $validator = Validator::make($request->all(), [
                'label' => 'required',
                'description' => 'max:255',
                'kegiatan_id' => 'required',
                'user_id' => 'required|unique:pendaftarans,user_id',
            ]);
            $fail = "user_id";
        }elseif($request->old_label != $request->label && $request->user_id == $request->old_user_id){
            $validator = Validator::make($request->all(), [
                'label' => 'required|unique:pendaftarans,label',
                'description' => 'max:255',
                'kegiatan_id' => 'required',
                'user_id' => 'required',
            ]);
            $fail = "label";
        }elseif($request->old_label == $request->label && $request->user_id == $request->old_user_id){
            $validator = Validator::make($request->all(), [
                'label' => 'required',
                'description' => 'max:255',
                'kegiatan_id' => 'required',
                'user_id' => 'required',
            ]);
        }else{
            $validator = Validator::make($request->all(), [
                'label' => 'required|unique:pendaftarans,label',
                'description' => 'max:255',
                'kegiatan_id' => 'required',
                'user_id' => 'required|unique:pendaftarans,label',
            ]);
            $fail = "label & user_id";
        }

        if ($validator->fails()) {

            $check_user = $pendaftaran->where('user_id', $request->user_id)->whereNull('deleted_at')->count();

            $check_label = $pendaftaran->where('label',$request->label)->whereNull('deleted_at')->count();

            if($fail == "label"){
                if ($check_label > 0) {                    

                    $response['message'] = 'Failed, label already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }else{
                    $pendaftaran->label = $request->input('label');
                    $pendaftaran->description = $request->input('description');
                    $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
                    $pendaftaran->user_id = $request->input('user_id');
                    $pendaftaran->save();

                    $response['message'] = 'success'; 
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }
            }elseif($fail == "user_id"){
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                if ($check_user > 0) {                    
                    $response['message'] = 'Failed, user already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }else{
                    $pendaftaran->label = $request->input('label');
                    $pendaftaran->description = $request->input('description');
                    $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
                    $pendaftaran->user_id = $request->input('user_id');
                    $pendaftaran->save();

                    $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }
            }else{
                if ($check_user > 0 && $check_label > 0) {                    
                    $response['message'] = 'Failed, user and label already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }else{
                    $pendaftaran->label = $request->input('label');
                    $pendaftaran->description = $request->input('description');
                    $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
                    $pendaftaran->user_id = $request->input('user_id');
                    $pendaftaran->save();

                    $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }
            }                       
        } else {
            $pendaftaran->label = $request->input('label');
            $pendaftaran->description = $request->input('description');
            $pendaftaran->kegiatan_id = $request->input('kegiatan_id');
            $pendaftaran->user_id = $request->input('user_id');
            $pendaftaran->save();

            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $pendaftaran = $this->pendaftaran->findOrFail($id);

        if ($pendaftaran->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\Pendaftaran\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\BudgetAbsorption\Facades\PendaftaranFacade;
9			use Bantenprov\VueWorkflow\Http\Traits\WorkflowTrait;
10
11			/* Models */
12			use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
13			use Bantenprov\Kegiatan\Models\Bantenprov\Kegiatan\Kegiatan;
14			use App\User;
15
16			/* Etc */
17			use Validator;
18
19			/**
20			* The PendaftaranController class.
21			*
22			* @package Bantenprov\Pendaftaran
23			* @author bantenprov <[email protected]>
24			*/
25			class PendaftaranController extends Controller
26			{
			0 ignored issues – show Coding Style introduced 2018-03-24 11:51 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
27			use WorkflowTrait;
28			/**
29			* Create a new controller instance.
30			*
31			* @return void
32			*/
33			protected $kegiatanModel;
34			protected $pendaftaran;
35			protected $user;
36
37			public function __construct(Pendaftaran $pendaftaran, Kegiatan $kegiatan, User $user)
38			{
39			$this->pendaftaran = $pendaftaran;

bantenprov / pendaftaran

Push — master ( ad81a8...20ded6 )

PendaftaranController::update() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like