PendaftaranController::show() - Code Metrics - Inspection of "Update PendaftaranController" - bantenprov/pendaftaran - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#35)

unknown
created 2018-05-26 16:39 UTC
PendaftaranController::show() B

↳ Parent: PendaftaranController
Complexity

Conditions	2
Paths	2
Size

Total Lines	113
Code Lines	50
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	2
eloc	50
nc	2
nop	1
dl	0
loc	113
rs	8.2857
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Bantenprov\Pendaftaran\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Carbon\Carbon;
/* Models */
use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
use Bantenprov\Kegiatan\Models\Bantenprov\Kegiatan\Kegiatan;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\AdminSekolah;
use App\User;
use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
use Bantenprov\Sktm\Models\Bantenprov\Sktm\Sktm;
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\JenisPrestasi;
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\Prestasi;
use Bantenprov\Prestasi\Http\Controllers\MasterPrestasiController;

/* Etc */
use Validator;
use Auth;

/**
 * The PendaftaranController class.
 *
 * @package Bantenprov\Pendaftaran
 * @author  bantenprov <[email protected]>
 */
class PendaftaranController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    protected $kegiatanModel;
    protected $pendaftaran;
    protected $user;
    protected $sekolah;
    protected $admin_sekolah;
    protected $siswa;
    protected $mastersktm;
    protected $sktm;
    protected $jenisprestasi;
    protected $masterprestasi;
    protected $masterprestasicont;
    protected $prestasi;

    public function __construct()
    {
        $this->pendaftaran          = new Pendaftaran;
        $this->kegiatanModel        = new Kegiatan;
        $this->user                 = new User;
        $this->sekolah              = new Sekolah;
        $this->admin_sekolah        = new AdminSekolah;
        $this->siswa                = new Siswa;
        $this->sktm                 = new Sktm;
        $this->mastersktm           = new MasterSktm;
        $this->jenisprestasi        = new JenisPrestasi;
        $this->masterprestasi       = new MasterPrestasi;
        $this->masterprestasicont   = new MasterPrestasiController;
        $this->prestasi             = new Prestasi;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();

        if(is_null($admin_sekolah) && $this->checkRole(['superadministrator']) === false){
            $response = [];
            return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
        }else{
            $page  					= 10;
            $data 					= $this->pendaftaran
                                    ->select(
                                        'pendaftarans.id',
                                        'users.name',
                                        'pendaftarans.tanggal_pendaftaran',
                                        'sekolahs.nama',
                                        'kegiatans.label',
                                        'siswas.nama_siswa'
                                    )
                                    ->leftjoin(
                                        'sekolahs',
                                        'pendaftarans.sekolah_id','=','sekolahs.id'
                                    )
                                    ->leftjoin(
                                        'kegiatans',
                                        'pendaftarans.kegiatan_id','=','kegiatans.id'
                                    )
                                    ->leftjoin(
                                        'users',
                                        'pendaftarans.user_id','=','users.id'
                                    )
                                    ->leftjoin(
                                        'siswas',
                                        'users.name','=','siswas.nomor_un'
                                    )
                                    ->where('pendaftarans.sekolah_id','=',$admin_sekolah->sekolah_id)
                                    ->paginate($page);
            return response()->json($data)
                ->header('Access-Control-Allow-Origin', '*')
                ->header('Access-Control-Allow-Methods', 'GET');            
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();

        $pendaftaran        = $this->pendaftaran;
        $current_user_id    = $request->user_id;

        $validator = Validator::make($request->all(), [
            'kegiatan_id'           => 'required',
            'user_id'               => "required|exists:{$this->user->getTable()},id",
            'tanggal_pendaftaran'   => 'required',
            'sekolah_id'            => 'required',
        ]);

        if($admin_sekolah->sekolah_id != $request->sekolah_id && $this->checkRole(['superadministrator']) === false){
            $response['error']      = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['message']    = 'Terjadi kesalahan, mohon ulangi lagi pengisian data yang benar.';
            $response['status']     = true;

            return response()->json($response);
        }

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();

            } else {
                $pendaftaran->kegiatan_id           = $request->input('kegiatan_id');
                $pendaftaran->user_id               = $current_user_id;
                $pendaftaran->tanggal_pendaftaran   = $request->input('tanggal_pendaftaran');
                $pendaftaran->sekolah_id            = $request->input('sekolah_id');
                $pendaftaran->save();
                $error      = false;
                $message    = 'Success';
            }

        $response['error']      = $error;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {

        // $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();

        // if($this->checkRole(['superadministrator'])){

        //     $pendaftaran = $this->pendaftaran->findOrFail($id);

        // }else{
        //     $pendaftaran = $this->pendaftaran->where('sekolah_id', $admin_sekolah->sekolah_id)->findOrFail($id);

        // }
        


        $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if($this->checkRole(['superadministrator'])){
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
//            $pendaftaran = $this->pendaftaran->findOrFail($id);

        }else{
            $data 					= $this->pendaftaran
                                    ->select(
                                        'siswas.nama_siswa',
                                        'kegiatans.label as jenis_pendaftaran',
                                        'pendaftarans.id',
                                        'users.name',
                                        'pendaftarans.tanggal_pendaftaran',
                                        'sekolahs.nama as sekolah_tujuan',
                                        'master_sktms.nama as jenis_sktm',
                                        'sktms.no_sktm',
                                        'prestasis.nama_lomba',
                                        'jenis_prestasis.nama as jenis_prestasi',
                                        'master_prestasis.juara',
                                        'master_prestasis.tingkat'                                        
                                    )
                                    ->leftjoin(
                                        'sekolahs',
                                        'pendaftarans.sekolah_id','=','sekolahs.id'
                                    )
                                    ->leftjoin(
                                        'kegiatans',
                                        'pendaftarans.kegiatan_id','=','kegiatans.id'
                                    )
                                    ->leftjoin(
                                        'users',
                                        'pendaftarans.user_id','=','users.id'
                                    )
                                    ->leftjoin(
                                        'siswas',
                                        'users.name','=','siswas.nomor_un'
                                    )
                                    ->leftjoin(
                                        'sktms',
                                        'pendaftarans.nomor_un','=','sktms.nomor_un'
                                    )                                    
                                    ->leftjoin(
                                        'master_sktms',
                                        'sktms.master_sktm_id','=','master_sktms.id'
                                    )                                    
                                    ->leftjoin(
                                        'prestasis',
                                        'pendaftarans.nomor_un','=','prestasis.nomor_un'
                                    )
                                    ->leftjoin(
                                        'master_prestasis',
                                        'prestasis.master_prestasi_id','=','master_prestasis.id'
                                    )
                                    ->leftjoin(
                                        'jenis_prestasis',
                                        'master_prestasis.jenis_prestasi_id','=','jenis_prestasis.id'
                                    )
                                    ->where('pendaftarans.id','=',$id)
                                    ->first();
                // $result         = array();

                // foreach((array)$data as $key => $val){

                //     if($key == '*attributes'){

                //         dd($val);

                //         foreach($val as $key1 => $val1){

                //             if($key1 == 'juara'){

                //                 $result['juara']    = $this->masterprestasi->prestasi_label($val1);

                //             }elseif($key1 == 'tingkat'){

                //                 $result['tingkat']  = $this->masterprestasi->tingkat_label($val1);

                //             }else{
                //                 $result[$key1]      = $val1;

                //             }
                //         }
                //     }
                // }
                return response()->json($data)
                    ->header('Access-Control-Allow-Origin', '*')
                    ->header('Access-Control-Allow-Methods', 'GET');            
        }

        // $response['pendaftaran']    = $pendaftaran;

        // $response['kegiatan']       = $pendaftaran->kegiatan;

        // $response['sekolah']        = $pendaftaran->sekolah;

        // $response['user']           = $pendaftaran->user;

        // $response['siswa']          = $pendaftaran->siswa;

        // /*
        // // $response['prestasi']       = $pendaftaran->sekolah;
        // // $response['sktm']          = $pendaftaran->sekolah;
        // */

        // $response['nama_siswa']             = $data->nama_siswa;

        // $response['jenis_pendaftaran']      = $data->label;

        // $response['sekolah_tujuan']         = $data->nama;

        // $response['tanggal_pendaftaran']    = $data->tanggal_pendaftaran;

        // $response['jenis_sktm']             = $data->nama;

        // $response['no_sktm']                = $data->no_sktm;

        // $response['prestasi']               = $data->nama_lomba;

        // $response['jenis_prestasi']         = $data->nama;

        // $response['juara']                  = $data->juara;

        // $response['tingkat']                = $data->tingkat;

        // $response['status']                 = true;

        // return response()->json($response);

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();

        if($this->checkRole(['superadministrator'])){
            $pendaftaran = $this->pendaftaran->with(['kegiatan', 'sekolah', 'user' ])->findOrFail($id);
        }else{
            $pendaftaran = $this->pendaftaran->where('sekolah_id', $admin_sekolah->sekolah_id)->with(['kegiatan', 'sekolah', 'user' ])->findOrFail($id);
        }


        $response['pendaftaran']['user']     = array_add($pendaftaran->user, 'label', $pendaftaran->user->name);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}



        $response['pendaftaran']    = $pendaftaran;
        //$response['kegiatan']       = $pendaftaran->kegiatan;

        //$response['sekolah']        = $pendaftaran->sekolah->nama;

        //$response['user']           = $pendaftaran->user;

        $response['error']          = false;
        $response['message']        = 'Success';
        $response['status']         = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $admin_sekolah = $this->admin_sekolah->where('admin_sekolah_id', Auth::user()->id)->first();

        if($this->checkRole(['superadministrator'])){
            $pendaftaran = $this->pendaftaran->with(['kegiatan', 'sekolah', 'user' ])->findOrFail($id);
        }else{
            $pendaftaran = $this->pendaftaran->where('sekolah_id', $admin_sekolah->sekolah_id)->with(['kegiatan', 'sekolah', 'user' ])->findOrFail($id);

            if(is_null($pendaftaran)){
                $response['error']      = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $response['message']    = 'Terjadi kesalahan saat update data.';
                $response['status']     = true;

                return response()->json($response);
            }
        }


        $validator = Validator::make($request->all(), [
            'kegiatan_id'           => 'required',
            'tanggal_pendaftaran'   => 'required',
            'sekolah_id'            => 'required',
        ]);

        if ($validator->fails()) {

            $error      = true;
            $message    = $validator->errors()->first();

        } else {
            $pendaftaran->kegiatan_id           = $request->input('kegiatan_id');
            $pendaftaran->tanggal_pendaftaran   = $request->input('tanggal_pendaftaran');
            $pendaftaran->sekolah_id            = $request->input('sekolah_id');
            $pendaftaran->save();

            $error      = false;
            $message    = 'Success';
        }

        $response['error']      = $error;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['message']    = $message;
        $response['status']     = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Pendaftaran  $pendaftaran
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if(!$this->checkRole(['superadministrator'])){
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            return json_encode($response);
        }

        $pendaftaran = $this->pendaftaran->findOrFail($id);

        if ($pendaftaran->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }

    protected function checkRole($role = array())
    {
        return Auth::user()->hasRole($role);
    }    
}

1			<?php
2
3			namespace Bantenprov\Pendaftaran\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Carbon\Carbon;
9			/* Models */
10			use Bantenprov\Pendaftaran\Models\Bantenprov\Pendaftaran\Pendaftaran;
11			use Bantenprov\Kegiatan\Models\Bantenprov\Kegiatan\Kegiatan;
12			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\Sekolah;
13			use Bantenprov\Sekolah\Models\Bantenprov\Sekolah\AdminSekolah;
14			use App\User;
15			use Bantenprov\Siswa\Models\Bantenprov\Siswa\Siswa;
16			use Bantenprov\Sktm\Models\Bantenprov\Sktm\MasterSktm;
17			use Bantenprov\Sktm\Models\Bantenprov\Sktm\Sktm;
18			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\JenisPrestasi;
19			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\MasterPrestasi;
20			use Bantenprov\Prestasi\Models\Bantenprov\Prestasi\Prestasi;
21			use Bantenprov\Prestasi\Http\Controllers\MasterPrestasiController;
22
23			/* Etc */
24			use Validator;
25			use Auth;
26
27			/**
28			* The PendaftaranController class.
29			*
30			* @package Bantenprov\Pendaftaran
31			* @author bantenprov <[email protected]>
32			*/
33			class PendaftaranController extends Controller
34			{
35			/**
36			* Create a new controller instance.
37			*
38			* @return void
39			*/
40			protected $kegiatanModel;
bantenprov / pendaftaran

Pull Request — master (#35)

PendaftaranController::show() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
