| Conditions | 14 | 
| Paths | 28 | 
| Total Lines | 85 | 
| Code Lines | 72 | 
| Lines | 22 | 
| Ratio | 25.88 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 204 | public function update(Request $request, $id)  | 
            ||
| 205 |     {       | 
            ||
| 206 | $response = [];  | 
            ||
| 207 | |||
| 208 | $pendaftaran = $this->pendaftaran->findOrFail($id);  | 
            ||
| 209 |         if($request->old_label == $request->label && $request->user_id != $request->old_user_id){ | 
            ||
| 210 | $validator = Validator::make($request->all(), [  | 
            ||
| 211 | 'label' => 'required',  | 
            ||
| 212 | 'description' => 'max:255',  | 
            ||
| 213 | 'kegiatan_id' => 'required',  | 
            ||
| 214 | 'user_id' => 'required|unique:pendaftarans,user_id',  | 
            ||
| 215 | ]);  | 
            ||
| 216 | $fail = "user_id";  | 
            ||
| 217 |         }elseif($request->old_label != $request->label && $request->user_id == $request->old_user_id){ | 
            ||
| 218 | $validator = Validator::make($request->all(), [  | 
            ||
| 219 | 'label' => 'required|unique:pendaftarans,label',  | 
            ||
| 220 | 'description' => 'max:255',  | 
            ||
| 221 | 'kegiatan_id' => 'required',  | 
            ||
| 222 | 'user_id' => 'required',  | 
            ||
| 223 | ]);  | 
            ||
| 224 | $fail = "label";  | 
            ||
| 225 |         }elseif($request->old_label == $request->label && $request->user_id == $request->old_user_id){ | 
            ||
| 226 | $validator = Validator::make($request->all(), [  | 
            ||
| 227 | 'label' => 'required',  | 
            ||
| 228 | 'description' => 'max:255',  | 
            ||
| 229 | 'kegiatan_id' => 'required',  | 
            ||
| 230 | 'user_id' => 'required',  | 
            ||
| 231 | ]);  | 
            ||
| 232 |         }else{ | 
            ||
| 233 | $validator = Validator::make($request->all(), [  | 
            ||
| 234 | 'label' => 'required|unique:pendaftarans,label',  | 
            ||
| 235 | 'description' => 'max:255',  | 
            ||
| 236 | 'kegiatan_id' => 'required',  | 
            ||
| 237 | 'user_id' => 'required|unique:pendaftarans,label',  | 
            ||
| 238 | ]);  | 
            ||
| 239 | $fail = "label & user_id";  | 
            ||
| 240 | }  | 
            ||
| 241 |         if ($validator->fails()) { | 
            ||
| 242 |             $check_user = $pendaftaran->where('user_id', $request->user_id)->whereNull('deleted_at')->count(); | 
            ||
| 243 |             $check_label = $pendaftaran->where('label',$request->label)->whereNull('deleted_at')->count(); | 
            ||
| 244 |             if($fail == "label"){ | 
            ||
| 245 | View Code Duplication |                 if ($check_label > 0) {                     | 
            |
| 246 | $response['message'] = 'Failed, label already exists';  | 
            ||
| 247 |                 }else{ | 
            ||
| 248 |                     $pendaftaran->label = $request->input('label'); | 
            ||
| 249 |                     $pendaftaran->description = $request->input('description'); | 
            ||
| 250 |                     $pendaftaran->kegiatan_id = $request->input('kegiatan_id'); | 
            ||
| 251 |                     $pendaftaran->user_id = $request->input('user_id'); | 
            ||
| 252 | $pendaftaran->save();  | 
            ||
| 253 | $response['message'] = 'success';  | 
            ||
| 254 | }  | 
            ||
| 255 | View Code Duplication |             }elseif($fail == "user_id"){ | 
            |
| 256 |                 if ($check_user > 0) {                     | 
            ||
| 257 | $response['message'] = 'Failed, user already exists';  | 
            ||
| 258 |                 }else{ | 
            ||
| 259 |                     $pendaftaran->label = $request->input('label'); | 
            ||
| 260 |                     $pendaftaran->description = $request->input('description'); | 
            ||
| 261 |                     $pendaftaran->kegiatan_id = $request->input('kegiatan_id'); | 
            ||
| 262 |                     $pendaftaran->user_id = $request->input('user_id'); | 
            ||
| 263 | $pendaftaran->save();  | 
            ||
| 264 | $response['message'] = 'success';  | 
            ||
| 265 | }  | 
            ||
| 266 |             }else{ | 
            ||
| 267 |                 if ($check_user > 0 && $check_label > 0) {                     | 
            ||
| 268 | $response['message'] = 'Failed, user and label already exists';  | 
            ||
| 269 |                 }else{ | 
            ||
| 270 |                     $pendaftaran->label = $request->input('label'); | 
            ||
| 271 |                     $pendaftaran->description = $request->input('description'); | 
            ||
| 272 |                     $pendaftaran->kegiatan_id = $request->input('kegiatan_id'); | 
            ||
| 273 |                     $pendaftaran->user_id = $request->input('user_id'); | 
            ||
| 274 | $pendaftaran->save();  | 
            ||
| 275 | $response['message'] = 'success';  | 
            ||
| 276 | }  | 
            ||
| 277 | }  | 
            ||
| 278 |         } else { | 
            ||
| 279 |             $pendaftaran->label = $request->input('label'); | 
            ||
| 280 |             $pendaftaran->description = $request->input('description'); | 
            ||
| 281 |             $pendaftaran->kegiatan_id = $request->input('kegiatan_id'); | 
            ||
| 282 |             $pendaftaran->user_id = $request->input('user_id'); | 
            ||
| 283 | $pendaftaran->save();  | 
            ||
| 284 | $response['message'] = 'success';  | 
            ||
| 285 | }  | 
            ||
| 286 | $response['status'] = true;  | 
            ||
| 287 | return response()->json($response);  | 
            ||
| 288 | }  | 
            ||
| 289 | |||
| 309 |