Bantenprov\OrangTua\Http\Controllers\OrangTuaController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	177
Duplicated Lines	29.38 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	index()	0	25	4
A	create()	0	12	1
B	store()	11	25	2
A	show()	9	9	1
A	edit()	9	9	1
B	update()	11	25	2
A	destroy()	12	12	2

<?php

namespace Bantenprov\OrangTua\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\OrangTua\Facades\OrangTuaFacade;

/* Models */
use Bantenprov\OrangTua\Models\Bantenprov\OrangTua\OrangTua;

/* Etc */
use Validator;

/**
 * The OrangTuaController class.
 *
 * @package Bantenprov\OrangTua
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class OrangTuaController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(OrangTua $orang_tua)
    {
        $this->orang_tua = $orang_tua;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if ($request->has('sort')) {
            list($sortCol, $sortDir) = explode('|', $request->sort);

            $query = $this->orang_tua->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->orang_tua->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('label', 'like', $value)
                    ->orWhere('description', 'like', $value);
            });
        }

        $perPage = $request->has('per_page') ? (int) $request->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $orang_tua              = $this->orang_tua;
        $orang_tua->id          = null;
        $orang_tua->label       = null;
        $orang_tua->description = null;

        $response['orang_tua'] = $orang_tua;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\OrangTua  $orang_tua

There is no parameter named $orang_tua. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $orang_tua = $this->orang_tua;

        $validator = Validator::make($request->all(), [
            'label'         => 'required|max:16|unique:orang_tuas,label,NULL,id,deleted_at,NULL',
            'description'   => 'required|max:255',
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            $response['error']  = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = $validator->errors()->first();
        } else {
            $orang_tua->label       = $request->label;
            $orang_tua->description = $request->description;
            $orang_tua->save();

            $response['error'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = 'Success';
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        $response['orang_tua'] = $orang_tua;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\OrangTua  $orang_tua

There is no parameter named $orang_tua. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        $response['orang_tua'] = $orang_tua;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\OrangTua  $orang_tua

There is no parameter named $orang_tua. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'label'         => 'required|max:16|unique:orang_tuas,label,'.$id.',id,deleted_at,NULL',
            'description'   => 'required|max:255',
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            $response['error']  = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = $validator->errors()->first();
        } else {
            $orang_tua->label       = $request->label;
            $orang_tua->description = $request->description;
            $orang_tua->save();

            $response['error'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['message'] = 'Success';
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\OrangTua  $orang_tua

There is no parameter named $orang_tua. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        if ($orang_tua->delete()) {
            $response['loaded'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['loaded'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        return json_encode($response);
    }
}