OrangTuaController::update() - Code Metrics - Inspection of "Merge pull request #5 from fadika06/master" - bantenprov/orang-tua - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9fc5d7...b12892 )

unknown

created 2018-03-30 07:04 UTC

OrangTuaController::update() C

↳ Parent: OrangTuaController

Complexity

Conditions	8
Paths	7

Size

Total Lines	73
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	56
nc	7
nop	2
dl	0
loc	73
rs	6.3384
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Bantenprov\OrangTua\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\OrangTua\Facades\OrangTuaFacade;

/* Models */
use Bantenprov\OrangTua\Models\Bantenprov\OrangTua\OrangTua;
use App\User;

/* Etc */
use Validator;

/**
 * The OrangTuaController class.
 *
 * @package Bantenprov\OrangTua
 * @author  bantenprov <[email protected]>
 */
class OrangTuaController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */

     protected $orang_tua;
     protected $user;

    public function __construct(OrangTua $orang_tua, User $user)
    {
        $this->orang_tua = $orang_tua;
        $this->user = $user;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if ($request->has('sort')) {
            list($sortCol, $sortDir) = explode('|', $request->sort);

            $query = $this->orang_tua->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->orang_tua->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
               $value = "%{$request->filter}%";
                $q->where('nomor_un', 'like', $value)
                  ->orWhere('no_kk', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->with('user')->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $users = $this->user->all();

        foreach($users as $user){
            array_set($user, 'label', $user->name);
        }

        $response['user'] = $users;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\OrangTua  $orang_tua
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $orang_tua = $this->orang_tua;

        $validator = Validator::make($request->all(), [
            'user_id' => 'required|unique:orangtuas,user_id',
            'nomor_un'   => 'required|unique:orangtuas,nomor_un',
            'no_kk'   => 'required|unique:orangtuas,no_kk',
            'no_telp'   => 'required|unique:orangtuas,no_telp',
            'nama_ayah'   => 'required',
            'nama_ibu'   => 'required',
            'pendidikan_ayah'   => 'required',
            'kerja_ayah'   => 'required',
            'pendidikan_ibu'   => 'required',
            'kerja_ibu'   => 'required',
            'alamat_ortu'   => 'required',
        ]);

        if($validator->fails()){
            $check = $orang_tua->where('user_id',$request->user_id)->orWhere('nomor_un',$request->nomor_un)->orWhere('no_kk',$request->no_kk)->orWhere('no_telp',$request->no_telp)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed ! Username, Nomor UN, Nomor KK, Nomor Telp already exists';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {

            $orang_tua->user_id = $request->input('user_id');
            $orang_tua->nomor_un = $request->input('nomor_un');
            $orang_tua->no_kk = $request->input('no_kk');
            $orang_tua->no_telp = $request->input('no_telp');
            $orang_tua->nama_ayah = $request->input('nama_ayah');
            $orang_tua->nama_ibu = $request->input('nama_ibu');
            $orang_tua->pendidikan_ayah = $request->input('pendidikan_ayah');
            $orang_tua->kerja_ayah = $request->input('kerja_ayah');
            $orang_tua->pendidikan_ibu = $request->input('pendidikan_ibu');
            $orang_tua->kerja_ibu = $request->input('kerja_ibu');
            $orang_tua->alamat_ortu = $request->input('alamat_ortu');
            $orang_tua->save();

            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }

            } else {

            $orang_tua->user_id = $request->input('user_id');
            $orang_tua->nomor_un = $request->input('nomor_un');
            $orang_tua->no_kk = $request->input('no_kk');
            $orang_tua->no_telp = $request->input('no_telp');
            $orang_tua->nama_ayah = $request->input('nama_ayah');
            $orang_tua->nama_ibu = $request->input('nama_ibu');
            $orang_tua->pendidikan_ayah = $request->input('pendidikan_ayah');
            $orang_tua->kerja_ayah = $request->input('kerja_ayah');
            $orang_tua->pendidikan_ibu = $request->input('pendidikan_ibu');
            $orang_tua->kerja_ibu = $request->input('kerja_ibu');
            $orang_tua->alamat_ortu = $request->input('alamat_ortu');
            $orang_tua->save();
            $response['message'] = 'success';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        $orang_tua = $this->orang_tua->findOrFail($id);
        
        $response['user'] = $orang_tua->user;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['orang_tua'] = $orang_tua;
        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\OrangTua  $orang_tua
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        array_set($orang_tua->user, 'label', $orang_tua->user->name);
        
        $response['user'] = $orang_tua->user;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['orang_tua'] = $orang_tua;
        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\OrangTua  $orang_tua
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {   
        $response = array();
        $message  = array();
        $orang_tua = $this->orang_tua->findOrFail($id);

        $validator = Validator::make($request->all(), [
            'user_id' => 'required|unique:orangtuas,user_id,'.$id,
            'nomor_un'   => 'required |unique:orangtuas,nomor_un,'.$id,
            'no_kk'   => 'required|unique:orangtuas,no_kk,'.$id,
            'no_telp'   => 'required|unique:orangtuas,no_telp,'.$id,
            'nama_ayah'   => 'required',
            'nama_ibu'   => 'required',
            'pendidikan_ayah'   => 'required',
            'kerja_ayah'   => 'required',
            'pendidikan_ibu'   => 'required',
            'kerja_ibu'   => 'required',
            'alamat_ortu'   => 'required',
        ]);

        if ($validator->fails()) {

            foreach($validator->messages()->getMessages() as $key => $error){
                        foreach($error AS $error_get) {
                            array_push($message, $error_get);
                        }                
                    } 

             $check_user     = $this->orang_tua->where('id','!=', $id)->where('user_id', $request->user_id);
             $check_nomor_un = $this->orang_tua->where('id','!=', $id)->where('nomor_un', $request->nomor_un);
             $check_no_kk = $this->orang_tua->where('id','!=', $id)->where('no_kk', $request->no_kk);
             $check_no_telp = $this->orang_tua->where('id','!=', $id)->where('no_telp', $request->no_telp);

             if($check_user->count() > 0 || $check_nomor_un->count() > 0 || $check_no_kk->count() > 0 || $check_no_telp->count() > 0){
                  $response['message'] = implode("\n",$message);
        } else {
            $orang_tua->user_id    = $request->input('user_id');
            $orang_tua->nomor_un = $request->input('nomor_un');
            $orang_tua->no_kk = $request->input('no_kk');
            $orang_tua->no_telp = $request->input('no_telp');
            $orang_tua->nama_ayah = $request->input('nama_ayah');
            $orang_tua->nama_ibu = $request->input('nama_ibu');
            $orang_tua->pendidikan_ayah = $request->input('pendidikan_ayah');
            $orang_tua->kerja_ayah = $request->input('kerja_ayah');
            $orang_tua->pendidikan_ibu = $request->input('pendidikan_ibu');
            $orang_tua->kerja_ibu = $request->input('kerja_ibu');
            $orang_tua->alamat_ortu = $request->input('alamat_ortu');
            $orang_tua->save();

            $response['message'] = 'success';

          }
        } else {
            $orang_tua->user_id    = $request->input('user_id');
            $orang_tua->nomor_un = $request->input('nomor_un');
            $orang_tua->no_kk = $request->input('no_kk');
            $orang_tua->no_telp = $request->input('no_telp');
            $orang_tua->nama_ayah = $request->input('nama_ayah');
            $orang_tua->nama_ibu = $request->input('nama_ibu');
            $orang_tua->pendidikan_ayah = $request->input('pendidikan_ayah');
            $orang_tua->kerja_ayah = $request->input('kerja_ayah');
            $orang_tua->pendidikan_ibu = $request->input('pendidikan_ibu');
            $orang_tua->kerja_ibu = $request->input('kerja_ibu');
            $orang_tua->alamat_ortu = $request->input('alamat_ortu');
            $orang_tua->save();

            $response['message'] = 'success';
        }

        $response['loaded'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\OrangTua  $orang_tua
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

    {
        $orang_tua = $this->orang_tua->findOrFail($id);

        if ($orang_tua->delete()) {
            $response['status'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        } else {
            $response['status'] = false;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return json_encode($response);
    }
}


1			<?php
2
3			namespace Bantenprov\OrangTua\Http\Controllers;
4
5			/* Require */
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Bantenprov\OrangTua\Facades\OrangTuaFacade;
9
10			/* Models */
11			use Bantenprov\OrangTua\Models\Bantenprov\OrangTua\OrangTua;
12			use App\User;
13
14			/* Etc */
15			use Validator;
16
17			/**
18			* The OrangTuaController class.
19			*
20			* @package Bantenprov\OrangTua
21			* @author bantenprov <[email protected]>
22			*/
23			class OrangTuaController extends Controller
24			{
25			/**
26			* Create a new controller instance.
27			*
28			* @return void
29			*/
30
31			protected $orang_tua;
32			protected $user;
33
34			public function __construct(OrangTua $orang_tua, User $user)
35			{
36			$this->orang_tua = $orang_tua;
37			$this->user = $user;
38			}
39
40			/**

bantenprov / orang-tua

Push — master ( 9fc5d7...b12892 )

OrangTuaController::update() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like