| Conditions | 5 |
| Paths | 5 |
| Total Lines | 88 |
| Code Lines | 60 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 107 | public function store(Request $request) |
||
| 108 | { |
||
| 109 | $akademik = $this->akademik; |
||
| 110 | |||
| 111 | $bahasa_indonesia = $request->bahasa_indonesia; |
||
| 112 | $bahasa_inggris = $request->bahasa_inggris; |
||
| 113 | $matematika = $request->matematika; |
||
| 114 | $ipa = $request->ipa; |
||
| 115 | |||
| 116 | $total_nialai_akademik = $bahasa_indonesia + $bahasa_inggris + $matematika + $ipa; |
||
| 117 | |||
| 118 | $validator = Validator::make($request->all(), [ |
||
| 119 | 'user_id' => 'required|unique:akademiks,user_id', |
||
| 120 | 'siswa_id' => 'required|unique:akademiks,siswa_id', |
||
| 121 | 'bahasa_indonesia' => 'required', |
||
| 122 | 'bahasa_inggris' => 'required', |
||
| 123 | 'matematika' => 'required', |
||
| 124 | 'ipa' => 'required' |
||
| 125 | ]); |
||
| 126 | |||
| 127 | if($validator->fails()){ |
||
| 128 | $check = $akademik->where('user_id',$request->user_id)->orWhere('siswa_id',$request->siswa_id)->whereNull('deleted_at')->count(); |
||
| 129 | |||
| 130 | if ($check > 0) { |
||
| 131 | $response['message'] = 'Failed ! Username, Nama Siswa, already exists'; |
||
| 132 | } else { |
||
| 133 | $akademik->user_id = $request->input('user_id'); |
||
| 134 | $akademik->bahasa_indonesia = $request->input('bahasa_indonesia'); |
||
| 135 | $akademik->siswa_id = $request->input('siswa_id'); |
||
| 136 | $akademik->bahasa_inggris = $request->input('bahasa_inggris'); |
||
| 137 | $akademik->matematika = $request->input('matematika'); |
||
| 138 | $akademik->ipa = $request->input('ipa'); |
||
| 139 | $akademik->save(); |
||
| 140 | |||
| 141 | |||
| 142 | $check_akademik = $this->nilai->where('siswa_id', $request->input('siswa_id')); |
||
| 143 | if($check_akademik->count() > 0){ |
||
| 144 | $this->nilai->where('siswa_id', $request->input('siswa_id'))->update([ |
||
| 145 | 'user_id' => $request->input('user_id'), |
||
| 146 | 'siswa_id' => $request->input('siswa_id'), |
||
| 147 | 'akademik' => $total_nialai_akademik |
||
| 148 | ]); |
||
| 149 | }else{ |
||
| 150 | $this->nilai->create([ |
||
| 151 | 'user_id' => $request->input('user_id'), |
||
| 152 | 'siswa_id' => $request->input('siswa_id'), |
||
| 153 | 'akademik' => $total_nialai_akademik |
||
| 154 | ]); |
||
| 155 | } |
||
| 156 | |||
| 157 | |||
| 158 | $response['message'] = 'success'; |
||
| 159 | } |
||
| 160 | } else { |
||
| 161 | //$akademik->user_id = $request->input('user_id'); |
||
| 162 | $akademik->user_id = $request->input('user_id'); |
||
| 163 | $akademik->bahasa_indonesia = $request->input('bahasa_indonesia'); |
||
| 164 | $akademik->siswa_id = $request->input('siswa_id'); |
||
| 165 | $akademik->bahasa_inggris = $request->input('bahasa_inggris'); |
||
| 166 | $akademik->matematika = $request->input('matematika'); |
||
| 167 | $akademik->ipa = $request->input('ipa'); |
||
| 168 | $akademik->save(); |
||
| 169 | |||
| 170 | $check_akademik = $this->nilai->where('siswa_id', $request->input('siswa_id')); |
||
| 171 | if($check_akademik->count() > 0){ |
||
| 172 | $this->nilai->where('siswa_id', $request->input('siswa_id'))->update([ |
||
| 173 | 'user_id' => $request->input('user_id'), |
||
| 174 | 'siswa_id' => $request->input('siswa_id'), |
||
| 175 | 'akademik' => $total_nialai_akademik |
||
| 176 | ]); |
||
| 177 | }else{ |
||
| 178 | $this->nilai->create([ |
||
| 179 | 'user_id' => $request->input('user_id'), |
||
| 180 | 'siswa_id' => $request->input('siswa_id'), |
||
| 181 | 'akademik' => $total_nialai_akademik |
||
| 182 | ]); |
||
| 183 | } |
||
| 184 | |||
| 185 | |||
| 186 | |||
| 187 | |||
| 188 | $response['message'] = 'success'; |
||
| 189 | } |
||
| 190 | |||
| 191 | $response['status'] = true; |
||
| 192 | |||
| 193 | return response()->json($response); |
||
| 194 | } |
||
| 195 | |||
| 344 |
If you implement
__calland you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class.This is often the case, when
__callis implemented by a parent class and only the child class knows which methods exist: