HostkeysController::get() - Code Metrics - Inspection of "Merge pull request #28 from etanasia/master" - bantenprov/laravel-api-manager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c69a04...dc1454 )

unknown

created 2018-01-02 16:18 UTC

HostkeysController::get() B

↳ Parent: HostkeysController

Complexity

Conditions	2
Paths	3

Size

Total Lines	37
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	37
rs	8.8571
cc	2
eloc	32
nc	3
nop	1

<?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Hostkeys;
use That0n3guy\Transliteration;

use GuzzleHttp\Exception\GuzzleException;
use GuzzleHttp\Client;
use GuzzleHttp\Pool;
use GuzzleHttp\Psr7;
use Auth;

use Validator, Image, Session, File, Response, Redirect, Exception;

class HostkeysController extends Controller
{

  /**
   * Display a listing of the resource.
   *
   * @return Response
   */
  public function index(Request $request)
  {
      try {
        if($request->get('search') != ''){
          $data['data']	= Hostkeys::with('getState')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->where('hostname', 'like', '%'.$request->get('search').'%')
                                 ->orderBy('id', 'desc')
                                 ->paginate(env('PAGINATE', 10));
        } else{
          $data['data']	= Hostkeys::with('getState')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->orderBy('id', 'desc')
                                 ->paginate(env('PAGINATE', 10));
        }
      } catch (Exception $e) {
          $data['data']	= [];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
      }
      return view('host_keys.index', $data);
  }

  /**
   * Show the form for creating a new resource.
   *
   * @return Response
   */
  public function create()
  {

  }

  /**
   * Store a newly created resource in storage.
   *
   * @return Response
   */
  public function store(Request $request)

  {
      try {
          $token 		= $request->keys;
          $hostkey = New Hostkeys;
          $hostkey->hostname 			= str_replace(array('https://', 'http://'), array('',''),$request->hostname);
          $hostkey->keys 			= $token;
          $hostkey->state 		= $request->state;
          $hostkey->transition 		= $request->transition;
          $hostkey->user_id           = $request->user_id;
          if($request->state == 'Approved' || $request->state == 'Rejected'){
            $hostkey->save();

            $error = false;
            $statusCode = 200;
            $title = 'Success';
            $type = 'success';
            $message = 'Data Saved Successfuly.';
            $result = $hostkey;
          }else {
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Error';
              $result = 'Not Found';
          }
      } catch (Exception $e) {
          $error = true;
          $statusCode = 404;
          $title = 'Error';
          $type = 'error';
          $message = 'Error';
          $result = 'Not Found';
      } finally {
          return Response::json(array(
            'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'result' => $result
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
          ));
      }
  }

  /**
   * Display the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function show($id)
  {

  }

  public function get($hostname)
  {
      try {
          $data	= Hostkeys::with('getState')
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->where('hostname', 'like', '%'.$hostname.'%')
                                 ->orderBy('id', 'desc')
                                 ->first();

           $error = false;
           $statusCode = 200;
           $title = 'Success';
           $type = 'success';
           $message = 'Success';
           $result = $data->hostname;
           $resultid = $data->id;
      } catch (Exception $e) {
          $error = true;
          $statusCode = 404;
          $title = 'Error';
          $type = 'error';
          $message = 'Error';
          $result = 'Not Found';
          $resultid = 'Not Found';
      } finally {
          return Response::json(array(
            'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'result' => $result,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'id' => $resultid
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
          ));
      }
  }

  public function request(Request $request){
      if(Auth::guest()){ $current_user = 1; }
      else{ $current_user = Auth::user()->id; }
      $headers = ['Content-Type' => 'application/json'];
      $data = [
        'client' => $request->client,
        'request' => $request->requests,

        'user_id' => $current_user
      ];
      $body = json_encode($data);

      //kalo udah rilis
      $url = "https://dashboard-01.dev.bantenprov.go.id/api/v1/api-manager/request";

      //untuk local
      // $url = "dashboard.local/api/v1/api-manager/receive";


      $client = new \GuzzleHttp\Client();
      $res = $client->request('POST', $url,['headers'=>$headers,'body'=>$body]);
      $response = $res->getBody();
      $responses = json_decode($response);

      $hostkey = New Hostkeys;
      $hostkey->hostname 			= str_replace(array('https://', 'http://'), array('',''),$responses->result->client);
      $hostkey->keys 			= "";
      $hostkey->state 		= $responses->result->request;
      $hostkey->transition 		= "Propose To ".$responses->result->request;
      $hostkey->user_id           = $responses->result->user_id;
      if($responses->status == 200){
        $hostkey->save();

        Session::flash('message', 'Send Request Api Keys Successfuly');
      }else {
        Session::flash('message', $responses->message);
      }

      return Redirect::to('host-keys');
  }

  /**
   * Show the form for editing the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function edit($id)
  {

  }

  /**
   * Update the specified resource in storage.
   *
   * @param  int  $id
   * @return Response
   */
   public function update(Request $request, $id)

   {
       try {
           $token 		= $request->keys;
           $hostkey = Hostkeys::findOrFail($id);
           $hostkey->hostname 			= str_replace(array('https://', 'http://'), array('',''),$request->hostname);
           $hostkey->keys 			= $token;
           $hostkey->state 		= $request->state;
           $hostkey->transition 		= $request->transition;
           $hostkey->user_id           = $request->user_id;
           if($request->state == 'Approved' || $request->state == 'Rejected'){
             $hostkey->save();

             $error = false;
             $statusCode = 200;
             $title = 'Success';
             $type = 'success';
             $message = 'Data Saved Successfuly.';
             $result = $hostkey;
           }else {
               $error = true;
               $statusCode = 404;
               $title = 'Error';
               $type = 'error';
               $message = 'Error';
               $result = 'Not Found';
           }
       } catch (Exception $e) {
           $error = true;
           $statusCode = 404;
           $title = 'Error';
           $type = 'error';
           $message = 'Error';
           $result = 'Not Found';
       } finally {
           return Response::json(array(
             'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'result' => $result
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
           ));
       }
   }

  /**
   * Remove the specified resource from storage.
   *
   * @param  int  $id
   * @return Response
   */
  public function destroy($id)
  {

  }

}

?>



Push — master ( c69a04...dc1454 )

HostkeysController::get() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Http\Controllers\Controller;
6			use Illuminate\Http\Request;
7			use App\Hostkeys;
8			use That0n3guy\Transliteration;
9
10			use GuzzleHttp\Exception\GuzzleException;
11			use GuzzleHttp\Client;
12			use GuzzleHttp\Pool;
13			use GuzzleHttp\Psr7;
14			use Auth;
15
16			use Validator, Image, Session, File, Response, Redirect, Exception;
17
18			class HostkeysController extends Controller
19			{
20
21			/**
22			* Display a listing of the resource.
23			*
24			* @return Response
25			*/
26			public function index(Request $request)
27			{
28			try {
29			if($request->get('search') != ''){
30			$data['data'] = Hostkeys::with('getState')
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-02 16:31 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
31			->with('getTransition')
32			->with('getUserName')
33			->where('hostname', 'like', '%'.$request->get('search').'%')
34			->orderBy('id', 'desc')
35			->paginate(env('PAGINATE', 10));
36			} else{
37			$data['data'] = Hostkeys::with('getState')
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-02 16:31 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38			->with('getTransition')

bantenprov / laravel-api-manager

Push — master ( c69a04...dc1454 )

HostkeysController::get() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like