ApiManagerController::transition() - Code Metrics - Inspection of "Merge pull request #28 from etanasia/master" - bantenprov/laravel-api-manager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c69a04...dc1454 )

unknown

created 2018-01-02 16:18 UTC

ApiManagerController::transition() D

↳ Parent: ApiManagerController

Complexity

Conditions	20
Paths	155

Size

Total Lines	174
Code Lines	131

Duplication

Lines	55
Ratio	31.61 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	55
loc	174
rs	4.4507
cc	20
eloc	131
nc	155
nop	1

How to fix Long Method Complexity

<?php

/**
 * @Author: bantenprov
 * @Date:   2017-11-28 00:12:29
 * @Last Modified by:   bantenprov
 * @Last Modified time: 2017-11-28 09:47:54
 */

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\ApiKeys;
use Bantenprov\Workflow\Models\WorkflowModel;
use Bantenprov\Workflow\Models\WorkflowState;
use Bantenprov\Workflow\Models\WorkflowTransition;
use Bantenprov\Workflow\Models\History;
use That0n3guy\Transliteration;

use GuzzleHttp\Exception\GuzzleException;
use GuzzleHttp\Client;
use GuzzleHttp\Pool;
use GuzzleHttp\Psr7;

use Validator, Image, Session, File, Response, Redirect, Exception;
use Auth;

class ApiManagerController extends Controller
{
    public function index(Request $request)
    {
        try {
          if($request->get('search') != ''){
            $data['data']	= ApiKeys::with('getUserName')->where('client', 'like', '%'.$request->get('search').'%')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                   ->orderBy('id', 'desc')
                                   ->paginate(env('PAGINATE', 10));
          } else{
            $data['data']	= ApiKeys::with('getUserName')->orderBy('id', 'desc')->paginate(env('PAGINATE', 10));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
          }
        } catch (Exception $e) {
            $data['data']	= [];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
    	  return view('api_manager.index', $data);
    }

    public function create()
    {
    	  return view('api_manager.create');
    }

    public function store(Request $request)
    {
      	$validator = Validator::make($request->all(), [
      		'client'			=> 'required|unique:api_keys,client',
      		'description'		=> 'required',
      		]);
      	if($validator->fails())
      	{
      		Session::flash('message', 'Please fix the error(s) below');
              return redirect()->back()
                  ->withErrors($validator)
                  ->withInput();
      	}
        if(Auth::guest()){ $current_user = 1; }
        else{ $current_user = Auth::user()->id; }

        try {
            $token 		= $this->token();
          	$api = New ApiKeys;
          	$api->client 			= str_replace(array('https://', 'http://'), array('',''),$request->client);
          	$api->api_key 			= $token;
          	$api->description 		= $request->description;
            $api->user_id           = $current_user;

            //create history default
            $model = "ApiKeys";
            $fromState = "propose";
            $toState = "propose";
            $workflow = $this->getWorkflow($model);
            $statesFrom = $this->getState($fromState);
      			$statesTo = $this->getState($toState);
      			if($workflow->count() == 0){

      				Session::flash('message', 'Error 101 #error workflow not found');
      				return Redirect::to('api-manager');
      			}elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
      				Session::flash('message', 'Error 102 #error state not active or state not found');
      				return Redirect::to('api-manager');
      			}else{
      				$api->save();
      				$this->saveHistory($api, $workflow->first(), $statesFrom->first(), $statesTo->first());

      				Session::flash('message', 'Api Keys Data Saved Successfuly');
      				return Redirect::to('api-manager');
      			}
        } catch (Exception $e) {
            Session::flash('message', 'Error 404 #error not found');
            return Redirect::to('api-manager');
        }
    }

    public function show($id)
    {
        try {
            $transition = WorkflowTransition::all();
            $data['transition'] = $transition;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $history = History::with('getApiKeys')
                               ->with('getWorkflow')
                               ->with('getStateFrom')
                               ->with('getStateTo')
                               ->with('getUserName')
                               ->where('content_id', $id)
                               ->get();

            $data['history'] = $history;
            $data['id'] = $id;
            foreach ($history as $value) {
              $workstateto = $value->getStateTo->label;
            }
            $data['workflowstateto'] = $workstateto;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        		$data['data'] = ApiKeys::where('id', $id)->first();
        	  return view('api_manager.show', $data);
        } catch (Exception $e) {
            Session::flash('message', 'Error 404 #error not found');
            return Redirect::to('api-manager');
        }
    }

    public function edit(Request $request, $id)
    {
      	$data['data']	= ApiKeys::findOrFail($id);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
      	return view('api_manager.edit', $data);
    }

    public function update(Request $request, $id)
    {
      	$validator = Validator::make($request->all(), [
      		'client'			=> 'required|unique:api_keys,client,'.$id,
      		'description'		=> 'required',
      		]);
      	if($validator->fails())
      	{
      		Session::flash('message', 'Please fix the error(s) below');
              return redirect()->back()
                  ->withErrors($validator)
                  ->withInput();
      	}

        try {
            $api = ApiKeys::findOrFail($id);
            $api->client      = str_replace(array('https://', 'http://'),array('',''),$request->client);
          	$api->description = $request->description;
          	$api->save();
          	Session::flash('message', 'Api Keys Data Update Successfuly');
          	return Redirect::to('api-manager');
        } catch (Exception $e) {
            Session::flash('message', 'Error 404 #error not found');
            return Redirect::to('api-manager');
        }
    }

    public function token()
    {
  	    $length = 70;
		    $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
		    $charactersLength = strlen($characters);
		    $randomString = '';
		    for ($i = 0; $i < $length; $i++) {
		        $randomString .= $characters[rand(0, $charactersLength - 1)];
		    }
		    return $randomString;
    }

    public function destroy($id)
    {
        try {
            ApiKeys::destroy($id);
          	Session::flash('message', 'Api Keys Data Deleted Successfuly');
          	return Redirect::to('api-manager');
        } catch (Exception $e) {
            Session::flash('message', 'Error 404 #error not found');
            return Redirect::to('api-manager');
        }
    }

    private function getWorkflow($model){
			$data = WorkflowModel::where('content_type', 'like', '%' . $model . '%');
      return $data;
    }

    private function getState($state){
      $name = \Transliteration::clean_filename(strtolower($state));
			$data = WorkflowState::where('status', 1)->where('name', 'like', '%' . $name . '%');
      return $data;
    }

    private function getHistory($content_id){
      $data = History::with('getApiKeys')
                         ->with('getWorkflow')
                         ->with('getStateFrom')
                         ->with('getStateTo')
                         ->with('getUserName')
                         ->where('content_id', $content_id);
      return $data;
    }

    private function saveHistory($api, $workflow, $statesFrom, $statesTo, $user_id = ""){
      if(Auth::guest()){ $current_user = 1; }
      else{
        if($user_id == ""){ $current_user = Auth::user()->id; }
        else { $current_user = $user_id; }
      }
    	$history = New History;
    	$history->content_id 			= $api->id;
    	$history->Workflow_id 			= $workflow->id;
      $history->from_state 			= $statesFrom->id;
    	$history->to_state 		= $statesTo->id;
      $history->user_id           = $current_user;
    	$history->save();
      return $history;
    }

    public function request(Request $request)
    {
    	$validator = Validator::make($request->all(), [
    		'client'			=> 'required',
    		'request'		=> 'required',
    		'user_id'		=> 'required',
    		]);

    	if($validator->fails())

    	{
        return Response::json(array(
            'title' => 'Error',
            'type'  => 'error',
            'message' => $validator->errors()->all()
        ));
    	}

      try {
          $client 			= str_replace(array('https://', 'http://'), array('',''),$request->input('client'));
          $requests = ucwords($request->input('request'));
          $user_id = $request->input('user_id');
          $data = ApiKeys::where('client', 'like', '%' . $client . '%');
          if($data->count() == 0){
            $token 		= $this->token();
          	$api = New ApiKeys;
          	$api->client 			= $client;
          	$api->api_key 			= $token;
          	$api->description 		= $requests;
            $api->user_id           = $user_id;

            //create history default
            $model = "ApiKeys";
            $fromState = "propose";
            $toState = "propose";
            $workflow = $this->getWorkflow($model);
            $statesFrom = $this->getState($fromState);
      			$statesTo = $this->getState($toState);
      			if($workflow->count() == 0){
                $error = true;
                $statusCode = 404;
                $title = 'Error';
                $type = 'error';
                $message = 'Error Workflow not found';
                $result = 'Not Found';
      			}
            elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
                $error = true;
                $statusCode = 404;
                $title = 'Error';
                $type = 'error';
                $message = 'Error State not active or State not found';
                $result = 'Not Found';
      			}
            else{
        				$api->save();
        				$this->saveHistory($api, $workflow->first(), $statesFrom->first(), $statesTo->first(), $user_id);
                if($requests == 'Request'){

                  $model = "ApiKeys";
                  $fromState = "propose";
                  $toState = $requests;
                  $workflow = $this->getWorkflow($model);
                  $statesFrom = $this->getState($fromState);
            			$statesTo = $this->getState($toState);
            			if($workflow->count() == 0){
                      $error = true;
                      $statusCode = 404;
                      $title = 'Error';
                      $type = 'error';
                      $message = 'Error Workflow not found';
                      $result = 'Not Found';
            			}
                  elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
                      $error = true;
                      $statusCode = 404;
                      $title = 'Error';
                      $type = 'error';
                      $message = 'Error State not active or State not found';
                      $result = 'Not Found';
            			}
                  else{
              				$this->saveHistory($api, $workflow->first(), $statesFrom->first(), $statesTo->first(), $user_id);
                      $error = false;
                      $statusCode = 200;
                      $title = 'Success';
                      $type = 'success';
                      $message = 'Data created successfully. Your request has already been send.';
                      $result = $request->all();
            			}
                }
                else{
                  $error = true;
                  $statusCode = 404;
                  $title = 'Error';
                  $type = 'error';
                  $message = 'Value Request must be Request.';
                  $result = $request->all();
                }
      			}
          }
          else {
            $get = $data->first();
            $history = $this->getHistory($get->id)->get();
            foreach ($history as $value) {
              $workstateto = $value->getStateTo->label;
            }
            if($workstateto == $requests){
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been taken.';
              $result = $request->all();
            }
            elseif($workstateto == 'Approved'){
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been Approved.';
              $result = $request->all();
            }
            elseif($workstateto == 'Rejected'){

              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been Rejected.';
              $result = $request->all();
            }
            else {

              if($requests == 'Request'){
                $model = "ApiKeys";
                $fromState = "propose";
                $toState = $requests;
                $workflow = $this->getWorkflow($model);
                $statesFrom = $this->getState($fromState);
          			$statesTo = $this->getState($toState);
          			if($workflow->count() == 0){
                    $error = true;
                    $statusCode = 404;
                    $title = 'Error';
                    $type = 'error';
                    $message = 'Error Workflow not found';
                    $result = 'Not Found';
          			}
                elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
                    $error = true;
                    $statusCode = 404;
                    $title = 'Error';
                    $type = 'error';
                    $message = 'Error State not active or State not found';
                    $result = 'Not Found';
          			}
                else{
            				$this->saveHistory($get, $workflow->first(), $statesFrom->first(), $statesTo->first(), $user_id);
                    $error = false;
                    $statusCode = 200;
                    $title = 'Success';
                    $type = 'success';
                    $message = 'Data created successfully. Your request has already been send.';
                    $result = $request->all();
          			}
              }
              else {
                $error = true;
                $statusCode = 404;
                $title = 'Error';
                $type = 'error';
                $message = 'Value Request must be Request.';
                $result = $request->all();
              }
            }
          }
      } catch (Exception $e) {
          $error = true;
          $statusCode = 404;
          $title = 'Error';
          $type = 'error';
          $message = 'Error';
          $result = 'Not Found';
      } finally {
          return Response::json(array(
            'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'result' => $result
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
          ));
      }
    }

    public function transition(Request $request)
    {
    	$validator = Validator::make($request->all(), [
    		'client'			=> 'required',
    		'request'		=> 'required',
    		]);

    	if($validator->fails())

    	{
        return Response::json(array(
            'title' => 'Error',
            'type'  => 'error',
            'message' => $validator->errors()->all()
        ));
    	}
      if(Auth::guest()){ $current_user = 1; }
      else{ $current_user = Auth::user()->id; }

      try {
          $client 			= str_replace(array('https://', 'http://'), array('',''),$request->input('client'));
          $requests = ucwords($request->input('request'));
          $data = ApiKeys::where('client', 'like', '%' . $client . '%');
          if($data->count() == 0){
            $token 		= $this->token();
          	$api = New ApiKeys;
          	$api->client 			= $client;
          	$api->api_key 			= $token;
          	$api->description 		= $requests;
            $api->user_id           = $current_user;

            //create history default
            $model = "ApiKeys";
            $fromState = "propose";
            $toState = "propose";
            $workflow = $this->getWorkflow($model);
            $statesFrom = $this->getState($fromState);
      			$statesTo = $this->getState($toState);
      			if($workflow->count() == 0){
      				Session::flash('message', 'Error 101 #error workflow not found');
      				return Redirect::to('api-manager');
      			}
            elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
      				Session::flash('message', 'Error 102 #error state not active or state not found');
      				return Redirect::to('api-manager');
      			}
            else{
        				$api->save();
        				$this->saveHistory($api, $workflow->first(), $statesFrom->first(), $statesTo->first());
                if($requests == 'Request'){
                  $model = "ApiKeys";
                  $fromState = "propose";
                  $toState = $requests;
                  $workflow = $this->getWorkflow($model);
                  $statesFrom = $this->getState($fromState);
            			$statesTo = $this->getState($toState);
            			if($workflow->count() == 0){

            				Session::flash('message', 'Error 101 #error workflow not found');
            				return Redirect::to('api-manager');
            			}
                  elseif($statesTo->count() == 0 || $statesFrom->count() == 0){
            				Session::flash('message', 'Error 102 #error state not active or state not found');
            				return Redirect::to('api-manager');
            			}
                  else{
              				$this->saveHistory($api, $workflow->first(), $statesFrom->first(), $statesTo->first());

              				Session::flash('message', 'Api Keys Data Saved Successfuly. Your request has already been send.');
              				return Redirect::to('api-manager');
            			}
                }
                else{
                    Session::flash('message', 'Error 404 #error not found');
                    return Redirect::to('api-manager');
                }
      			}
          }
          else {
            $get = $data->first();
            $history = $this->getHistory($get->id)->get();
            foreach ($history as $value) {
              $workstateto = $value->getStateTo->label;
            }
            if($workstateto == $requests){
              // kirim ke client
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been taken.';
              $result = $request->all();

      				Session::flash('message', 'Error 404 #error Data has already been taken.');
            }
            elseif($workstateto == 'Approved'){
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
              // kirim ke client
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been Approved.';
              $result = $request->all();

      				Session::flash('message', 'Error 101 #error Data has already been Approved.');
            }
            elseif($workstateto == 'Rejected'){

              // kirim ke client
              $error = true;
              $statusCode = 404;
              $title = 'Error';
              $type = 'error';
              $message = 'Data has already been Rejected.';
              $result = $request->all();

      				Session::flash('message', 'Error 101 #error Data has already been Rejected.');
            }
            else {
              $model = "ApiKeys";
              $fromState = $workstateto;
              $toState = $requests;
              $workflow = $this->getWorkflow($model);
              $statesFrom = $this->getState($fromState);
        			$statesTo = $this->getState($toState);
        			if($workflow->count() == 0){
                // kirim ke client
                $error = true;
                $statusCode = 404;
                $title = 'Error';
                $type = 'error';
                $message = 'workflow not found.';
                $result = $request->all();

        				Session::flash('message', 'Error 101 #error workflow not found');
        			}
              elseif($statesTo->count() == 0 || $statesFrom->count() == 0){

                // kirim ke client
                $error = true;
                $statusCode = 404;
                $title = 'Error';
                $type = 'error';
                $message = 'state not active or state not found.';
                $result = $request->all();

        				Session::flash('message', 'Error 102 #error state not active or state not found');
        			}
              else{
          				$this->saveHistory($get, $workflow->first(), $statesFrom->first(), $statesTo->first());
                  // kirim ke client
                  $error = false;
                  $statusCode = 200;
                  $title = 'Success';
                  $type = 'success';
                  $message = 'Data created successfully. Your request has already been send.';
                  $result = $get;

                  Session::flash('message', 'Api Keys Data Saved Successfuly. Your request has already been send.');
        			}
            }
            $history = $this->getHistory($get->id)->get();
            foreach ($history as $value) {
              $workstatefromid = $value->getStateFrom->id;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
              $workstatetoid = $value->getStateTo->id;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
              $workstatefrom = $value->getStateFrom->label;
              $workstateto = $value->getStateTo->label;
            }
            $state = $workstateto;
            $transition = $workstatefrom.' To '.$workstateto;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $this->SendClient($client, $error, $statusCode, $title, $type, $message, $result, $state, $transition);
            return Redirect::to('api-manager');
          }
      } catch (Exception $e) {
          Session::flash('message', 'Error 404 #error not found');
          return Redirect::to('api-manager');
      }
    }

    private function SendClient($client, $error, $statusCode, $title, $type, $message, $result, $state, $transition){
        if(Auth::guest()){ $current_user = 1; }
        else{ $current_user = Auth::user()->id; }
        $headers = ['Content-Type' => 'application/json'];
        $data = [
          'error' => $error,
          'status' => $statusCode,
          'title' => $title,
          'type' => $type,
          'message' => $message,
          'result' => $result,
          'hostname' => $client,
          'keys' => $result->api_key,
          'state' => $state,
          'transition' => $transition,
          'user_id' => $current_user
        ];
        $body = json_encode($data);

        //kalo udah rilis
        $urlget = $client."/api/v1/host-keys/".$client."/get";

        //untuk local
        // $url = "bloger.local/api/v1/host-keys";


        $clients = new \GuzzleHttp\Client();
        $resget = $clients->request('GET', $urlget,['headers'=>$headers]);
        $responseget = $resget->getBody();
        $responsesget = json_decode($responseget);

        if($responsesget->result != 'Not Found'){
          $clients = new \GuzzleHttp\Client();
          $url = $client."/api/v1/host-keys/".$responsesget->id;
          $res = $clients->request('PUT', $url,['headers'=>$headers,'body'=>$body]);
          $response = $res->getBody();
          $responses = json_decode($response);
        }else {
          $clients = new \GuzzleHttp\Client();
          $url = $client."/api/v1/host-keys";
          $res = $clients->request('POST', $url,['headers'=>$headers,'body'=>$body]);
          $response = $res->getBody();
          $responses = json_decode($response);
        }
        return $responses;
    }

    public function receive(Request $request){
        return Response::json(array(
          'error' => $request->error,
          'status' => $request->status,
          'title' => $request->title,
          'type' => $request->type,
          'message' => $request->message,
          'result' => $request->result
        ));
    }
}


Push — master ( c69a04...dc1454 )

ApiManagerController::transition() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* @Author: bantenprov
5			* @Date: 2017-11-28 00:12:29
6			* @Last Modified by: bantenprov
7			* @Last Modified time: 2017-11-28 09:47:54
8			*/
9
10			namespace App\Http\Controllers;
11
12			use App\Http\Controllers\Controller;
13			use Illuminate\Http\Request;
14			use App\ApiKeys;
15			use Bantenprov\Workflow\Models\WorkflowModel;
16			use Bantenprov\Workflow\Models\WorkflowState;
17			use Bantenprov\Workflow\Models\WorkflowTransition;
18			use Bantenprov\Workflow\Models\History;
19			use That0n3guy\Transliteration;
20
21			use GuzzleHttp\Exception\GuzzleException;
22			use GuzzleHttp\Client;
23			use GuzzleHttp\Pool;
24			use GuzzleHttp\Psr7;
25
26			use Validator, Image, Session, File, Response, Redirect, Exception;
27			use Auth;
28
29			class ApiManagerController extends Controller
30			{
31			public function index(Request $request)
32			{
33			try {
34			if($request->get('search') != ''){
35			$data['data'] = ApiKeys::with('getUserName')->where('client', 'like', '%'.$request->get('search').'%')
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-02 16:31 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
36			->orderBy('id', 'desc')
37			->paginate(env('PAGINATE', 10));
38			} else{
39			$data['data'] = ApiKeys::with('getUserName')->orderBy('id', 'desc')->paginate(env('PAGINATE', 10));

bantenprov / laravel-api-manager

Push — master ( c69a04...dc1454 )

ApiManagerController::transition() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like