ApiManagerController::getState() - Code Metrics - Inspection of "Merge pull request #10 from etanasia/master" - bantenprov/laravel-api-manager - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f6d194...92b4aa )

unknown

created 2017-12-16 15:06 UTC

ApiManagerController::getState() A

↳ Parent: ApiManagerController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

/**
 * @Author: ahmadnorin
 * @Date:   2017-11-28 00:12:29
 * @Last Modified by:   ahmadnorin
 * @Last Modified time: 2017-11-28 09:47:54
 */

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\ApiKeys;
use Bantenprov\Workflow\Models\WorkflowModel;
use Bantenprov\Workflow\Models\WorkflowState;
use Bantenprov\Workflow\Models\WorkflowTransition;
use Bantenprov\Workflow\Models\History;
use That0n3guy\Transliteration;
use Validator, Session, Redirect;

class ApiManagerController extends Controller
{
    public function index(Request $request)
    {
    	if($request->get('search') != '')
    	{
    	$data['data']		= ApiKeys::where('client', 'like', '%'.$request->get('search').'%')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    						->orderBy('id', 'desc')
    						->paginate(env('PAGINATE', 10));
    	}
    	else
    	{
    		$data['data']		= ApiKeys::orderBy('id', 'desc')->paginate(env('PAGINATE', 10));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    	}
    	return view('api_manager.index', $data);
    }

    public function create()
    {
    	return view('api_manager.create');
    }

    public function store(Request $request)
    {
    	$validator = Validator::make($request->all(), [
    		'client'			=> 'required|unique:api_keys,client',
    		'description'		=> 'required',
    		]);
    	if($validator->fails())
    	{
    		Session::flash('message', 'Please fix the error(s) below');
            return redirect()->back()
                ->withErrors($validator)
                ->withInput();
    	}

      $token 		= $this->token();
    	$api = New ApiKeys;
    	$api->client 			= str_replace(array('https://', 'http://'), array('',''),$request->input('client'));
    	$api->api_key 			= $token;
    	$api->description 		= $request->input('description');
      $api->user_id           = 1;
    	$api->save();

      //create history default
      $model = "ApiKeys";
      $fromState = "propose";
      $toState = "propose";
      $workflow = $this->getWorkflow($model);
      $statesFrom = $this->getState($fromState);
      $statesTo = $this->getState($toState);
      $this->saveHistory($api, $workflow, $statesFrom, $statesTo);

    	Session::flash('message', 'Api Keys Data Saved Successfuly');
    	return Redirect::to('api-manager');
    }

    public function edit(Request $request, $id)
    {
    	$data['data']	= ApiKeys::findOrFail($id);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    	return view('api_manager.edit', $data);
    }

    public function update(Request $request, $id)
    {
    	$validator = Validator::make($request->all(), [
    		'client'			=> 'required|unique:api_keys,client,'.$id,
    		'description'		=> 'required',
    		]);
    	if($validator->fails())
    	{
    		Session::flash('message', 'Please fix the error(s) below');
            return redirect()->back()
                ->withErrors($validator)
                ->withInput();
    	}

    	$api = ApiKeys::findOrFail($id);
      $api->client            = str_replace(array('https://', 'http://'),array('',''),$request->input('client'));
    	$api->description 		= $request->input('description');
    	$api->save();
    	Session::flash('message', 'Api Keys Data Update Successfuly');
    	return Redirect::to('api-manager');
    }

    public function token()
    {
  	    $length = 70;
		    $characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
		    $charactersLength = strlen($characters);
		    $randomString = '';
		    for ($i = 0; $i < $length; $i++) {
		        $randomString .= $characters[rand(0, $charactersLength - 1)];
		    }
		    return $randomString;
    }

    private function getWorkflow($model){
      $data = WorkflowModel::where('content_type', 'like', '%' . $model . '%')->get();
      return $data;
    }

    private function getState($state){
      $name = \Transliteration::clean_filename(strtolower($state));
      $data = WorkflowState::where('status', 1)->where('name', 'like', '%' . $name . '%')->get();
      return $data;
    }

    private function saveHistory($api, $workflow, $statesFrom, $statesTo){
    	$history = New History;
    	$history->content_id 			= $api->id;
    	$history->Workflow_id 			= $workflow[0]->id;
      $history->from_state 			= $statesFrom[0]->id;
    	$history->to_state 		= $statesTo[0]->id;
      $history->user_id           = 1;
    	$history->save();
      return $history;
    }
}


1			<?php
2
3			/**
4			* @Author: ahmadnorin
5			* @Date: 2017-11-28 00:12:29
6			* @Last Modified by: ahmadnorin
7			* @Last Modified time: 2017-11-28 09:47:54
8			*/
9
10			namespace App\Http\Controllers;
11
12			use Illuminate\Http\Request;
13			use App\ApiKeys;
14			use Bantenprov\Workflow\Models\WorkflowModel;
15			use Bantenprov\Workflow\Models\WorkflowState;
16			use Bantenprov\Workflow\Models\WorkflowTransition;
17			use Bantenprov\Workflow\Models\History;
18			use That0n3guy\Transliteration;
19			use Validator, Session, Redirect;
20
21			class ApiManagerController extends Controller
22			{
23			public function index(Request $request)
24			{
25			if($request->get('search') != '')
26			{
27			$data['data'] = ApiKeys::where('client', 'like', '%'.$request->get('search').'%')
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-12-09 00:35 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
28			->orderBy('id', 'desc')
29			->paginate(env('PAGINATE', 10));
30			}
31			else
32			{
33			$data['data'] = ApiKeys::orderBy('id', 'desc')->paginate(env('PAGINATE', 10));
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-12-09 00:35 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
34			}
35			return view('api_manager.index', $data);
36			}
37
38			public function create()
39			{
40			return view('api_manager.create');
41			}
42
43			public function store(Request $request)
44			{
45			$validator = Validator::make($request->all(), [
46			'client' => 'required\|unique:api_keys,client',
47			'description' => 'required',
48			]);
49			if($validator->fails())
50			{
51			Session::flash('message', 'Please fix the error(s) below');
52			return redirect()->back()
53			->withErrors($validator)
54			->withInput();
55			}
56
57			$token = $this->token();
58			$api = New ApiKeys;
59			$api->client = str_replace(array('https://', 'http://'), array('',''),$request->input('client'));
60			$api->api_key = $token;
61			$api->description = $request->input('description');
62			$api->user_id = 1;
63			$api->save();
64
65			//create history default
66			$model = "ApiKeys";
67			$fromState = "propose";
68			$toState = "propose";
69			$workflow = $this->getWorkflow($model);
70			$statesFrom = $this->getState($fromState);
71			$statesTo = $this->getState($toState);
72			$this->saveHistory($api, $workflow, $statesFrom, $statesTo);
73
74			Session::flash('message', 'Api Keys Data Saved Successfuly');
75			return Redirect::to('api-manager');
76			}
77
78			public function edit(Request $request, $id)
79			{
80			$data['data'] = ApiKeys::findOrFail($id);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-12-16 15:17 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
81			return view('api_manager.edit', $data);
82			}
83
84			public function update(Request $request, $id)
85			{
86			$validator = Validator::make($request->all(), [
87			'client' => 'required\|unique:api_keys,client,'.$id,
88			'description' => 'required',
89			]);
90			if($validator->fails())
91			{
92			Session::flash('message', 'Please fix the error(s) below');
93			return redirect()->back()
94			->withErrors($validator)
95			->withInput();
96			}
97
98			$api = ApiKeys::findOrFail($id);
99			$api->client = str_replace(array('https://', 'http://'),array('',''),$request->input('client'));
100			$api->description = $request->input('description');
101			$api->save();
102			Session::flash('message', 'Api Keys Data Update Successfuly');
103			return Redirect::to('api-manager');
104			}
105
106			public function token()
107			{
108			$length = 70;
109			$characters = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
110			$charactersLength = strlen($characters);
111			$randomString = '';
112			for ($i = 0; $i < $length; $i++) {
113			$randomString .= $characters[rand(0, $charactersLength - 1)];
114			}
115			return $randomString;
116			}
117
118			private function getWorkflow($model){
119			$data = WorkflowModel::where('content_type', 'like', '%' . $model . '%')->get();
120			return $data;
121			}
122
123			private function getState($state){
124			$name = \Transliteration::clean_filename(strtolower($state));
125			$data = WorkflowState::where('status', 1)->where('name', 'like', '%' . $name . '%')->get();
126			return $data;
127			}
128
129			private function saveHistory($api, $workflow, $statesFrom, $statesTo){
130			$history = New History;
131			$history->content_id = $api->id;
132			$history->Workflow_id = $workflow[0]->id;
133			$history->from_state = $statesFrom[0]->id;
134			$history->to_state = $statesTo[0]->id;
135			$history->user_id = 1;
136			$history->save();
137			return $history;
138			}
139			}
140

bantenprov / laravel-api-manager

Push — master ( f6d194...92b4aa )

ApiManagerController::getState() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like