This project does not seem to handle request data directly as such no vulnerable execution paths were found.
include
, or for example
via PHP's auto-loading mechanism.
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace Bantenprov\GroupEgovernment\Http\Controllers; |
||
4 | |||
5 | /* Require */ |
||
6 | use App\Http\Controllers\Controller; |
||
7 | use Illuminate\Http\Request; |
||
8 | use Bantenprov\GroupEgovernment\Facades\GroupEgovernmentFacade; |
||
9 | |||
10 | /* Models */ |
||
11 | use Bantenprov\GroupEgovernment\Models\Bantenprov\GroupEgovernment\GroupEgovernment; |
||
12 | use App\User; |
||
13 | |||
14 | /* Etc */ |
||
15 | use Validator; |
||
16 | |||
17 | /** |
||
18 | * The GroupEgovernmentController class. |
||
19 | * |
||
20 | * @package Bantenprov\GroupEgovernment |
||
21 | * @author bantenprov <[email protected]> |
||
22 | */ |
||
23 | class GroupEgovernmentController extends Controller |
||
24 | { |
||
25 | /** |
||
26 | * Create a new controller instance. |
||
27 | * |
||
28 | * @return void |
||
29 | */ |
||
30 | protected $group_egovernment; |
||
31 | protected $user; |
||
32 | |||
33 | public function __construct(GroupEgovernment $group_egovernment, User $user) |
||
34 | { |
||
35 | $this->group_egovernment = $group_egovernment; |
||
36 | $this->user = $user; |
||
37 | } |
||
38 | |||
39 | /** |
||
40 | * Display a listing of the resource. |
||
41 | * |
||
42 | * @return \Illuminate\Http\Response |
||
43 | */ |
||
44 | public function index(Request $request) |
||
45 | { |
||
46 | if ($request->has('sort')) { |
||
47 | list($sortCol, $sortDir) = explode('|', $request->sort); |
||
48 | |||
49 | $query = $this->group_egovernment->orderBy($sortCol, $sortDir); |
||
0 ignored issues
–
show
|
|||
50 | } else { |
||
51 | $query = $this->group_egovernment->orderBy('id', 'asc'); |
||
0 ignored issues
–
show
The method
orderBy does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
52 | } |
||
53 | |||
54 | if ($request->exists('filter')) { |
||
55 | $query->where(function($q) use($request) { |
||
56 | $value = "%{$request->filter}%"; |
||
57 | $q->where('label', 'like', $value) |
||
58 | ->orWhere('description', 'like', $value); |
||
59 | }); |
||
60 | } |
||
61 | |||
62 | $perPage = $request->has('per_page') ? (int) $request->per_page : null; |
||
63 | $response = $query->with('user')->paginate($perPage); |
||
64 | |||
65 | return response()->json($response) |
||
66 | ->header('Access-Control-Allow-Origin', '*') |
||
67 | ->header('Access-Control-Allow-Methods', 'GET'); |
||
68 | } |
||
69 | |||
70 | /** |
||
71 | * Show the form for creating a new resource. |
||
72 | * |
||
73 | * @return \Illuminate\Http\Response |
||
74 | */ |
||
75 | public function create() |
||
76 | { |
||
77 | $users = $this->user->all(); |
||
78 | |||
79 | foreach ($users as $user) { |
||
80 | array_set($user, 'label', $user->name); |
||
81 | } |
||
82 | |||
83 | $response['user'] = $users; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
84 | $response['status'] = true; |
||
85 | |||
86 | return response()->json($response); |
||
87 | } |
||
88 | |||
89 | /** |
||
90 | * Display the specified resource. |
||
91 | * |
||
92 | * @param \App\GroupEgovernment $group_egovernment |
||
0 ignored issues
–
show
There is no parameter named
$group_egovernment . Was it maybe removed?
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter /**
* @param array $germany
* @param array $island
* @param array $italy
*/
function finale($germany, $island) {
return "2:1";
}
The most likely cause is that the parameter was removed, but the annotation was not. ![]() |
|||
93 | * @return \Illuminate\Http\Response |
||
94 | */ |
||
95 | public function store(Request $request) |
||
96 | { |
||
97 | $group_egovernment = $this->group_egovernment; |
||
98 | |||
99 | $validator = Validator::make($request->all(), [ |
||
100 | 'user_id' => 'required', |
||
101 | 'label' => 'required|unique:group_egovernments,label', |
||
102 | 'description' => 'required', |
||
103 | ]); |
||
104 | |||
105 | if($validator->fails()){ |
||
106 | $check = $group_egovernment->where('label',$request->label)->whereNull('deleted_at')->count(); |
||
0 ignored issues
–
show
The method
where does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
107 | |||
108 | View Code Duplication | if ($check > 0) { |
|
0 ignored issues
–
show
This code seems to be duplicated across your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. ![]() |
|||
109 | $response['message'] = 'Failed, label ' . $request->label . ' already exists'; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
110 | } else { |
||
111 | $group_egovernment->label = $request->input('label'); |
||
0 ignored issues
–
show
The property
label does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
112 | $group_egovernment->description = $request->input('description'); |
||
0 ignored issues
–
show
The property
description does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
113 | $group_egovernment->user_id = $request->input('user_id'); |
||
0 ignored issues
–
show
The property
user_id does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
114 | $group_egovernment->save(); |
||
115 | |||
116 | $response['message'] = 'success'; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
117 | } |
||
118 | } else { |
||
119 | $group_egovernment->label = $request->input('label'); |
||
0 ignored issues
–
show
The property
label does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
120 | $group_egovernment->description = $request->input('description'); |
||
0 ignored issues
–
show
The property
description does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
121 | $group_egovernment->user_id = $request->input('user_id'); |
||
0 ignored issues
–
show
The property
user_id does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. ![]() |
|||
122 | $group_egovernment->save(); |
||
123 | |||
124 | $response['message'] = 'success'; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
125 | } |
||
126 | |||
127 | $response['status'] = true; |
||
128 | |||
129 | return response()->json($response); |
||
130 | } |
||
131 | |||
132 | /** |
||
133 | * Store a newly created resource in storage. |
||
134 | * |
||
135 | * @param \Illuminate\Http\Request $request |
||
0 ignored issues
–
show
There is no parameter named
$request . Was it maybe removed?
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter /**
* @param array $germany
* @param array $island
* @param array $italy
*/
function finale($germany, $island) {
return "2:1";
}
The most likely cause is that the parameter was removed, but the annotation was not. ![]() |
|||
136 | * @return \Illuminate\Http\Response |
||
137 | */ |
||
138 | public function show($id) |
||
139 | { |
||
140 | $group_egovernment = $this->group_egovernment->findOrFail($id); |
||
0 ignored issues
–
show
The method
findOrFail does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
141 | |||
142 | $response['user'] = $group_egovernment->user; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
143 | $response['group_egovernment'] = $group_egovernment; |
||
144 | $response['status'] = true; |
||
145 | |||
146 | return response()->json($response); |
||
147 | } |
||
148 | |||
149 | /** |
||
150 | * Show the form for editing the specified resource. |
||
151 | * |
||
152 | * @param \App\GroupEgovernment $group_egovernment |
||
0 ignored issues
–
show
There is no parameter named
$group_egovernment . Was it maybe removed?
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter /**
* @param array $germany
* @param array $island
* @param array $italy
*/
function finale($germany, $island) {
return "2:1";
}
The most likely cause is that the parameter was removed, but the annotation was not. ![]() |
|||
153 | * @return \Illuminate\Http\Response |
||
154 | */ |
||
155 | public function edit($id) |
||
156 | { |
||
157 | $group_egovernment = $this->group_egovernment->findOrFail($id); |
||
0 ignored issues
–
show
The method
findOrFail does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
158 | |||
159 | array_set($group_egovernment->user, 'label', $group_egovernment->user->name); |
||
160 | |||
161 | $response['user'] = $group_egovernment->user; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
162 | $response['group_egovernment'] = $group_egovernment; |
||
163 | $response['status'] = true; |
||
164 | |||
165 | return response()->json($response); |
||
166 | } |
||
167 | |||
168 | /** |
||
169 | * Update the specified resource in storage. |
||
170 | * |
||
171 | * @param \Illuminate\Http\Request $request |
||
172 | * @param \App\GroupEgovernment $group_egovernment |
||
0 ignored issues
–
show
There is no parameter named
$group_egovernment . Was it maybe removed?
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter /**
* @param array $germany
* @param array $island
* @param array $italy
*/
function finale($germany, $island) {
return "2:1";
}
The most likely cause is that the parameter was removed, but the annotation was not. ![]() |
|||
173 | * @return \Illuminate\Http\Response |
||
174 | */ |
||
175 | public function update(Request $request, $id) |
||
176 | { |
||
177 | $response = array(); |
||
178 | $message = array(); |
||
179 | |||
180 | $group_egovernment = $this->group_egovernment->findOrFail($id); |
||
0 ignored issues
–
show
The method
findOrFail does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
181 | |||
182 | $validator = Validator::make($request->all(), [ |
||
183 | 'label' => 'required|unique:group_egovernments,label,'.$id, |
||
184 | 'description' => 'required', |
||
185 | 'user_id' => 'required', |
||
186 | ]); |
||
187 | |||
188 | if($validator->fails()){ |
||
189 | |||
190 | foreach($validator->messages()->getMessages() as $key => $error){ |
||
191 | foreach($error AS $error_get) { |
||
192 | array_push($message, $error_get); |
||
193 | } |
||
194 | } |
||
195 | |||
196 | $check_label = $this->group_egovernment->where('id','!=', $id)->where('label', $request->label); |
||
0 ignored issues
–
show
The method
where does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
197 | |||
198 | View Code Duplication | if($check_label->count() > 0){ |
|
0 ignored issues
–
show
This code seems to be duplicated across your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. ![]() |
|||
199 | $response['message'] = implode("\n",$message); |
||
200 | |||
201 | } else { |
||
202 | $group_egovernment->label = $request->input('label'); |
||
203 | $group_egovernment->description = $request->input('description'); |
||
204 | $group_egovernment->user_id = $request->input('user_id'); |
||
205 | $group_egovernment->save(); |
||
206 | |||
207 | $response['message'] = 'success'; |
||
208 | } |
||
209 | |||
210 | } else { |
||
211 | $group_egovernment->label = $request->input('label'); |
||
212 | $group_egovernment->description = $request->input('description'); |
||
213 | $group_egovernment->user_id = $request->input('user_id'); |
||
214 | $group_egovernment->save(); |
||
215 | |||
216 | $response['message'] = 'success'; |
||
217 | |||
218 | } |
||
219 | |||
220 | $response['status'] = true; |
||
221 | |||
222 | return response()->json($response); |
||
223 | } |
||
224 | |||
225 | /** |
||
226 | * Remove the specified resource from storage. |
||
227 | * |
||
228 | * @param \App\GroupEgovernment $group_egovernment |
||
0 ignored issues
–
show
There is no parameter named
$group_egovernment . Was it maybe removed?
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter /**
* @param array $germany
* @param array $island
* @param array $italy
*/
function finale($germany, $island) {
return "2:1";
}
The most likely cause is that the parameter was removed, but the annotation was not. ![]() |
|||
229 | * @return \Illuminate\Http\Response |
||
230 | */ |
||
231 | public function destroy($id) |
||
232 | { |
||
233 | $group_egovernment = $this->group_egovernment->findOrFail($id); |
||
0 ignored issues
–
show
The method
findOrFail does not exist on object<Bantenprov\GroupE...nment\GroupEgovernment> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
![]() |
|||
234 | |||
235 | if ($group_egovernment->delete()) { |
||
236 | $response['loaded'] = true; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
237 | } else { |
||
238 | $response['loaded'] = false; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) {
$myArray['foo'] = $item->getFoo();
if ($item->hasBar()) {
$myArray['bar'] = $item->getBar();
}
// do something with $myArray
}
As you can see in this example, the array This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop. ![]() |
|||
239 | } |
||
240 | |||
241 | return json_encode($response); |
||
242 | } |
||
243 | } |
||
244 |
If you implement
__call
and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class.This is often the case, when
__call
is implemented by a parent class and only the child class knows which methods exist: