Bantenprov\AngkaMelekHuruf\Http\Controllers\AngkaMelekHurufController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	198
Duplicated Lines	34.34 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	index()	0	25	4
A	create()	0	9	1
B	store()	19	33	3
A	show()	9	9	1
A	edit()	9	9	1
B	update()	19	41	4
A	destroy()	12	12	2

<?php

namespace Bantenprov\AngkaMelekHuruf\Http\Controllers;

/* Require */
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Bantenprov\AngkaMelekHuruf\Facades\AngkaMelekHurufFacade;

/* Models */
use Bantenprov\AngkaMelekHuruf\Models\Bantenprov\AngkaMelekHuruf\AngkaMelekHuruf;

/* Etc */
use Validator;

/**
 * The AngkaMelekHurufController class.
 *
 * @package Bantenprov\AngkaMelekHuruf
 * @author  bantenprov <developer.bantenprov@gmail.com>
 */
class AngkaMelekHurufController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(AngkaMelekHuruf $angka_melek_huruf)
    {
        $this->angka_melek_huruf = $angka_melek_huruf;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        if (request()->has('sort')) {
            list($sortCol, $sortDir) = explode('|', request()->sort);

            $query = $this->angka_melek_huruf->orderBy($sortCol, $sortDir);
        } else {
            $query = $this->angka_melek_huruf->orderBy('id', 'asc');
        }

        if ($request->exists('filter')) {
            $query->where(function($q) use($request) {
                $value = "%{$request->filter}%";
                $q->where('label', 'like', $value)
                    ->orWhere('description', 'like', $value);
            });
        }

        $perPage = request()->has('per_page') ? (int) request()->per_page : null;
        $response = $query->paginate($perPage);

        return response()->json($response)
            ->header('Access-Control-Allow-Origin', '*')
            ->header('Access-Control-Allow-Methods', 'GET');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $angka_melek_huruf = $this->angka_melek_huruf;

        $response['angka_melek_huruf'] = $angka_melek_huruf;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($angka_melek_huruf);
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\AngkaMelekHuruf  $angka_melek_huruf

There is no parameter named $angka_melek_huruf. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $angka_melek_huruf = $this->angka_melek_huruf;

        $validator = Validator::make($request->all(), [
            'label' => 'required|max:16|unique:angka_melek_hurufs,label',
            'description' => 'max:255',
        ]);

        if($validator->fails()){

This code seems to be duplicated across your project.

            $check = $angka_melek_huruf->where('label',$request->label)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed, label ' . $request->label . ' already exists';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            } else {
                $angka_melek_huruf->label = $request->input('label');
                $angka_melek_huruf->description = $request->input('description');
                $angka_melek_huruf->save();

                $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            }
        } else {
            $angka_melek_huruf->label = $request->input('label');
            $angka_melek_huruf->description = $request->input('description');
            $angka_melek_huruf->save();

            $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request

There is no parameter named $request. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show($id)

This method seems to be duplicated in your project.

    {
        $angka_melek_huruf = $this->angka_melek_huruf->findOrFail($id);

        $response['angka_melek_huruf'] = $angka_melek_huruf;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\AngkaMelekHuruf  $angka_melek_huruf

There is no parameter named $angka_melek_huruf. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function edit($id)

This method seems to be duplicated in your project.

    {
        $angka_melek_huruf = $this->angka_melek_huruf->findOrFail($id);

        $response['angka_melek_huruf'] = $angka_melek_huruf;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\AngkaMelekHuruf  $angka_melek_huruf

There is no parameter named $angka_melek_huruf. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $angka_melek_huruf = $this->angka_melek_huruf->findOrFail($id);

        if ($request->input('old_label') == $request->input('label'))
        {
            $validator = Validator::make($request->all(), [
                'label' => 'required|max:16',
                'description' => 'max:255',
            ]);
        } else {
            $validator = Validator::make($request->all(), [
                'label' => 'required|max:16|unique:angka_melek_hurufs,label',
                'description' => 'max:255',
            ]);
        }

        if ($validator->fails()) {

This code seems to be duplicated across your project.

            $check = $angka_melek_huruf->where('label',$request->label)->whereNull('deleted_at')->count();

            if ($check > 0) {
                $response['message'] = 'Failed, label ' . $request->label . ' already exists';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            } else {
                $angka_melek_huruf->label = $request->input('label');
                $angka_melek_huruf->description = $request->input('description');
                $angka_melek_huruf->save();

                $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            }
        } else {
            $angka_melek_huruf->label = $request->input('label');
            $angka_melek_huruf->description = $request->input('description');
            $angka_melek_huruf->save();

            $response['message'] = 'success';

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        $response['status'] = true;

        return response()->json($response);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\AngkaMelekHuruf  $angka_melek_huruf

There is no parameter named $angka_melek_huruf. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $angka_melek_huruf = $this->angka_melek_huruf->findOrFail($id);

        if ($angka_melek_huruf->delete()) {
            $response['status'] = true;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        } else {
            $response['status'] = false;

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

        }

        return json_encode($response);
    }
}