MasterSeoRequest::getDestination() - Code Metrics - Inspection of "Consolidate naming" - bankiru/seo-engine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 51af85...b489fc )

by Pavel

created 2016-10-07 19:24 UTC

MasterSeoRequest::getDestination() A

↳ Parent: MasterSeoRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php

namespace Bankiru\Seo\Listener;

use Bankiru\Seo\DestinationInterface;
use Bankiru\Seo\DestinationMatcherInterface;
use Bankiru\Seo\Exception\MatchingException;
use Bankiru\Seo\Page\SeoPageInterface;

final class MasterSeoRequest
{
    /** @var  DestinationInterface */
    private $destination;
    /** @var  SeoPageInterface */
    private $page;
    /** @var  DestinationMatcherInterface */
    private $matcher;

    /**
     * MasterSeoRequest constructor.
     *
     * @param DestinationMatcherInterface $matcher
     */
    public function __construct(DestinationMatcherInterface $matcher)
    {
        $this->matcher = $matcher;
    }


    /**
     * @return DestinationInterface|null
     * @throws \LogicException
     */
    public function getDestination()
    {
        if (null === $this->destination) {
            throw new \LogicException('Destination is not set');
        }

        return $this->destination;
    }

    /**
     * @param DestinationInterface $destination
     */
    public function setDestination(DestinationInterface $destination)
    {
        $this->destination = $destination;
    }

    /**
     * @return SeoPageInterface
     * @throws \LogicException
     * @throws MatchingException
     */
    public function getPage()
    {
        if (null === $this->page) {
            $this->page = $this->matcher->match($this->getDestination());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }

        return $this->page;
    }
}


1			<?php
2
3			namespace Bankiru\Seo\Listener;
4
5			use Bankiru\Seo\DestinationInterface;
6			use Bankiru\Seo\DestinationMatcherInterface;
7			use Bankiru\Seo\Exception\MatchingException;
8			use Bankiru\Seo\Page\SeoPageInterface;
9
10			final class MasterSeoRequest
11			{
12			/** @var DestinationInterface */
13			private $destination;
14			/** @var SeoPageInterface */
15			private $page;
16			/** @var DestinationMatcherInterface */
17			private $matcher;
18
19			/**
20			* MasterSeoRequest constructor.
21			*
22			* @param DestinationMatcherInterface $matcher
23			*/
24			public function __construct(DestinationMatcherInterface $matcher)
25			{
26			$this->matcher = $matcher;
27			}
28
29
30			/**
31			* @return DestinationInterface\|null
32			* @throws \LogicException
33			*/
34			public function getDestination()
35			{
36			if (null === $this->destination) {
37			throw new \LogicException('Destination is not set');
38			}
39
40			return $this->destination;
41			}
42
43			/**
44			* @param DestinationInterface $destination
45			*/
46			public function setDestination(DestinationInterface $destination)
47			{
48			$this->destination = $destination;
49			}
50
51			/**
52			* @return SeoPageInterface
53			* @throws \LogicException
54			* @throws MatchingException
55			*/
56			public function getPage()
57			{
58			if (null === $this->page) {
59			$this->page = $this->matcher->match($this->getDestination());
			0 ignored issues – show Bug introduced 2016-10-07 19:30 UTC by Report Bug Copy Issue Report It seems like `$this->getDestination()` can be `null`; however, `match()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
60			}
61
62			return $this->page;
63			}
64			}
65

bankiru / seo-engine

Push — master ( 51af85...b489fc )

MasterSeoRequest::getDestination() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like