Bankiru\Api\Rpc\Tests\RpcTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	76
Duplicated Lines	27.63 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

61.53%

Importance

Changes	1
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getArgumentVariants()	0	14	1
A	testController()	0	15	3
A	test404()	10	10	1
A	testMethodNotFound()	11	11	1
A	getKernelClass()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: batanov.pavel
 * Date: 16.05.2016
 * Time: 13:44
 */

namespace Bankiru\Api\Rpc\Tests;

use Bankiru\Api\Rpc\Exception\InvalidMethodParametersException;
use Bankiru\Api\Rpc\Routing\Exception\MethodNotFoundException;
use Bankiru\Api\Rpc\Tests\Fixtures\Kernel;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class RpcTest extends WebTestCase
{
    public function getArgumentVariants()
    {
        return [
            'missing all'                         => [[], false],
            'missing array'                       => [['noDefault' => 1], false],
            'not an array'                        => [['noDefault' => 1, 'array' => 2], false],
            'correct'                             => [['noDefault' => 1, 'array' => ['test1' => 2, 'abc']], true],
            'correct 2'                           => [['noDefault' => 1, 'array' => ['test', 'test2']], true],
            'correct w explicit default override' => [
                ['default' => 'new_value', 'noDefault' => 1, 'array' => []],
                true,
            ],
        ];
    }

    /**
     * @dataProvider getArgumentVariants
     *
     * @param array $args
     * @param bool  $valid
     *
     * @throws InvalidMethodParametersException
     * @throws \Error
     */
    public function testController(array $args, $valid)
    {
        $client = self::createClient();
        try {
            $client->request(
                'POST',
                '/test/',
                array_replace(['method' => 'test/method',], $args)
            );
        } catch (InvalidMethodParametersException $e) {
            if ($valid) {
                throw $e;
            }
        }
    }

    /**
     * @expectedException \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
     */
    public function test404()

This method seems to be duplicated in your project.

    {
        $client = self::createClient();

        $client->request(
            'POST',
            '/not_found_endpoint/',
            array_replace(['method' => 'test/method',], ['arg' => 1])
        );
    }

    /**
     * @expectedException \Bankiru\Api\Rpc\Routing\Exception\MethodNotFoundException
     */
    public function testMethodNotFound()

This method seems to be duplicated in your project.

    {
        $client = self::createClient();

        $client->request(
            'POST',
            '/test/',
            array_replace(['method' => 'unknown/method'], ['arg' => 1])
        );

    }

    protected static function getKernelClass()
    {
        return Kernel::class;
    }
}